[GitHub] kafka pull request #2903: MINOR: Fix needless GC + Result time unit in JMH

2017-04-23 Thread original-brownbear
GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2903 MINOR: Fix needless GC + Result time unit in JMH Fixes two issues with the JMH benchmark example: * Trivial: The output should be in `ops/ms` for readability reasons (it's in the mill

[GitHub] kafka pull request #2902: kafka-5901: ReassignPartitionsCommand should prote...

2017-04-23 Thread amethystic
Github user amethystic closed the pull request at: https://github.com/apache/kafka/pull/2902 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2902: kafka-5901: ReassignPartitionsCommand should prote...

2017-04-23 Thread amethystic
GitHub user amethystic opened a pull request: https://github.com/apache/kafka/pull/2902 kafka-5901: ReassignPartitionsCommand should protect against empty re… kafka-5901: ReassignPartitionsCommand should protect against empty replica list assignment Add logic code to throw ex

[jira] [Assigned] (KAFKA-5091) ReassignPartitionsCommand should protect against empty replica list assignment

2017-04-23 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxi reassigned KAFKA-5091: --- Assignee: huxi > ReassignPartitionsCommand should protect against empty replica list > assignment > ---

[jira] [Commented] (KAFKA-5114) Clarify meaning of logs in Introduction: Topics and Logs

2017-04-23 Thread Umesh Chaudhary (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980644#comment-15980644 ] Umesh Chaudhary commented on KAFKA-5114: IMHO, it has a co-relation with the previ

[jira] [Comment Edited] (KAFKA-5065) AbstractCoordinator.ensureCoordinatorReady() stuck in loop if absent any bootstrap servers

2017-04-23 Thread james chien (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980629#comment-15980629 ] james chien edited comment on KAFKA-5065 at 4/24/17 2:28 AM: -

[jira] [Commented] (KAFKA-5065) AbstractCoordinator.ensureCoordinatorReady() stuck in loop if absent any bootstrap servers

2017-04-23 Thread james chien (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980629#comment-15980629 ] james chien commented on KAFKA-5065: Hi, I notice that why to use MAX.LONG is as the c

[jira] [Comment Edited] (KAFKA-5065) AbstractCoordinator.ensureCoordinatorReady() stuck in loop if absent any bootstrap servers

2017-04-23 Thread james chien (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980629#comment-15980629 ] james chien edited comment on KAFKA-5065 at 4/24/17 2:00 AM: -

[jira] [Assigned] (KAFKA-5025) FetchRequestTest should use batches with more than one message

2017-04-23 Thread Armin Braun (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Armin Braun reassigned KAFKA-5025: -- Assignee: Armin Braun > FetchRequestTest should use batches with more than one message > --

[GitHub] kafka pull request #2901: KAFKA-5018: LogCleaner tests to verify behaviour o...

2017-04-23 Thread original-brownbear
GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2901 KAFKA-5018: LogCleaner tests to verify behaviour of message format v2 For https://issues.apache.org/jira/browse/KAFKA-5018: * Added test for `baseOffset` behaviour after compactio

[jira] [Commented] (KAFKA-5018) LogCleaner tests to verify behaviour of message format v2

2017-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980527#comment-15980527 ] ASF GitHub Bot commented on KAFKA-5018: --- GitHub user original-brownbear opened a pul

Build failed in Jenkins: kafka-trunk-jdk8 #1453

2017-04-23 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: ProducerPerformance should work with older client jars -- [...truncated 3.22 MB...] kafka.server.epoch.LeaderEpochFileCacheTest > shouldRetur

[jira] [Commented] (KAFKA-5081) two versions of jackson-annotations-xxx.jar in distribution tgz

2017-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980483#comment-15980483 ] ASF GitHub Bot commented on KAFKA-5081: --- GitHub user dejan2609 opened a pull request

[GitHub] kafka pull request #2900: KAFKA-5081: use gradle resolution strategy 'failOn...

2017-04-23 Thread dejan2609
GitHub user dejan2609 opened a pull request: https://github.com/apache/kafka/pull/2900 KAFKA-5081: use gradle resolution strategy 'failOnVersionConflict' (in order to prevent redundant jars from being bundled into kafka distribution) You can merge this pull request into a Git repo

[jira] [Commented] (KAFKA-5081) two versions of jackson-annotations-xxx.jar in distribution tgz

2017-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980482#comment-15980482 ] ASF GitHub Bot commented on KAFKA-5081: --- Github user dejan2609 closed the pull reque

[GitHub] kafka pull request #2899: KAFKA-5081: use gradle resolution strategy 'failOn...

2017-04-23 Thread dejan2609
Github user dejan2609 closed the pull request at: https://github.com/apache/kafka/pull/2899 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] kafka pull request #2899: KAFKA-5081: use gradle resolution strategy 'failOn...

2017-04-23 Thread dejan2609
GitHub user dejan2609 opened a pull request: https://github.com/apache/kafka/pull/2899 KAFKA-5081: use gradle resolution strategy 'failOnVersionConflict' (in order to prevent redundant jars from being bundled into kafka distribution) You can merge this pull request into a Git repo

[jira] [Commented] (KAFKA-5081) two versions of jackson-annotations-xxx.jar in distribution tgz

2017-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980479#comment-15980479 ] ASF GitHub Bot commented on KAFKA-5081: --- GitHub user dejan2609 opened a pull request

[GitHub] kafka pull request #2896: Minor: Make sure ProducerPerformance can bind with...

2017-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2896 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (KAFKA-4564) When the destination brokers are down or misconfigured in config, Streams should fail fast

2017-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980432#comment-15980432 ] ASF GitHub Bot commented on KAFKA-4564: --- Github user asfgit closed the pull request

[GitHub] kafka pull request #2897: KAFKA-4564: follow up hotfix for system test

2017-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2897 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Issue Comment Deleted] (KAFKA-5016) Consumer hang in poll method while rebalancing is in progress

2017-04-23 Thread Domenico Di Giulio (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Domenico Di Giulio updated KAFKA-5016: -- Comment: was deleted (was: I am currently out of the office, with limited access to my e

[jira] [Created] (KAFKA-5115) Use bootstrap.servers to refresh metadata

2017-04-23 Thread Dan (JIRA)
Dan created KAFKA-5115: -- Summary: Use bootstrap.servers to refresh metadata Key: KAFKA-5115 URL: https://issues.apache.org/jira/browse/KAFKA-5115 Project: Kafka Issue Type: Improvement Affects Versi

[GitHub] kafka pull request #2898: kafka-5104: DumpLogSegments should not open index ...

2017-04-23 Thread amethystic
GitHub user amethystic opened a pull request: https://github.com/apache/kafka/pull/2898 kafka-5104: DumpLogSegments should not open index files with `rw` When issuing DumpLogSegments command, the underlying index files(including timestamp index) will be opened with read-only mode.

[jira] [Assigned] (KAFKA-5104) DumpLogSegments should not open index files with `rw`

2017-04-23 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxi reassigned KAFKA-5104: --- Assignee: huxi > DumpLogSegments should not open index files with `rw` >

[DISCUSS] KIP 143: Add a connect timeout for client

2017-04-23 Thread ????????
Hi all, Currently in our test environment, we found that after one of the broker node crash (reboot or os crash), the client may still be connecting to the crash node to send metadata request or other request, and it needs several minutes to be aware that the connection is timeout then try anot

Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface

2017-04-23 Thread Michal Borowiecki
However, if you're used to working with immutables, it can feel natural that withPartition would return a new object, so it could be more prone to mistakes. Cheers, Michal On 23/04/17 10:41, Michal Borowiecki wrote: IMHO, the ProducerRecord is anyway not immutable until send, since key and

Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface

2017-04-23 Thread Michal Borowiecki
IMHO, the ProducerRecord is anyway not immutable until send, since key and value don't have to immutable, until serialized on send. So if immutability is a concern, I think it would have to be enforced in send as Mike suggested, don't see much point in enforcing immutability prior to send. T