[ https://issues.apache.org/jira/browse/KAFKA-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980527#comment-15980527 ]
ASF GitHub Bot commented on KAFKA-5018: --------------------------------------- GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2901 KAFKA-5018: LogCleaner tests to verify behaviour of message format v2 For https://issues.apache.org/jira/browse/KAFKA-5018: * Added test for `baseOffset` behaviour after compaction * Added helper method for writing a multi-record batch * Dried up handling of `LogConfig.SegmentIndexBytesProp` and added comments on the chosen magic values You can merge this pull request into a Git repository by running: $ git pull https://github.com/original-brownbear/kafka KAFKA-5018 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2901.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2901 ---- commit 9a036b934feec7c81ca34b49dfd58df680a2bb97 Author: Armin Braun <m...@obrown.io> Date: 2017-04-23T13:45:11Z KAFKA-5018: LogCleaner tests to verify behaviour of message format v2 commit 959b5193e11ab87ca8a17eaff594408a57f44204 Author: Armin Braun <m...@obrown.io> Date: 2017-04-23T20:20:18Z KAFKA-5018: LogCleaner tests to verify behaviour of message format v2 ---- > LogCleaner tests to verify behaviour of message format v2 > --------------------------------------------------------- > > Key: KAFKA-5018 > URL: https://issues.apache.org/jira/browse/KAFKA-5018 > Project: Kafka > Issue Type: Sub-task > Components: clients, core, producer > Reporter: Ismael Juma > Assignee: Armin Braun > Fix For: 0.11.0.0 > > > It would be good to add LogCleaner tests to verify the behaviour of fields > like baseOffset after compaction. -- This message was sent by Atlassian JIRA (v6.3.15#6346)