Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Dong Lin
On Tue, Jan 3, 2017 at 11:01 PM, Ewen Cheslack-Postava wrote: > On Tue, Jan 3, 2017 at 6:14 PM, Dong Lin wrote: > > > Hey Ewen, > > > > Thanks for the review. As Radai explained, it would be complex in terms > of > > user configuration if we were to use committed offset to decide data > > deleti

[jira] [Resolved] (KAFKA-4308) Inconsistent parameters between console producer and consumer

2017-01-03 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxi resolved KAFKA-4308. - Resolution: Duplicate > Inconsistent parameters between console producer and consumer > --

[GitHub] kafka pull request #2307: kafka-4434: KafkaProducer configuration is logged ...

2017-01-03 Thread amethystic
GitHub user amethystic opened a pull request: https://github.com/apache/kafka/pull/2307 kafka-4434: KafkaProducer configuration is logged twice ProducerConfig calls AbstractConfig.init where does the logs. KafkaProducer init will inovoke ProducerConfig.init twice that leads to loggi

[jira] [Assigned] (KAFKA-4434) KafkaProducer configuration is logged twice

2017-01-03 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxi reassigned KAFKA-4434: --- Assignee: huxi (was: kevin.chen) > KafkaProducer configuration is logged twice > ---

[jira] [Commented] (KAFKA-4558) throttling_test fails if the producer starts too fast.

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797404#comment-15797404 ] Ewen Cheslack-Postava commented on KAFKA-4558: -- [~apurva] I'm thinking it'd b

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Ewen Cheslack-Postava
On Tue, Jan 3, 2017 at 6:14 PM, Dong Lin wrote: > Hey Ewen, > > Thanks for the review. As Radai explained, it would be complex in terms of > user configuration if we were to use committed offset to decide data > deletion. We need a way to specify which groups need to consume data of > this partit

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Ewen Cheslack-Postava
On Tue, Jan 3, 2017 at 5:30 PM, radai wrote: > also 4. some apps may do their own offset bookkeeping > This is definitely a fair point, but if you want aggressive cleanup of data in Kafka, you can dual commit with the Kafka commit happening second. I don't see how this would be a problem -- inco

[jira] [Created] (KAFKA-4587) Rethink Unification of Caching with Dedupping

2017-01-03 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-4587: Summary: Rethink Unification of Caching with Dedupping Key: KAFKA-4587 URL: https://issues.apache.org/jira/browse/KAFKA-4587 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-4535) http://kafka.apache.org/quickstart Step 8 missing argument

2017-01-03 Thread Xin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin updated KAFKA-4535: --- Resolution: Invalid Status: Resolved (was: Patch Available) > http://kafka.apache.org/quickstart Step 8 miss

[GitHub] kafka pull request #2306: MINOR: PartitionInfo toString corrected

2017-01-03 Thread Kamal15
GitHub user Kamal15 opened a pull request: https://github.com/apache/kafka/pull/2306 MINOR: PartitionInfo toString corrected - Removed the extra ',' character while printing the replicas / in-sync replicas identifier You can merge this pull request into a Git repository by running:

Jenkins build is back to normal : kafka-trunk-jdk7 #1797

2017-01-03 Thread Apache Jenkins Server
See

[jira] [Commented] (KAFKA-4535) http://kafka.apache.org/quickstart Step 8 missing argument

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797271#comment-15797271 ] ASF GitHub Bot commented on KAFKA-4535: --- Github user aurora777 closed the pull reque

[GitHub] kafka pull request #2294: KAFKA-4535: http://kafka.apache.org/quickstart Ste...

2017-01-03 Thread aurora777
Github user aurora777 closed the pull request at: https://github.com/apache/kafka/pull/2294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Build failed in Jenkins: kafka-trunk-jdk8 #1144

2017-01-03 Thread Apache Jenkins Server
See Changes: [jason] MINOR: Improvements to Record related classes (part 1) -- [...truncated 17660 lines...] org.apache.kafka.streams.KafkaStreamsTest > shouldReturnFalseOnCloseWhenThreadsHave

[jira] [Commented] (KAFKA-4584) Fail the 'kafka-configs' command if the config to be removed does not exist

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797244#comment-15797244 ] ASF GitHub Bot commented on KAFKA-4584: --- Github user asfgit closed the pull request

[GitHub] kafka pull request #2300: KAFKA-4584: Fail the 'kafka-configs' command if th...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Updated] (KAFKA-4584) Fail the 'kafka-configs' command if the config to be removed does not exist

2017-01-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-4584: - Resolution: Fixed Fix Version/s: 0.10.2.0 Status: Resolved (was: Patch Available

[GitHub] kafka pull request #2305: MINOR: Replacing for with foreach loop in stream t...

2017-01-03 Thread PKOfficial
GitHub user PKOfficial opened a pull request: https://github.com/apache/kafka/pull/2305 MINOR: Replacing for with foreach loop in stream test classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/PKOfficial/kafka code-refactor

[GitHub] kafka pull request #2271: MINOR: Improvements to Record related classes (par...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request #2304: kafka-4576: Log segments close to max size break o...

2017-01-03 Thread amethystic
GitHub user amethystic opened a pull request: https://github.com/apache/kafka/pull/2304 kafka-4576: Log segments close to max size break on fetch JVM spec does not make a guarantee that the buffer will be filled up when invoking FileChannel.read, which is called in searchOffsetWithS

[jira] [Commented] (KAFKA-4574) Transient failure in ZooKeeperSecurityUpgradeTest.test_zk_security_upgrade with security_protocol = SASL_PLAINTEXT, SSL

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797045#comment-15797045 ] Ewen Cheslack-Postava commented on KAFKA-4574: -- This is very likely the same

Re: [DISCUSS] KIP-102 - Add close with timeout for consumers

2017-01-03 Thread Jason Gustafson
Hey Rajini, Thanks for the KIP. I had a quick look at the patch and the impact doesn't seem too bad. Just wanted to clarify one point. This is from the KIP: The existing close() method without a timeout will attempt to close the > consumer gracefully with a timeout of Long.MAX_VALUE. Since commit

Build failed in Jenkins: kafka-trunk-jdk7 #1796

2017-01-03 Thread Apache Jenkins Server
See Changes: [me] KAFKA-4261: Provide debug option in vagrant-up.sh -- [...truncated 17643 lines...] org.apache.kafka.streams.processor.internals.RecordCollectorTest > testSpecificPartition PAS

[jira] [Commented] (KAFKA-4535) http://kafka.apache.org/quickstart Step 8 missing argument

2017-01-03 Thread Xin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796933#comment-15796933 ] Xin commented on KAFKA-4535: the version is 0.10.0.1,i typed the wrong version number > http:

[jira] [Updated] (KAFKA-4535) http://kafka.apache.org/quickstart Step 8 missing argument

2017-01-03 Thread Xin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin updated KAFKA-4535: --- Affects Version/s: (was: 0.10.1.0) 0.10.0.1 > http://kafka.apache.org/quickstart Step 8 mi

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Dong Lin
Hey Ewen, Thanks for the review. As Radai explained, it would be complex in terms of user configuration if we were to use committed offset to decide data deletion. We need a way to specify which groups need to consume data of this partition. The broker will also need to consume the entire offsets

Build failed in Jenkins: kafka-trunk-jdk8 #1143

2017-01-03 Thread Apache Jenkins Server
See Changes: [me] KAFKA-4261: Provide debug option in vagrant-up.sh -- [...truncated 17669 lines...] org.apache.kafka.streams.KafkaStreamsTest > shouldReturnFalseOnCloseWhenThreadsHaventTermin

[GitHub] kafka-site pull request #38: HOTFIX: MINOR: Remove duplicate list items.

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka-site/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] kafka-site issue #38: HOTFIX: MINOR: Remove duplicate list items.

2017-01-03 Thread guozhangwang
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/38 Merged to asf-site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] kafka-site issue #38: HOTFIX: MINOR: Remove duplicate list items.

2017-01-03 Thread guozhangwang
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/38 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Becket Qin
+1 On Tue, Jan 3, 2017 at 5:41 PM, Joel Koshy wrote: > +1 > > On Tue, Jan 3, 2017 at 10:54 AM, Ben Stopford wrote: > > > Hi All > > > > Please find the below KIP which proposes changing the setting > > unclean.leader.election.enabled from true to false. The motivation for > > this change is tha

Re: [VOTE] KIP-72 - Allow putting a bound on memory consumed by Incoming requests

2017-01-03 Thread Joel Koshy
+1 on the KIP. I'll comment more on the formal PR. Also, can you also link a jira for this from the KIP? Thanks, Joel On Tue, Jan 3, 2017 at 11:14 AM, radai wrote: > I've just re-validated the functionality works - broker throttles under > stress instead of OOMs. > > at this point my branch (

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Joel Koshy
+1 On Tue, Jan 3, 2017 at 10:54 AM, Ben Stopford wrote: > Hi All > > Please find the below KIP which proposes changing the setting > unclean.leader.election.enabled from true to false. The motivation for > this change is that it catches out new Kafka users who don’t realise the > default favours

Re: [DISCUSS] KIP-98: Exactly Once Delivery and Transactional Messaging

2017-01-03 Thread radai
@jun - good proposal. i was willing to concede that read-uncommitted was impossible under my proposal but if LSO/NSO is introduced is becomes possible. On Tue, Jan 3, 2017 at 7:50 AM, Jun Rao wrote: > Just to follow up on Radai's idea of pushing the buffering logic to the > broker. It may be po

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread radai
also 4. some apps may do their own offset bookkeeping On Tue, Jan 3, 2017 at 5:29 PM, radai wrote: > the issue with tracking committed offsets is whos offsets do you track? > > 1. some topics have multiple groups > 2. some "groups" are really one-offs like developers spinning up console > consum

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread radai
the issue with tracking committed offsets is whos offsets do you track? 1. some topics have multiple groups 2. some "groups" are really one-offs like developers spinning up console consumer "just to see if there's data" 3. there are use cases where you want to deliberately "wipe" data EVEN IF its

Re: Different key with the same digest in log compaction

2017-01-03 Thread radai
looking at the code (SkimpyOffsetMap.get/put) they both start with hashInto(key, hash1) and then ignore key from that point on - so we're not using the key unless im missing something? as for the probability of collision - it depends on the hash algo and the number of keys. if you configure it to

[GitHub] kafka pull request #2303: MINOR: improve license header check by providing h...

2017-01-03 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/2303 MINOR: improve license header check by providing head file instead of (prefix) header regex You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax

Jenkins build is back to normal : kafka-trunk-jdk8 #1142

2017-01-03 Thread Apache Jenkins Server
See

Re: Different key with the same digest in log compaction

2017-01-03 Thread Colin McCabe
Can you be a little bit clearer on why you think that different keys with the same digest value will be treated as the same key? SkimpyOffsetMap#get and SkimpyOffsetMap#put compare the key, not just the hash digest of the key. best, Colin On Wed, Dec 21, 2016, at 23:27, Renkai Ge wrote: > Hi,al

Re: KIP-103: Separation of Internal and External traffic

2017-01-03 Thread Colin McCabe
Good idea. It would be really nice to be able to constrain replication traffic to a specific interface or use different security settings. I'm having a little trouble understanding the "protocol label" concept. Clearly protocol labels map to protocols, but they also seem to identify particular t

[jira] [Commented] (KAFKA-4531) Rationalise client configuration validation

2017-01-03 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796664#comment-15796664 ] Vahid Hashemian commented on KAFKA-4531: [~ewencp] Just saw your earlier comment a

[jira] [Commented] (KAFKA-4531) Rationalise client configuration validation

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796651#comment-15796651 ] ASF GitHub Bot commented on KAFKA-4531: --- GitHub user vahidhashemian opened a pull re

[GitHub] kafka pull request #2302: KAFKA-4531: Centralize validation of configs for c...

2017-01-03 Thread vahidhashemian
GitHub user vahidhashemian opened a pull request: https://github.com/apache/kafka/pull/2302 KAFKA-4531: Centralize validation of configs for consumer and producer You can merge this pull request into a Git repository by running: $ git pull https://github.com/vahidhashemian/kaf

[jira] [Resolved] (KAFKA-4579) Schema Registry client should have a proper caching mechanism for schema IDs

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-4579. -- Resolution: Invalid Assignee: Ewen Cheslack-Postava Closing as this should

Re: [DISCUSS] Dormant/Inactive KIPs

2017-01-03 Thread Guozhang Wang
+1 as well. On Tue, Jan 3, 2017 at 11:43 AM, Neha Narkhede wrote: > +1. This is a good idea as we have a lot of KIPs in flight. > > On Tue, Dec 13, 2016 at 3:53 AM Ismael Juma wrote: > > > Hi all, > > > > A while back Grant proposed moving inactive/dormant KIPs to a separate > > table in the wi

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Ewen Cheslack-Postava
Dong, Looks like that's an internal link, https://cwiki.apache.org/confluence/display/KAFKA/KIP-107%3A+Add+purgeDataBefore%28%29+API+in+AdminClient is the right one. I have a question about one of the rejected alternatives: > Using committed offset instead of an extra API to trigger data purge o

[jira] [Updated] (KAFKA-4171) Kafka-connect prints outs keystone and truststore password in log2

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-4171: - Fix Version/s: 0.10.2.0 > Kafka-connect prints outs keystone and truststore passwo

Build failed in Jenkins: kafka-trunk-jdk7 #1795

2017-01-03 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-4429; Consumer lag metric should be zero if FetchResponse is empty -- [...truncated 3886 lines...] kafka.log.LogTest > testReadWithTooSmallMaxLength STARTED kafka.lo

[jira] [Resolved] (KAFKA-3294) Kafka REST API

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-3294. -- Resolution: Won't Fix Closing this for now as the KIP discussion ended with more

[jira] [Resolved] (KAFKA-4102) Is kafka mirror maker in 0.10.X don't support mirror kafka 0.8.X?

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-4102. -- Resolution: Won't Fix [yf] Currently the Java clients are only compatible with b

[jira] [Updated] (KAFKA-4102) Is kafka mirror maker in 0.10.X don't support mirror kafka 0.8.X?

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-4102: - Fix Version/s: (was: 0.10.2.0) > Is kafka mirror maker in 0.10.X don't support

[jira] [Commented] (KAFKA-4572) Kafka connect for windows is missing

2017-01-03 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796486#comment-15796486 ] Vahid Hashemian commented on KAFKA-4572: [~aravindk47] I modified the log level i

[jira] [Commented] (KAFKA-4261) Provide debug option in vagrant-up.sh

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796452#comment-15796452 ] ASF GitHub Bot commented on KAFKA-4261: --- Github user asfgit closed the pull request

[GitHub] kafka pull request #1981: KAFKA-4261: Provide debug option in vagrant-up.sh

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1981 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (KAFKA-4261) Provide debug option in vagrant-up.sh

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-4261. -- Resolution: Fixed Fix Version/s: (was: 0.11.0.0) 0.

[DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Dong Lin
Hi all, We created KIP-107 to propose addition of purgeDataBefore() API in AdminClient. Please find the KIP wiki in the link https://iwww.corp.linkedin. com/wiki/cf/display/ENGS/Kafka+purgeDataBefore%28%29+API+design+proposal. We would love to hear your comments and suggestions. Thanks, Dong

[jira] [Commented] (KAFKA-4264) kafka-server-stop.sh fails is Kafka launched via kafka-server-start.sh

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796432#comment-15796432 ] Ewen Cheslack-Postava commented on KAFKA-4264: -- Is this actually true? The ka

[jira] [Updated] (KAFKA-4586) Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-4586: Description: Please visit https://cwiki.apache.org/confluence/display/KAFKA/KIP-107%3A+Add+purgeDataBefore%2

[jira] [Resolved] (KAFKA-4258) Page not found http://kafka.apache.org/streams.html

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-4258. -- Resolution: Invalid Assignee: Ewen Cheslack-Postava [~adyachkov] Did that

[jira] [Created] (KAFKA-4586) Add purgeDataBefore() API in AdminClient

2017-01-03 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-4586: --- Summary: Add purgeDataBefore() API in AdminClient Key: KAFKA-4586 URL: https://issues.apache.org/jira/browse/KAFKA-4586 Project: Kafka Issue Type: New Feature

[jira] [Updated] (KAFKA-3429) Remove Serdes needed for repartitioning in KTable stateful operations

2017-01-03 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-3429: --- Assignee: (was: Matthias J. Sax) > Remove Serdes needed for repartitioning in KTable state

Re: [DISCUSS] KIP-105: Addition of Record Level for Sensors

2017-01-03 Thread Guozhang Wang
LGTM overall. A few comments below: 1. "METRICS_RECORD_LEVEL_CONFIG" is the internal code's variable name, but not the real config string, I think it is `metrics.record.level` instead? 2. In the Motivation section, as in "This associates each sensor with a record level ... only if the metric conf

[jira] [Commented] (KAFKA-3856) Move inner classes accessible only functions in TopologyBuilder out of public APIs

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796370#comment-15796370 ] ASF GitHub Bot commented on KAFKA-3856: --- GitHub user mjsax opened a pull request:

[GitHub] kafka pull request #2301: [WIP] [KAFKA-3856] Move inner classes accessible o...

2017-01-03 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/2301 [WIP] [KAFKA-3856] Move inner classes accessible only functions in TopologyBuilder out of public APIs You can merge this pull request into a Git repository by running: $ git pull https://github

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-03 Thread Ismael Juma
I also prefer option 1. Ismael On Fri, Dec 16, 2016 at 7:11 PM, Jason Gustafson wrote: > Thanks Vahid. To clarify the impact of this issue, since we have no way to > send an error code in the OffsetFetchResponse when requesting all offsets, > we cannot detect when the coordinator has moved to a

[jira] [Commented] (KAFKA-4429) records-lag should be zero if FetchResponse is empty

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796361#comment-15796361 ] ASF GitHub Bot commented on KAFKA-4429: --- Github user asfgit closed the pull request

[GitHub] kafka pull request #2155: KAFKA-4429; records-lag should be zero if FetchRes...

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (KAFKA-4429) records-lag should be zero if FetchResponse is empty

2017-01-03 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-4429. Resolution: Fixed Fix Version/s: 0.10.2.0 Issue resolved by pull request 2155 [https:

[jira] [Assigned] (KAFKA-4585) Offset fetch and commit requests use the same permissions

2017-01-03 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vahid Hashemian reassigned KAFKA-4585: -- Assignee: Vahid Hashemian > Offset fetch and commit requests use the same permissions >

[jira] [Commented] (KAFKA-4585) Offset fetch and commit requests use the same permissions

2017-01-03 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796353#comment-15796353 ] Vahid Hashemian commented on KAFKA-4585: [~ewencp] Sure, I'd be happy to take a lo

[jira] [Commented] (KAFKA-4585) Offset fetch and commit requests use the same permissions

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796326#comment-15796326 ] Ewen Cheslack-Postava commented on KAFKA-4585: -- [~vahid] I noticed this issue

[jira] [Created] (KAFKA-4585) Offset fetch and commit requests use the same permissions

2017-01-03 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-4585: Summary: Offset fetch and commit requests use the same permissions Key: KAFKA-4585 URL: https://issues.apache.org/jira/browse/KAFKA-4585 Project: Kafka

[jira] [Updated] (KAFKA-3856) Move inner classes accessible only functions in TopologyBuilder out of public APIs

2017-01-03 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-3856: --- Labels: api needs-kip (was: api) > Move inner classes accessible only functions in TopologyBu

[jira] [Commented] (KAFKA-1368) Upgrade log4j

2017-01-03 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796263#comment-15796263 ] Gérald Quintana commented on KAFKA-1368: It would be great to be able to mix time

[jira] [Commented] (KAFKA-2394) Use RollingFileAppender by default in log4j.properties

2017-01-03 Thread Dustin Cote (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796240#comment-15796240 ] Dustin Cote commented on KAFKA-2394: [~gquintana] I agree it would be better, but the

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Onur Karaman
+1 On Tue, Jan 3, 2017 at 1:12 PM, Sriram Subramanian wrote: > +1 > > On Tue, Jan 3, 2017 at 11:56 AM, Ian Wrigley wrote: > > > +1 from me too. When I talk to people in training classes, who are > > typically much newer to Kafka, they tend to be surprised (and > > scared/horrified) that the def

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-03 Thread Ewen Cheslack-Postava
Vahid, This looks reasonable to me and fits well with the changes made for metadata requests. -Ewen On Tue, Jan 3, 2017 at 12:12 PM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > One more try to ask for feedback on this KIP (that had to go through some > more changes after approval):

[jira] [Assigned] (KAFKA-4572) Kafka connect for windows is missing

2017-01-03 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vahid Hashemian reassigned KAFKA-4572: -- Assignee: Vahid Hashemian (was: Ewen Cheslack-Postava) > Kafka connect for windows is

Re: [VOTE] KIP-99: Add Global Tables to Kafka Streams

2017-01-03 Thread Sriram Subramanian
+1 On Tue, Jan 3, 2017 at 11:43 AM, Neha Narkhede wrote: > +1 (binding) > > On Tue, Jan 3, 2017 at 11:40 AM Ewen Cheslack-Postava > wrote: > > > +1 > > > > -Ewen > > > > On Tue, Jan 3, 2017 at 11:16 AM, Gwen Shapira wrote: > > > > > +1 > > > > > > I'm glad this super-common use-case will becom

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Sriram Subramanian
+1 On Tue, Jan 3, 2017 at 11:56 AM, Ian Wrigley wrote: > +1 from me too. When I talk to people in training classes, who are > typically much newer to Kafka, they tend to be surprised (and > scared/horrified) that the default is true. Much safer to set it to false > and let people change it when

[jira] [Updated] (KAFKA-4584) Fail the 'kafka-configs' command if the config to be removed does not exist

2017-01-03 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vahid Hashemian updated KAFKA-4584: --- Status: Patch Available (was: Open) > Fail the 'kafka-configs' command if the config to be re

Build failed in Jenkins: kafka-trunk-jdk8 #1141

2017-01-03 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-4404; Add javadocs to document core Connect types, especially that -- [...truncated 2369 lines...] kafka.api.AdminClientTest > testDescribeConsumerGroup STARTED kafka

[jira] [Commented] (KAFKA-4583) KafkaConsumerTest.testGracefulClose transient failure

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796103#comment-15796103 ] ASF GitHub Bot commented on KAFKA-4583: --- GitHub user vahidhashemian opened a pull re

[GitHub] kafka pull request #2300: KAFKA-4583: Fail the 'kafka-configs' command if th...

2017-01-03 Thread vahidhashemian
GitHub user vahidhashemian opened a pull request: https://github.com/apache/kafka/pull/2300 KAFKA-4583: Fail the 'kafka-configs' command if the config to be removed does not exist You can merge this pull request into a Git repository by running: $ git pull https://github.com/

Build failed in Jenkins: kafka-trunk-jdk8 #1140

2017-01-03 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-4561; Ordering of operations in StreamThread.shutdownTasksAndState [wangguoz] KAFKA-2434: Remove identical topic subscription constraint for [wangguoz] KAFKA-4528: Fix failure in --

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-03 Thread Vahid S Hashemian
One more try to ask for feedback on this KIP (that had to go through some more changes after approval): https://cwiki.apache.org/confluence/display/KAFKA/KIP-88%3A+OffsetFetch+Protocol+Update If there is no concern I could start the vote, hoping it could make it to the 0.10.2.0 release. Thanks

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Ian Wrigley
+1 from me too. When I talk to people in training classes, who are typically much newer to Kafka, they tend to be surprised (and scared/horrified) that the default is true. Much safer to set it to false and let people change it when they really understand the tradeoffs. Ian. --- Ian Wrigley Di

Re: [VOTE] KIP-99: Add Global Tables to Kafka Streams

2017-01-03 Thread Neha Narkhede
+1 (binding) On Tue, Jan 3, 2017 at 11:40 AM Ewen Cheslack-Postava wrote: > +1 > > -Ewen > > On Tue, Jan 3, 2017 at 11:16 AM, Gwen Shapira wrote: > > > +1 > > > > I'm glad this super-common use-case will become more performant now. > > > > On Mon, Dec 12, 2016 at 3:45 AM, Damian Guy > wrote: >

Re: [DISCUSS] Dormant/Inactive KIPs

2017-01-03 Thread Neha Narkhede
+1. This is a good idea as we have a lot of KIPs in flight. On Tue, Dec 13, 2016 at 3:53 AM Ismael Juma wrote: > Hi all, > > A while back Grant proposed moving inactive/dormant KIPs to a separate > table in the wiki. I think this is a good idea as it will make it easier > for people to see the K

Re: [VOTE] KIP-99: Add Global Tables to Kafka Streams

2017-01-03 Thread Ewen Cheslack-Postava
+1 -Ewen On Tue, Jan 3, 2017 at 11:16 AM, Gwen Shapira wrote: > +1 > > I'm glad this super-common use-case will become more performant now. > > On Mon, Dec 12, 2016 at 3:45 AM, Damian Guy wrote: > > Hi all, > > > > I'd like to start the vote for KIP-99: > > https://cwiki.apache.org/confluence/

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Neha Narkhede
Big +1. On Tue, Jan 3, 2017 at 11:22 AM Tom Crayford wrote: > +1. We've been running it in production for a long time and it's the right > default. > > On Tue, Jan 3, 2017 at 7:17 PM, Ismael Juma wrote: > > > Thanks for the KIP, +1 from me. > > > > Ismael > > > > On 3 Jan 2017 6:54 pm, "Ben Sto

[jira] [Commented] (KAFKA-3209) Support single message transforms in Kafka Connect

2017-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795937#comment-15795937 ] ASF GitHub Bot commented on KAFKA-3209: --- GitHub user shikhar opened a pull request:

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Tom Crayford
+1. We've been running it in production for a long time and it's the right default. On Tue, Jan 3, 2017 at 7:17 PM, Ismael Juma wrote: > Thanks for the KIP, +1 from me. > > Ismael > > On 3 Jan 2017 6:54 pm, "Ben Stopford" wrote: > > > Hi All > > > > Please find the below KIP which proposes chan

[GitHub] kafka pull request #2299: KAFKA-3209: KIP-66: single message transforms

2017-01-03 Thread shikhar
GitHub user shikhar opened a pull request: https://github.com/apache/kafka/pull/2299 KAFKA-3209: KIP-66: single message transforms *WIP* particularly around testing You can merge this pull request into a Git repository by running: $ git pull https://github.com/shikhar/kafka smt

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Ismael Juma
Thanks for the KIP, +1 from me. Ismael On 3 Jan 2017 6:54 pm, "Ben Stopford" wrote: > Hi All > > Please find the below KIP which proposes changing the setting > unclean.leader.election.enabled from true to false. The motivation for > this change is that it catches out new Kafka users who don’t

Re: [VOTE] KIP-99: Add Global Tables to Kafka Streams

2017-01-03 Thread Gwen Shapira
+1 I'm glad this super-common use-case will become more performant now. On Mon, Dec 12, 2016 at 3:45 AM, Damian Guy wrote: > Hi all, > > I'd like to start the vote for KIP-99: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=67633649 > > There is a PR for it here: https://githu

Re: [VOTE] KIP-72 - Allow putting a bound on memory consumed by Incoming requests

2017-01-03 Thread radai
I've just re-validated the functionality works - broker throttles under stress instead of OOMs. at this point my branch ( https://github.com/radai-rosenblatt/kafka/tree/broker-memory-pool-with-muting) is "code complete" and somewhat tested and im waiting on the voting process to come to a conclusi

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-03 Thread Gwen Shapira
I strongly support this. I've seen many users and customers accidentally lose data because they didn't know this configuration exists. I always support defaulting to "Not lose data" and let the users who prefer high availability do some extra research. This will need to be very well documented - bo

Re: [DISCUSS] KIP-104: Granular Sensors for Streams

2017-01-03 Thread Guozhang Wang
Thanks for the proposed KIP. Overall LGTM. A few comments: 1. "at the granularity of each processor node, in the addition to the global rate" I think you also add one sensor at the granularity of tasks, "Skipped records sensor in StreamTask" right? 2. From PR 1446 it seems you have also added a

  1   2   >