+1 on the KIP. I'll comment more on the formal PR. Also, can you also link a jira for this from the KIP?
Thanks, Joel On Tue, Jan 3, 2017 at 11:14 AM, radai <radai.rosenbl...@gmail.com> wrote: > I've just re-validated the functionality works - broker throttles under > stress instead of OOMs. > > at this point my branch ( > https://github.com/radai-rosenblatt/kafka/tree/broker-memory > -pool-with-muting) > is "code complete" and somewhat tested and im waiting on the voting process > to come to a conclusion before moving forward. > > On Fri, Dec 16, 2016 at 4:46 PM, radai <radai.rosenbl...@gmail.com> wrote: > > > I've added the 3 new metrics/sensors i've implemented to the KIP. > > > > at this point I would need to re-validate the functionality (which i > > expect to do early january). > > > > code reviews welcome ;-) > > > > On Mon, Nov 28, 2016 at 10:37 AM, radai <radai.rosenbl...@gmail.com> > > wrote: > > > >> will do (only added a single one so far, the rest TBD) > >> > >> On Mon, Nov 28, 2016 at 10:04 AM, Jun Rao <j...@confluent.io> wrote: > >> > >>> Hi, Radai, > >>> > >>> Could you add a high level description of the newly added metrics to > the > >>> KIP wiki? > >>> > >>> Thanks, > >>> > >>> Jun > >>> > >>> On Wed, Nov 23, 2016 at 3:45 PM, radai <radai.rosenbl...@gmail.com> > >>> wrote: > >>> > >>> > Hi Jun, > >>> > > >>> > I've added the sensor you requested (or at least I think I did ....) > >>> > > >>> > On Fri, Nov 18, 2016 at 12:37 PM, Jun Rao <j...@confluent.io> wrote: > >>> > > >>> > > KafkaRequestHandlerPool > >>> > > >>> > >> > >> > > >
