Re: [VOTE] KIP-50 - Enhance Authorizer interface to be aware of supported Principal Types

2016-04-01 Thread Jun Rao
Ashish, Thanks for the KIP. It seems that a specific implementation of Authorizer can reject invalid user type in addAcl/removeAcl without needing the new getSupportedPrincipalTypes() method, right? It's probably useful to provide the supported user types as information through CLI (e.g., when --

[jira] [Updated] (KAFKA-3493) Replica fetcher load is not balanced over fetcher threads

2016-04-01 Thread Maysam Yabandeh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maysam Yabandeh updated KAFKA-3493: --- Description: The replicas are not evenly distributed among the fetcher threads. This has caus

offsets.retention.minutes

2016-04-01 Thread William Grim
Hi, I read the reasoning about using offsets.retention.minutes at https://mail-archives.apache.org/mod_mbox/kafka-users/201602.mbox/%3ccaaofhrah8p_a1yebfnh4wzsjwgiqpob_pr6hn4nymtluqqb...@mail.gmail.com%3E, but can we agree that the original reason behind it is wrong? In my personal world view, of

Build failed in Jenkins: kafka-trunk-jdk7 #1167

2016-04-01 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: small code optimizations in streams -- [...truncated 1589 lines...] kafka.log.LogTest > testTruncateTo PASSED kafka.log.LogTest > testCleanShutdownFile PASSED k

Build failed in Jenkins: kafka-trunk-jdk8 #498

2016-04-01 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: small code optimizations in streams -- [...truncated 1615 lines...] kafka.log.LogTest > testTruncateTo PASSED kafka.log.LogTest > testCleanShutdownFile PASSED ka

Build failed in Jenkins: kafka-trunk-jdk7 #1166

2016-04-01 Thread Apache Jenkins Server
See Changes: [cshapi] KAFKA-2930: Update references to ZooKeeper in the docs. -- [...truncated 1583 lines...] kafka.log.LogTest > testTruncateTo PASSED kafka.log.LogTest > testCleanShutdownFil

1000+ GitHub pull requests closed

2016-04-01 Thread Ismael Juma
Hi all, In July 2015, the community voted to start using GitHub pull requests for contributions. Right now, just over 1000 pull requests have been closed[1], which is a nice milestone. This is only possible due to the great work by both committers and contributors. Nice one. :) Having said that,

Jenkins build is back to normal : kafka-trunk-jdk8 #497

2016-04-01 Thread Apache Jenkins Server
See

[GitHub] kafka pull request: MINOR: small code optimizations in streams

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Jenkins build is back to normal : kafka-trunk-jdk7 #1165

2016-04-01 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-0.10.0-jdk7 #28

2016-04-01 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: Fix BNF output for protocol arrays conataining primitives in docs -- [...truncated 3156 lines...] kafka.api.PlaintextConsumerTest > testAsyncCommit PASSED kafka.api

Re: [DISCUSS] KIP-50 - Enhance Authorizer interface to be aware of supported Principal Types

2016-04-01 Thread Ismael Juma
Hi Ashish, A few comments on the proposal: 1. In Kafka, we don't use use getter convention generally. However, the other methods in the `Authorizer` interface do follow the getter convention, which is unfortunate. So, I am OK with the name you suggested (getSupportedPrincipalTypes instead of supp

[jira] [Resolved] (KAFKA-2930) Update references to ZooKeeper in the docs

2016-04-01 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-2930. - Resolution: Fixed Issue resolved by pull request 615 [https://github.com/apache/kafka/pull/615] >

[jira] [Commented] (KAFKA-2930) Update references to ZooKeeper in the docs

2016-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222488#comment-15222488 ] ASF GitHub Bot commented on KAFKA-2930: --- Github user asfgit closed the pull request

[GitHub] kafka pull request: KAFKA-2930: Update references to ZooKeeper in ...

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/615 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: [DISCUSS] KIP-52 - Add Connector Control APIs

2016-04-01 Thread Ismael Juma
Hi Jason, Do I understand correctly that these requests are idempotent? If so, why are they POSTs instead of PUTs? Ismael On Thu, Mar 31, 2016 at 5:31 PM, Jason Gustafson wrote: > Hi All, I've written a short KIP to add control APIs to Kafka Connect to > make administration easier: > > https:/

Re: [DISCUSS] KIP-52 - Add Connector Control APIs

2016-04-01 Thread Gwen Shapira
Looks awesome to me, and looks like no one objects. Maybe just start a vote? On Thu, Mar 31, 2016 at 9:31 AM, Jason Gustafson wrote: > Hi All, I've written a short KIP to add control APIs to Kafka Connect to > make administration easier: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-

Build failed in Jenkins: kafka-trunk-jdk7 #1164

2016-04-01 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: add null check for aggregate and reduce operators -- [...truncated 3752 lines...] org.apache.kafka.common.config.ConfigDefTest > testInvalidDefaultString PASSED or

[jira] [Created] (KAFKA-3493) Replica fetcher load is not balanced over fetcher threads

2016-04-01 Thread Maysam Yabandeh (JIRA)
Maysam Yabandeh created KAFKA-3493: -- Summary: Replica fetcher load is not balanced over fetcher threads Key: KAFKA-3493 URL: https://issues.apache.org/jira/browse/KAFKA-3493 Project: Kafka I

[GitHub] kafka pull request: KAFKA-2844; Separate keytabs for sasl tests

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Updated] (KAFKA-2844) Use different keyTab for client and server in SASL tests

2016-04-01 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2844: Resolution: Fixed Fix Version/s: 0.10.1.0 Status: Resolved (was: Patch Available)

[jira] [Commented] (KAFKA-2844) Use different keyTab for client and server in SASL tests

2016-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222450#comment-15222450 ] ASF GitHub Bot commented on KAFKA-2844: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-3469) kafka-topics lock down znodes with user principal when zk security is enabled.

2016-04-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222443#comment-15222443 ] Ashish K Singh commented on KAFKA-3469: --- Copying some relevant info from KIP-38 disc

Build failed in Jenkins: kafka-trunk-jdk8 #496

2016-04-01 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: add null check for aggregate and reduce operators [cshapi] MINOR: Fix BNF output for protocol arrays conataining primitives in docs [cshapi] MINOR: Add check for empty topics iterator in ReplicaVerificati

Build failed in Jenkins: kafka_0.9.0_jdk7 #129

2016-04-01 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: Fix BNF output for protocol arrays conataining primitives in docs -- [...truncated 1520 lines...] kafka.integration.SaslSslTopicMetadataTest > testBasicTopicMetadata

Re: [VOTE] KIP-43: Kafka SASL enhancements

2016-04-01 Thread Grant Henke
+1 (non-binding) Might as well throw this in. Didn't realize I hadn't voted. On Fri, Apr 1, 2016 at 4:58 PM, Ismael Juma wrote: > Since the KIP changed since my last vote, +1 (non-binding). > > Rajini, do you want to wrap up the vote? It seems like we have 3 binding > +1s (Harsha, Gwen and Jun)

Build failed in Jenkins: kafka-0.10.0-jdk7 #27

2016-04-01 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: add null check for aggregate and reduce operators -- [...truncated 3116 lines...] kafka.api.PlaintextConsumerTest > testShrinkingTopicSubscriptions PASSED kafka.api.

Re: [VOTE] KIP-43: Kafka SASL enhancements

2016-04-01 Thread Ismael Juma
Since the KIP changed since my last vote, +1 (non-binding). Rajini, do you want to wrap up the vote? It seems like we have 3 binding +1s (Harsha, Gwen and Jun). Ismael On Tue, Mar 29, 2016 at 3:22 PM, Jun Rao wrote: > Rajini, > > Thanks for the update. +1 on the proposal. > > Jun > > On Tue, M

[GitHub] kafka pull request: MINOR: small code optimizations in streams

2016-04-01 Thread ymatsuda
GitHub user ymatsuda opened a pull request: https://github.com/apache/kafka/pull/1176 MINOR: small code optimizations in streams @guozhangwang You can merge this pull request into a Git repository by running: $ git pull https://github.com/ymatsuda/kafka optimize Alternativel

Re: [VOTE] KIP-4 Metadata Schema

2016-04-01 Thread Ismael Juma
+1 (non-binding) On Fri, Apr 1, 2016 at 6:38 PM, Ashish Singh wrote: > +1 (non-binding) > > On Fri, Apr 1, 2016 at 10:16 AM, Gwen Shapira wrote: > > > +1 > > > > On Fri, Apr 1, 2016 at 10:12 AM, Jason Gustafson > > wrote: > > > > > +1 (non-binding) > > > > > > On Fri, Apr 1, 2016 at 8:19 AM, G

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Ashish Singh
Gwen, I do not think it will break clients. Just to be clear we have following options. 1. Versioned apiVersion request and response. KIP-35 aware clients will send apiRequest, version Vn, to get api versions from a broker. If a broker supports Vn of apiVersion request, it will res

[jira] [Commented] (KAFKA-3492) support quota based on authenticated user name

2016-04-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222367#comment-15222367 ] Jun Rao commented on KAFKA-3492: [~aauradkar], not at this moment. So, feel free to grab t

[jira] [Commented] (KAFKA-3492) support quota based on authenticated user name

2016-04-01 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222349#comment-15222349 ] Aditya Auradkar commented on KAFKA-3492: Very cool. Jun - are you planning to driv

[GitHub] kafka pull request: MINOR: Add check for empty topics iterator in ...

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Created] (KAFKA-3492) support quota based on authenticated user name

2016-04-01 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-3492: -- Summary: support quota based on authenticated user name Key: KAFKA-3492 URL: https://issues.apache.org/jira/browse/KAFKA-3492 Project: Kafka Issue Type: New Feature

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Gwen Shapira
It isn't a guarantee, it is a limitation. It doesn't even matter what we do (have versions, no versions, deprecate or not) - clients will never be able to use version other than v0 (how will they know it is there?) and if we ever remove v0, we will immediately break all clients. If we are ok maki

[jira] [Commented] (KAFKA-3469) kafka-topics lock down znodes with user principal when zk security is enabled.

2016-04-01 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222336#comment-15222336 ] Flavio Junqueira commented on KAFKA-3469: - [~singhashish] right, you're assuming t

[GitHub] kafka pull request: MINOR: Fix BNF output for protocol arrays cona...

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (KAFKA-3480) Autogenerate metrics documentation

2016-04-01 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222328#comment-15222328 ] Gwen Shapira commented on KAFKA-3480: - >From what I've seen, the new KafkaMetrics have

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Ashish Singh
Never ever changing the version of VersionReq/resp will be ideal, but it is hard to guarantee that we will never need a change. We should definitely try to avoid it and honestly I do not see a reason, as of now, why it will change. I would say, we should keep it versioned and document any risk of c

[jira] [Commented] (KAFKA-3491) Issue with consumer close() in finally block with 'enable.auto.commit=true'

2016-04-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222317#comment-15222317 ] Guozhang Wang commented on KAFKA-3491: -- This somewhat related to https://issues.apach

Re: [VOTE] KIP-50 - Enhance Authorizer interface to be aware of supported Principal Types

2016-04-01 Thread Guozhang Wang
+1. On Thu, Mar 31, 2016 at 4:10 PM, parth brahmbhatt < brahmbhatt.pa...@gmail.com> wrote: > +1 > > Thanks > Parth > > On Wed, Mar 30, 2016 at 8:22 PM, Ewen Cheslack-Postava > wrote: > > > +1 > > > > -Ewen > > > > On Wed, Mar 30, 2016 at 7:20 PM, Gwen Shapira wrote: > > > > > So my +1 is back :

[GitHub] kafka pull request: MINOR: add null check for aggregate and reduce...

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Gwen Shapira
I am happy with: 1. Adding only validation support in the client for now, deferring backward compatibility for later. With the odd side-effect of having the C and Python clients actually better than Java for a bit. 2. Never ever changing the version of VersionRequest and VersionResponse. I'd also

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Guozhang Wang
Sounds good. On Fri, Apr 1, 2016 at 12:01 PM, Gwen Shapira wrote: > I like the alternative. I'll be happy to do the weekly merges. > > Would be happy to hear other opinions. > > Gwen > > On Fri, Apr 1, 2016 at 11:55 AM, Ismael Juma wrote: > > > My concern is that this is error-prone and things

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Jason Gustafson
I'm sympathetic to Jay's argument, but I feel the version API can be justified on its own without requiring a big change in the way we manage compatibility. For the official client compatibility story (i.e. what the Java client implements), we can use this API to verify compatibility with the broke

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Jay Kreps
Also, just wanted to add that I get that people are impatient with this. It's super frustrating to kind of think on a plan for a chunk of time without checking in any code. But I do think we only just got to a workable proposal so most of the delay hasn't been process but actual genuine iteration o

Build failed in Jenkins: kafka-0.10.0-jdk7 #26

2016-04-01 Thread Apache Jenkins Server
See Changes: [me] KAFKA-2910: Close Zookeeper clients in unit tests -- [...truncated 1600 lines...] kafka.api.PlaintextConsumerTest > testMultiConsumerRoundRobinAssignment PASSED kafka.api.Plain

Build failed in Jenkins: kafka-trunk-jdk7 #1163

2016-04-01 Thread Apache Jenkins Server
See Changes: [me] KAFKA-2910: Close Zookeeper clients in unit tests -- [...truncated 1564 lines...] kafka.consumer.ZookeeperConsumerConnectorTest > testConsumerDecoder PASSED kafka.consumer.Zo

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Gwen Shapira
I like the alternative. I'll be happy to do the weekly merges. Would be happy to hear other opinions. Gwen On Fri, Apr 1, 2016 at 11:55 AM, Ismael Juma wrote: > My concern is that this is error-prone and things can be missed (it > happened during the 0.9.0.0 release for example). It's a cost w

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Ismael Juma
My concern is that this is error-prone and things can be missed (it happened during the 0.9.0.0 release for example). It's a cost worth paying when stabilising but not so clear when accepting major new features. One alternative would be to just commit to trunk and merge trunk to 0.10.0 weekly or s

[GitHub] kafka pull request: MINOR: add null check for aggregate and reduce...

2016-04-01 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/1175 MINOR: add null check for aggregate and reduce operators You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KSNullPointerEx

Build failed in Jenkins: kafka-trunk-jdk8 #495

2016-04-01 Thread Apache Jenkins Server
See Changes: [me] KAFKA-2910: Close Zookeeper clients in unit tests -- [...truncated 1577 lines...] kafka.log.BrokerCompressionTest > testBrokerSideCompression[7] PASSED kafka.log.BrokerCompres

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Gwen Shapira
I prefer keeping the current branch and double-committing for three weeks. Not fun, but not end-of-world hard. Unless committers object? On Fri, Apr 1, 2016 at 11:40 AM, Guozhang Wang wrote: > Ismael, > > Shall we "delete" the 0.10.0 branch after going through its commits and > making sure all

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Guozhang Wang
Ismael, Shall we "delete" the 0.10.0 branch after going through its commits and making sure all of them are already in trunk then? I think it is doable in github? Guozhang On Fri, Apr 1, 2016 at 11:24 AM, Jason Gustafson wrote: > Hey Gwen, > > KIP-52 would be nice to get in as well. It's a sma

[jira] [Commented] (KAFKA-3338) Add print and writeAsText functions to the Streams DSL

2016-04-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222135#comment-15222135 ] Guozhang Wang commented on KAFKA-3338: -- [~bbejeck] I think we can overload the print

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Gwen Shapira
My understanding is that we are not adding the client portion to the KIP is because we believe it will require a lot of discussion (read: will be really hard to get right). Maybe it is a hint that this protocol is too difficult for clients to implement? I can't see why is it easy in C and Python a

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Gwen Shapira
Sorry guys! KIP-51 is already in. I meant KIP-52! My mistake, Jason. On Fri, Apr 1, 2016 at 11:24 AM, Jason Gustafson wrote: > Hey Gwen, > > KIP-52 would be nice to get in as well. It's a small feature, but really > helpful for Connect users. A patch for the first half is already available, > t

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Jason Gustafson
Hey Gwen, KIP-52 would be nice to get in as well. It's a small feature, but really helpful for Connect users. A patch for the first half is already available, though it may need adjustment depending on the discussion. Thanks, Jason On Fri, Apr 1, 2016 at 11:09 AM, Ismael Juma wrote: > Hi Gwen,

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Jay Kreps
Hey Ewen, with protocol design I actually do think good is the enemy of perfect (not sure if that makes sense but I think you get what I mean). Your comment seemed to be along the lines of "this isn't very good, but let's do something". Can you elaborate on what you think we should be doing? The o

[jira] [Commented] (KAFKA-3491) Issue with consumer close() in finally block with 'enable.auto.commit=true'

2016-04-01 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222102#comment-15222102 ] Jason Gustafson commented on KAFKA-3491: Good catch. The best workaround at the mo

[jira] [Comment Edited] (KAFKA-3469) kafka-topics lock down znodes with user principal when zk security is enabled.

2016-04-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222093#comment-15222093 ] Ashish K Singh edited comment on KAFKA-3469 at 4/1/16 6:17 PM: -

[jira] [Commented] (KAFKA-3469) kafka-topics lock down znodes with user principal when zk security is enabled.

2016-04-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222093#comment-15222093 ] Ashish K Singh commented on KAFKA-3469: --- [~fpj] say a kafka broker process was start

Re: [RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Ismael Juma
Hi Gwen, What is the plan for the 0.10.0 branch? Double-committing seems a bit wasteful given this change. Ismael On 1 Apr 2016 18:54, "Gwen Shapira" wrote: > Hey Team Kafka, > > Per community discussion, I will not be rolling out a new candidate on > Monday. > > I will roll out the next relea

[GitHub] kafka pull request: MINOR: Fix BNF output for protocol arrays cona...

2016-04-01 Thread granthenke
GitHub user granthenke opened a pull request: https://github.com/apache/kafka/pull/1174 MINOR: Fix BNF output for protocol arrays conataining primitives in docs Before this patch arrays containing primitive types were not output: Metadata Request (Version: 0) => [topics]

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Ashish Singh
That is a fair concern and I think eventually we might want to have java clients backwards compatible. However, blocking KIP-35 on that might not be the best idea. The reason I say so is due to following reasons. 1. Backwards compatibility in java clients is a larger discussion, as we have already

[RELEASE UPDATE] Postponing the next release candidates and canceling current vote

2016-04-01 Thread Gwen Shapira
Hey Team Kafka, Per community discussion, I will not be rolling out a new candidate on Monday. I will roll out the next release candidate in three weeks: Friday, April 22. We can spend Kafka Summit discussing the quality of the release :) The goal is to get it the following improvements: KIP-4-m

[jira] [Commented] (KAFKA-2910) Failure in kafka.api.SslEndToEndAuthorizationTest.testNoGroupAcl

2016-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222063#comment-15222063 ] ASF GitHub Bot commented on KAFKA-2910: --- Github user asfgit closed the pull request

[jira] [Resolved] (KAFKA-2910) Failure in kafka.api.SslEndToEndAuthorizationTest.testNoGroupAcl

2016-04-01 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-2910. -- Resolution: Fixed Fix Version/s: 0.10.1.0 Issue resolved by pull request

[GitHub] kafka pull request: KAFKA-2910: Close Zookeeper clients in unit te...

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Assigned] (KAFKA-3491) Issue with consumer close() in finally block with 'enable.auto.commit=true'

2016-04-01 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-3491: -- Assignee: Jason Gustafson (was: Neha Narkhede) > Issue with consumer close() in finall

Re: [VOTE] KIP-4 Metadata Schema

2016-04-01 Thread Ashish Singh
+1 (non-binding) On Fri, Apr 1, 2016 at 10:16 AM, Gwen Shapira wrote: > +1 > > On Fri, Apr 1, 2016 at 10:12 AM, Jason Gustafson > wrote: > > > +1 (non-binding) > > > > On Fri, Apr 1, 2016 at 8:19 AM, Grant Henke wrote: > > > > > I would like to start the voting process for the "KIP-4 Metadata

[jira] [Created] (KAFKA-3491) Issue with consumer close() in finally block with 'enable.auto.commit=true'

2016-04-01 Thread dan norwood (JIRA)
dan norwood created KAFKA-3491: -- Summary: Issue with consumer close() in finally block with 'enable.auto.commit=true' Key: KAFKA-3491 URL: https://issues.apache.org/jira/browse/KAFKA-3491 Project: Kafka

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Ewen Cheslack-Postava
On Fri, Apr 1, 2016 at 10:22 AM, Gwen Shapira wrote: > I have two concerns with the proposal as it is: > > 1. Having an API that publishes protocol is useless for clients if > developers don't bump the API when they should. > I would like to see good documentation on when protocols are bumped and

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Gwen Shapira
I have two concerns with the proposal as it is: 1. Having an API that publishes protocol is useless for clients if developers don't bump the API when they should. I would like to see good documentation on when protocols are bumped and a proposal on how this will be automatically validated to the e

Re: [VOTE] KIP-4 Metadata Schema

2016-04-01 Thread Gwen Shapira
+1 On Fri, Apr 1, 2016 at 10:12 AM, Jason Gustafson wrote: > +1 (non-binding) > > On Fri, Apr 1, 2016 at 8:19 AM, Grant Henke wrote: > > > I would like to start the voting process for the "KIP-4 Metadata Schema > > changes". This is not a vote for all of KIP-4, but specifically for the > > meta

Re: [VOTE] KIP-4 Metadata Schema

2016-04-01 Thread Jason Gustafson
+1 (non-binding) On Fri, Apr 1, 2016 at 8:19 AM, Grant Henke wrote: > I would like to start the voting process for the "KIP-4 Metadata Schema > changes". This is not a vote for all of KIP-4, but specifically for the > metadata changes. I have included the exact changes below for clarity: > > > M

[jira] [Commented] (KAFKA-3490) Multiple version support for ducktape performance tests

2016-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221976#comment-15221976 ] ASF GitHub Bot commented on KAFKA-3490: --- GitHub user ijuma opened a pull request:

[GitHub] kafka pull request: KAFKA-3490; Multiple version support for duckt...

2016-04-01 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/1173 KAFKA-3490; Multiple version support for ducktape performance tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/confluentinc/kafka kafka-3490

[jira] [Created] (KAFKA-3490) Multiple version support for ducktape performance tests

2016-04-01 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-3490: -- Summary: Multiple version support for ducktape performance tests Key: KAFKA-3490 URL: https://issues.apache.org/jira/browse/KAFKA-3490 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-3068) NetworkClient may connect to a different Kafka cluster than originally configured

2016-04-01 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3068: --- Assignee: Eno Thereska (was: Ismael Juma) > NetworkClient may connect to a different Kafka cluster th

[jira] [Assigned] (KAFKA-3068) NetworkClient may connect to a different Kafka cluster than originally configured

2016-04-01 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-3068: -- Assignee: Ismael Juma (was: Eno Thereska) > NetworkClient may connect to a different Kafka clu

[jira] [Comment Edited] (KAFKA-725) Broker Exception: Attempt to read with a maximum offset less than start offset

2016-04-01 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221673#comment-15221673 ] Stig Rohde Døssing edited comment on KAFKA-725 at 4/1/16 3:38 PM: ---

[VOTE] KIP-4 Metadata Schema

2016-04-01 Thread Grant Henke
I would like to start the voting process for the "KIP-4 Metadata Schema changes". This is not a vote for all of KIP-4, but specifically for the metadata changes. I have included the exact changes below for clarity: > Metadata Request (version 1) > > > > MetadataRequest => [topics] > > Stays the sa

Re: SSL authorization mechanizm

2016-04-01 Thread Kalpesh Jadhav
Hi Team, Is there any java api available to give access to topic. As we are creating topic dynamically, need to give write access, to send messages. Just wanted to run below command through java api. bin/kafka-acls.sh --add --allow-principals user:ctadmin --operation ALL --topic marchTesting --

[jira] [Comment Edited] (KAFKA-725) Broker Exception: Attempt to read with a maximum offset less than start offset

2016-04-01 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221673#comment-15221673 ] Stig Rohde Døssing edited comment on KAFKA-725 at 4/1/16 1:16 PM: ---

[jira] [Commented] (KAFKA-725) Broker Exception: Attempt to read with a maximum offset less than start offset

2016-04-01 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221673#comment-15221673 ] Stig Rohde Døssing commented on KAFKA-725: -- We're seeing this on 8.2.2. I'm not su

[jira] [Updated] (KAFKA-3489) Update request metrics if client closes connection while broker response is in flight

2016-04-01 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3489: --- Status: Patch Available (was: Open) > Update request metrics if client closes connection while broker

[jira] [Commented] (KAFKA-3489) Update request metrics if client closes connection while broker response is in flight

2016-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221604#comment-15221604 ] ASF GitHub Bot commented on KAFKA-3489: --- GitHub user ijuma opened a pull request:

[GitHub] kafka pull request: KAFKA-3489; Update request metrics if a client...

2016-04-01 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/1172 KAFKA-3489; Update request metrics if a client closes a connection while the broker response is in flight I also fixed a few issues in `SocketServerTest` and included a few clean-ups. You can merge

[jira] [Updated] (KAFKA-3489) Update request metrics if client closes connection while broker response is in flight

2016-04-01 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3489: --- Fix Version/s: 0.10.0.0 > Update request metrics if client closes connection while broker response is

[jira] [Created] (KAFKA-3489) Update request metrics if client closes connection while broker response is in flight

2016-04-01 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-3489: -- Summary: Update request metrics if client closes connection while broker response is in flight Key: KAFKA-3489 URL: https://issues.apache.org/jira/browse/KAFKA-3489 Proje

[jira] [Commented] (KAFKA-2910) Failure in kafka.api.SslEndToEndAuthorizationTest.testNoGroupAcl

2016-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221387#comment-15221387 ] ASF GitHub Bot commented on KAFKA-2910: --- GitHub user rajinisivaram opened a pull req

[GitHub] kafka pull request: KAFKA-2910: Close Zookeeper clients in unit te...

2016-04-01 Thread rajinisivaram
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/1171 KAFKA-2910: Close Zookeeper clients in unit tests Zookeeper clients that are not closed after the server is shutdown keep trying to reconnect, reloading JAAS configuration. This impacts subseq

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Ismael Juma
Two more things: 3. We talk about backporting of new request versions to stable branches in the KIP. In practice, we can't do that until the Java client is changed so that it doesn't blindly use the latest protocol version. Otherwise, if new request versions were added to 0.9.0.2, the client would

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Ismael Juma
A couple of questions: 1. The KIP says "Specific version may be deprecated through protocol documentation but must still be supported (although it is fair to return an error code if the specific API supports it).". It may be worth expanding this a little more. For example, what does it mean to sup

Re: [DISCUSS] KIP-35 - Retrieve protocol version

2016-04-01 Thread Ewen Cheslack-Postava
I agree in a "perfect is the enemy of good" sense. I don't think what's expressed in the API is necessarily the *ideal* thing for client developers, which is who I think this API should be optimizing for. That said, this is a practical solution to the problem and while finer-grained than I think is