[
https://issues.apache.org/jira/browse/KAFKA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221604#comment-15221604
]
ASF GitHub Bot commented on KAFKA-3489:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/1172
KAFKA-3489; Update request metrics if a client closes a connection while
the broker response is in flight
I also fixed a few issues in `SocketServerTest` and included a few
clean-ups.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-3489-update-request-metrics-if-client-closes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1172
----
commit 896a0ff83060a06c08835f32d0734baa6a61a98a
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-04-01T00:52:47Z
Close client sockets on `tearDown`
commit f62f9e008cde85325265c53fb3db75eda1cc0cad
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-04-01T00:54:04Z
Fix `testMaxConnectionsPerIpOverrides` to do what it's supposed to do
commit 23c4acc664bf0e6610917af5cfae1f10cfe3a7d6
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-04-01T11:26:34Z
Update request metrics if a client closes a connection while the broker
response is in flight
commit d94b9b3e853a3ae2528eafbe56b9b54e03551dec
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2016-04-01T11:28:41Z
Minor clean-ups in `Selector` and `RequestChannel`
----
> Update request metrics if client closes connection while broker response is
> in flight
> -------------------------------------------------------------------------------------
>
> Key: KAFKA-3489
> URL: https://issues.apache.org/jira/browse/KAFKA-3489
> Project: Kafka
> Issue Type: Bug
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Fix For: 0.10.0.0
>
>
> We currently don't update request metrics or request logging for this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
