[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484816#comment-14484816 ] Ewen Cheslack-Postava commented on KAFKA-2102: -- Just my 2 cents, but I'm wary

Build failed in Jenkins: Kafka-trunk #452

2015-04-07 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1517; Messages is a required argument to Producer Performance Test; patched by Daniel Compton; reviewed by Jun Rao -- [...truncated 608 lines...] kafka.log.LogManagerTest

jira backlogs

2015-04-07 Thread Jun Rao
Hi, everyone, Currently, we have accumulated quite a few jira backlogs. We can probably brainstorm a bit what we can do to improve this. A few thoughts. 1. There are quite a few jiras marked with "patch available", but with unaddressed review comments. I made a pass and moved them back to "in pro

Build failed in Jenkins: KafkaPreCommit #64

2015-04-07 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1517; Messages is a required argument to Producer Performance Test; patched by Daniel Compton; reviewed by Jun Rao -- [...truncated 1536 lines...] kafka.consumer.TopicF

[VOTE] KIP-13 Quotas

2015-04-07 Thread Aditya Auradkar
Please vote. https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas Thanks, Aditya

RE: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-07 Thread Aditya Auradkar
Hey everyone, Following up after today's hangout. After discussing the client side metrics piece internally, we've incorporated that section into the KIP. https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas Since there appears to be sufficient consensus, I'm going to start a voting

[jira] [Updated] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-902: -- Status: In Progress (was: Patch Available) > Randomize backoff on the clients for metadata requests > --

[jira] [Updated] (KAFKA-1215) Rack-Aware replica assignment option

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1215: --- Status: In Progress (was: Patch Available) > Rack-Aware replica assignment option > -

[jira] [Updated] (KAFKA-1277) Keep the summery/description when updating the RB with kafka-patch-review

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1277: --- Status: In Progress (was: Patch Available) > Keep the summery/description when updating the RB with kafka-pat

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: KAFKA-2102_2015-04-08_00:20:33.patch > Remove unnecessary synchronization when managing meta

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484737#comment-14484737 ] Tim Brooks commented on KAFKA-2102: --- I updated my WIP patch to ensure that all tests are

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484735#comment-14484735 ] Tim Brooks commented on KAFKA-2102: --- Updated reviewboard https://reviews.apache.org/r/32

Re: Review Request 32937: Patch for KAFKA-2102

2015-04-07 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/ --- (Updated April 8, 2015, 5:21 a.m.) Review request for kafka. Bugs: KAFKA-2102

[jira] [Updated] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1517: --- Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Daniel Compton Status: Resolved (w

Build failed in Jenkins: Kafka-trunk #451

2015-04-07 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1973; Remove the accidentally created LogCleanerManager.scala.orig; patched by Grant Henke; reviewed by Jun Rao -- [...truncated 1243 lines...] kafka.log.LogManagerTest >

[jira] [Updated] (KAFKA-1669) Default rebalance retries and backoff should be higher

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1669: --- Resolution: Won't Fix Status: Resolved (was: Patch Available) Resolving this for now. Please reopen i

[jira] [Updated] (KAFKA-1675) bootstrapping tidy-up

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1675: --- Status: In Progress (was: Patch Available) > bootstrapping tidy-up > - > >

[jira] [Updated] (KAFKA-1737) Document required ZkSerializer for ZkClient used with AdminUtils

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1737: --- Status: In Progress (was: Patch Available) > Document required ZkSerializer for ZkClient used with AdminUtils

[jira] [Updated] (KAFKA-1753) add --decommission-broker option

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1753: --- Status: In Progress (was: Patch Available) > add --decommission-broker option > -

[jira] [Updated] (KAFKA-1772) Add an Admin message type for request response

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1772: --- Status: In Progress (was: Patch Available) > Add an Admin message type for request response > ---

[jira] [Updated] (KAFKA-1774) REPL and Shell Client for Admin Message RQ/RP

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1774: --- Status: In Progress (was: Patch Available) > REPL and Shell Client for Admin Message RQ/RP >

[jira] [Updated] (KAFKA-1775) Re-factor TopicCommand into thew handerAdminMessage call

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1775: --- Status: In Progress (was: Patch Available) > Re-factor TopicCommand into thew handerAdminMessage call >

[jira] [Updated] (KAFKA-1802) Add a new type of request for the discovery of the controller

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1802: --- Status: In Progress (was: Patch Available) > Add a new type of request for the discovery of the controller >

Re: Review Request 32953: Patch for KAFKA-2104

2015-04-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32953/#review79296 --- core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala

[jira] [Created] (KAFKA-2105) NullPointerException in client on MetadataRequest

2015-04-07 Thread Roger Hoover (JIRA)
Roger Hoover created KAFKA-2105: --- Summary: NullPointerException in client on MetadataRequest Key: KAFKA-2105 URL: https://issues.apache.org/jira/browse/KAFKA-2105 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-1882) Create extendable channel interface and default implementations

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1882: --- Status: In Progress (was: Patch Available) > Create extendable channel interface and default implementations

[jira] [Updated] (KAFKA-1887) controller error message on shutting the last broker

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1887: --- Status: In Progress (was: Patch Available) > controller error message on shutting the last broker > -

[jira] [Updated] (KAFKA-1888) Add a "rolling upgrade" system test

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1888: --- Status: In Progress (was: Patch Available) > Add a "rolling upgrade" system test > --

[jira] [Updated] (KAFKA-1906) Default the Kafka log directory to a relative path within the Kafka installation directory

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1906: --- Status: In Progress (was: Patch Available) > Default the Kafka log directory to a relative path within the Ka

[jira] [Updated] (KAFKA-1907) ZkClient can block controlled shutdown indefinitely

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1907: --- Status: In Progress (was: Patch Available) > ZkClient can block controlled shutdown indefinitely > --

[jira] [Updated] (KAFKA-1953) Disambiguate metrics from different purgatories

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1953: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Resolved thi

[jira] [Updated] (KAFKA-1973) Remove the accidentally created LogCleanerManager.scala.orig

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1973: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Updated] (KAFKA-1954) Speed Up The Unit Tests

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1954: --- Status: In Progress (was: Patch Available) Thanks for the patch. Left a few review comments on the RB. > Spe

[jira] [Updated] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1982: --- Status: In Progress (was: Patch Available) Sorry for the late review. Left a few more comments on the RB. >

Re: [DISCUSSION] Should we enable topic deletion by default?

2015-04-07 Thread Jun Rao
Yes, the delete topic feature itself is much stable now. However, there are a couple of limitations. (1) If there is a running consumer, the topic will be auto-created again since currently a TopicMetadataRequest triggers a topic creation. (2) The associated consumer offsets associated with the del

[jira] [Assigned] (KAFKA-1690) new java producer needs ssl support as a client

2015-04-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1690: - Assignee: Sriharsha Chintalapani (was: Ivan Lyutov) > new java producer

[jira] [Assigned] (KAFKA-1691) new java consumer needs ssl support as a client

2015-04-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1691: - Assignee: Sriharsha Chintalapani (was: Ivan Lyutov) > new java consumer

[jira] [Commented] (KAFKA-1656) "replica-assignment" option in "bin/kakfa-topics.sh" doesn't work with "alter"

2015-04-07 Thread Daisuke Kobayashi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484599#comment-14484599 ] Daisuke Kobayashi commented on KAFKA-1656: -- Per my understand, kafka-reassign-par

[DISCUSSION] Should we enable topic deletion by default?

2015-04-07 Thread Gwen Shapira
Hi, Trying to see how the community feels about KAFKA-1993. Currently "delete topic" feature is disabled by default and must be enabled by admins. Why enable by default? * Ability to delete topics is kind of expected (and exposed in admin tools), so people are surprised when they need to tweak a

[jira] [Commented] (KAFKA-1993) Enable topic deletion as default

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484581#comment-14484581 ] Gwen Shapira commented on KAFKA-1993: - I think the patch is pretty neutral security-wi

Re: Review Request 32953: Patch for KAFKA-2104

2015-04-07 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32953/#review79292 --- Ship it! Ship It! - Sriharsha Chintalapani On April 8, 2015, 1:5

[jira] [Updated] (KAFKA-2104) testDuplicateListeners() has a typo

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2104: Status: Patch Available (was: Open) > testDuplicateListeners() has a typo > -

[jira] [Updated] (KAFKA-2104) testDuplicateListeners() has a typo

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2104: Attachment: KAFKA-2104.patch > testDuplicateListeners() has a typo > -

Review Request 32953: Patch for KAFKA-2104

2015-04-07 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32953/ --- Review request for kafka. Bugs: KAFKA-2104 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2104) testDuplicateListeners() has a typo

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484543#comment-14484543 ] Gwen Shapira commented on KAFKA-2104: - Created reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484538#comment-14484538 ] Gwen Shapira commented on KAFKA-1809: - Thanks [~onurkaraman], created KAFKA-2104 to tr

[jira] [Created] (KAFKA-2104) testDuplicateListeners() has a typo

2015-04-07 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-2104: --- Summary: testDuplicateListeners() has a typo Key: KAFKA-2104 URL: https://issues.apache.org/jira/browse/KAFKA-2104 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-815) Improve SimpleConsumerShell to take in a max messages config option

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-815: --- Resolution: Fixed Status: Resolved (was: Patch Available) was committed > Improve SimpleConsu

[jira] [Updated] (KAFKA-854) Upgrade dependencies for 0.8

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-854: --- Resolution: Fixed Status: Resolved (was: Patch Available) already fixed > Upgrade dependencie

[jira] [Updated] (KAFKA-1545) java.net.InetAddress.getLocalHost in KafkaHealthcheck.register may fail on some irregular hostnames

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1545: Status: Open (was: Patch Available) I don't see a patch... [~guozhang] - you are both assignee and

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-04-07 Thread Aravind (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484527#comment-14484527 ] Aravind commented on KAFKA-2078: Jun, Not able to reproduce running on localhost. I am ru

[jira] [Updated] (KAFKA-1633) Data loss if broker is killed

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1633: Resolution: Won't Fix Status: Resolved (was: Patch Available) Looks like this issue doesn't

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in unit tests

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484516#comment-14484516 ] Gwen Shapira commented on KAFKA-1420: - This probably needs rebase. [~natty] would you

[jira] [Created] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-07 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-2103: --- Summary: kafka.producer.AsyncProducerTest failure. Key: KAFKA-2103 URL: https://issues.apache.org/jira/browse/KAFKA-2103 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-346) Don't call commitOffsets() during rebalance

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-346: --- Resolution: Fixed Status: Resolved (was: Patch Available) This is already fixed on trunk. >

[jira] [Updated] (KAFKA-318) update zookeeper dependency to 3.3.5

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-318: --- Resolution: Fixed Status: Resolved (was: Patch Available) We are on 3.4.6 now... > update zoo

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-04-07 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484498#comment-14484498 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-04-07 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Attachment: KAFKA-1660_2015-04-07_18:18:40.patch > Ability to call close() with a timeout on the Jav

Re: Review Request 31850: Patch for KAFKA-1660

2015-04-07 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/ --- (Updated April 8, 2015, 1:18 a.m.) Review request for kafka. Bugs: KAFKA-1660

[jira] [Commented] (KAFKA-1293) Mirror maker housecleaning

2015-04-07 Thread Matt Warhaftig (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484491#comment-14484491 ] Matt Warhaftig commented on KAFKA-1293: --- Thanks everyone! Moving forward on KIP-14.

[jira] [Updated] (KAFKA-345) Add a listener to ZookeeperConsumerConnector to get notified on rebalance events

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-345: --- Resolution: Fixed Assignee: Jiangjie Qin Status: Resolved (was: Patch Available) Looking

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484427#comment-14484427 ] Gwen Shapira commented on KAFKA-1554: - Perhaps its better to rename and keep the index

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

2015-04-07 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484394#comment-14484394 ] Onur Karaman commented on KAFKA-1809: - In testDuplicateListeners() from KafkaConfigTes

Review Request 32942: Patch for KAFKA-1688

2015-04-07 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32942/ --- Review request for kafka. Bugs: KAFKA-1688 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1342) Slow controlled shutdowns can result in stale shutdown requests

2015-04-07 Thread Todd Palino (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484278#comment-14484278 ] Todd Palino commented on KAFKA-1342: Bump I think we need to revive this. We have a "

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Yasuhiro Matsuda
> On April 7, 2015, 10:17 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, lines 178-188 > > > > > > What is the usage of watchCreated here? It seems only gets intialized > > as

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review77523 --- Sorry for the late review. A few more comments below. clients/src/

[jira] [Commented] (KAFKA-1461) Replica fetcher thread does not implement any back-off behavior

2015-04-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484221#comment-14484221 ] Guozhang Wang commented on KAFKA-1461: -- Thanks for the patch, committed to trunk. >

[jira] [Updated] (KAFKA-1461) Replica fetcher thread does not implement any back-off behavior

2015-04-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1461: - Resolution: Fixed Status: Resolved (was: Patch Available) > Replica fetcher thread does n

Re: Review Request 32931: Revert the changes in NoOffset error code

2015-04-07 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32931/#review79262 --- Ship it! clients/src/main/java/org/apache/kafka/clients/consumer/i

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review79263 --- - Guozhang Wang On April 7, 2015, 9:59 p.m., Yasuhiro Matsuda wrot

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review79257 --- core/src/main/scala/kafka/server/DelayedOperation.scala

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Guozhang Wang
> On April 6, 2015, 10:35 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, lines 104-105 > > > > > > We probably should call forceComplete() first and only if it returns > > true, run

[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

2015-04-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484196#comment-14484196 ] Gwen Shapira commented on KAFKA-1992: - oh wow, thanks :) Totally forgot about this one

[jira] [Updated] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1992: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Commented] (KAFKA-1989) New purgatory design

2015-04-07 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484170#comment-14484170 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-1989) New purgatory design

2015-04-07 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-07_14:59:33.patch > New purgatory design > --

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Yasuhiro Matsuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/ --- (Updated April 7, 2015, 9:59 p.m.) Review request for kafka. Bugs: KAFKA-1989

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Yasuhiro Matsuda
> On April 6, 2015, 10:35 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, lines 104-105 > > > > > > We probably should call forceComplete() first and only if it returns > > true, run

[jira] [Updated] (KAFKA-1993) Enable topic deletion as default

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1993: --- Status: Open (was: Patch Available) > Enable topic deletion as default > > >

[jira] [Commented] (KAFKA-1993) Enable topic deletion as default

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484126#comment-14484126 ] Jun Rao commented on KAFKA-1993: Perhaps we should wait until the security feature is done

[jira] [Updated] (KAFKA-2033) Small typo in documentation

2015-04-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2033: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Assignee: Tim Brooks Status: Patch Available (was: Open) > Remove unnecessary synchronization whe

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Brooks updated KAFKA-2102: -- Attachment: KAFKA-2102.patch > Remove unnecessary synchronization when managing metadata > -

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484054#comment-14484054 ] Tim Brooks commented on KAFKA-2102: --- Created reviewboard https://reviews.apache.org/r/32

Review Request 32937: Patch for KAFKA-2102

2015-04-07 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/ --- Review request for kafka. Bugs: KAFKA-2102 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-07 Thread Tim Brooks (JIRA)
Tim Brooks created KAFKA-2102: - Summary: Remove unnecessary synchronization when managing metadata Key: KAFKA-2102 URL: https://issues.apache.org/jira/browse/KAFKA-2102 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-2101) Metric metadata-age is reset on a failed update

2015-04-07 Thread Tim Brooks (JIRA)
Tim Brooks created KAFKA-2101: - Summary: Metric metadata-age is reset on a failed update Key: KAFKA-2101 URL: https://issues.apache.org/jira/browse/KAFKA-2101 Project: Kafka Issue Type: Bug

Re: Is there a complete Kafka 0.8.* replication design document

2015-04-07 Thread Jun Rao
Yes, the wiki is a bit old. You can find out more about replication in the following links. http://kafka.apache.org/documentation.html#replication http://www.slideshare.net/junrao/kafka-replication-apachecon2013 #1, #2, #8. See the ZK layout in https://cwiki.apache.org/confluence/display/KAFKA/Kaf

Re: Review Request 31850: Patch for KAFKA-1660

2015-04-07 Thread Jiangjie Qin
> On April 7, 2015, 1:28 a.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 362 > > > > > > As you explained offline, the sender does not hav

[jira] [Created] (KAFKA-2100) Client Error doesn't preserve or display original server error code when it is an unknown code

2015-04-07 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-2100: --- Summary: Client Error doesn't preserve or display original server error code when it is an unknown code Key: KAFKA-2100 URL: https://issues.apache.org/jira/browse/KAFKA-2100

[jira] [Commented] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

2015-04-07 Thread Allen Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483849#comment-14483849 ] Allen Wang commented on KAFKA-2096: --- [~junrao], yes I would like submit a patch. One th

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-07 Thread Andrii Biletskyi
Hi all, A summary of our discussion: 201. Q: Cluster updates in backward compatible way. A: Add topicConfigs map property and change constructor, this shouldn't break Consumer/Producer since TMR is used in NetworkClient, not directly by Consumer/Producer. 300. Q: Can we merge AlterTopic

Re: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-07 Thread Don Bosco Durai
Gwen I feel, we should assume the metrics server is an external system and the access to the server should be managed by the security features provided by the system. This way, it would be the Kafka System Administrator responsibility to ensure the metrics system is properly firewall¹ed or access

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483724#comment-14483724 ] Guozhang Wang commented on KAFKA-1910: -- Created reviewboard https://reviews.apache.or

Re: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-07 Thread Gwen Shapira
Yeah, I was not suggesting adding auth to metrics - I think this needlessly complicates everything. But we need to assume that client developers will not have access to the broker metrics (because in secure environment they probably won't). Gwen On Tue, Apr 7, 2015 at 11:20 AM, Sriharsha Chintala

[jira] [Updated] (KAFKA-1910) Refactor KafkaConsumer

2015-04-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1910: - Attachment: KAFKA-1910.patch > Refactor KafkaConsumer > -- > >

[jira] [Updated] (KAFKA-1910) Refactor KafkaConsumer

2015-04-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1910: - Status: Patch Available (was: Reopened) > Refactor KafkaConsumer > -- > >

Re: Review Request 31366: Patch for KAFKA-1461

2015-04-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review79205 --- Ship it! LGTM, Jun do you want to take another look? - Guozhang Wa

Review Request 32931: Revert the changes in NoOffset error code

2015-04-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32931/ --- Review request for kafka. Bugs: KAFKA-1910 https://issues.apache.org/jira/b

  1   2   >