----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32931/#review79262 -----------------------------------------------------------
Ship it! clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java <https://reviews.apache.org/r/32931/#comment128500> Should this log be: "Unkwown topic or partition " + tp? clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java <https://reviews.apache.org/r/32931/#comment128501> indicate -> indicates - Joel Koshy On April 7, 2015, 6:31 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32931/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 6:31 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1910 > https://issues.apache.org/jira/browse/KAFKA-1910 > > > Repository: kafka > > > Description > ------- > > According to the discussion with Joel > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java > 8d44814e0d62cdfe045af843f0e55e84497a07a0 > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > ce18a6ce7ed31420cdbec6926a9cd04fa4c806b1 > clients/src/main/java/org/apache/kafka/common/record/Record.java > d2332c9e1a09db155d5ff20f7868fe5974df5832 > > clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java > 1de22b9829fbaa9533a58fc0622199b07fa89398 > core/src/main/scala/kafka/common/ErrorMapping.scala > eb1eb4a703098253d0aae79577084569177768d1 > > Diff: https://reviews.apache.org/r/32931/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
