[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

2015-03-13 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361619#comment-14361619 ] Dmitry Bugaychenko commented on KAFKA-1305: --- Retry itself is in the cahnnel mana

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2015-03-13 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361583#comment-14361583 ] Gwen Shapira commented on KAFKA-1684: - [~harsha_ch] I'm working on KAFKA-1928. I didn'

[jira] [Comment Edited] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2015-03-13 Thread Po Zhou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361561#comment-14361561 ] Po Zhou edited comment on KAFKA-1460 at 3/14/15 3:22 AM: - My colle

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2015-03-13 Thread Po Zhou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361561#comment-14361561 ] Po Zhou commented on KAFKA-1460: My colleague found errors in controller.log further (atta

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2015-03-13 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361539#comment-14361539 ] Sriharsha Chintalapani commented on KAFKA-1684: --- [~junrao] Definitely we can

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2015-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361470#comment-14361470 ] Jun Rao commented on KAFKA-1684: [~sriharsha], just a high level comment. We have another

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361449#comment-14361449 ] Joel Koshy commented on KAFKA-1554: --- That would be a work-around, but ideally we should

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361424#comment-14361424 ] Joel Koshy commented on KAFKA-2019: --- When the round-robin assignor was done, I think we

Re: [DISCUSS] KIP 16 - Replica lag tuning

2015-03-13 Thread Joel Koshy
Thanks for the write-up. Looks good to me. Minor comments: Under proposed changes: """The proposal is to calculate replica lag as the amount of time not caught up to the leader. A replica is only in ISR if it is caught up.""" It may be worth clarifying this on the KIP a bit more - i.e., we curre

Re: [VOTE] KIP-16: Replica Lag Tuning

2015-03-13 Thread Joel Koshy
+1 on the KIP On Fri, Mar 13, 2015 at 04:54:04PM +, Aditya Auradkar wrote: > Details in the KIP, Jira and RB. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning > https://issues.apache.org/jira/browse/KAFKA-1546 > https://reviews.apache.org/r/31967/ >

Re: Review Request 32063: Patch for KAFKA-2019

2015-03-13 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32063/#review76469 --- Hey Joseph, Nice fix. Could you add some unit tests to this patch?

Re: Review Request 32063: Patch for KAFKA-2019

2015-03-13 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32063/#review76468 --- core/src/main/scala/kafka/utils/ZkUtils.scala

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361381#comment-14361381 ] Jiangjie Qin commented on KAFKA-2019: - Yep! > RoundRobinAssignor clusters by consumer

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joseph Holsten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361370#comment-14361370 ] Joseph Holsten commented on KAFKA-2019: --- [~becket_qin] ooh, shiny. Did I do it right

[jira] [Updated] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joseph Holsten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Holsten updated KAFKA-2019: -- Attachment: KAFKA-2019.patch > RoundRobinAssignor clusters by consumer > ---

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joseph Holsten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361368#comment-14361368 ] Joseph Holsten commented on KAFKA-2019: --- Created reviewboard https://reviews.apache.

Review Request 32063: Patch for KAFKA-2019

2015-03-13 Thread Joseph Holsten
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32063/ --- Review request for kafka. Bugs: KAFKA-2019 https://issues.apache.org/jira/b

Re: Review Request 31742: Patch for KAFKA-527

2015-03-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31742/#review76454 --- LGTM, with a few minor comments and a coding suggestion in the end.

[jira] [Assigned] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1554: -- Assignee: Mayuresh Gharat > Corrupt index found on clean startup >

Build failed in Jenkins: KafkaPreCommit #38

2015-03-13 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-1997; Refactor MirrorMaker based on KIP-3; reviewed by Joel Koshy and Guozhang Wang [wangguoz] KAFKA-1863; Add docs for possible thrown exception in Callback; reviewed by Jiangjie Qin -

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361309#comment-14361309 ] Mayuresh Gharat commented on KAFKA-1554: I can take a shot at this one. > Corrupt

[jira] [Comment Edited] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361306#comment-14361306 ] Mayuresh Gharat edited comment on KAFKA-1554 at 3/13/15 11:26 PM: --

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361306#comment-14361306 ] Mayuresh Gharat commented on KAFKA-1554: So in this case we should be deleting the

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361243#comment-14361243 ] Guozhang Wang commented on KAFKA-1997: -- Thanks for the patch, committed to trunk. >

[jira] [Updated] (KAFKA-1997) Refactor Mirror Maker

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1997: - Resolution: Fixed Status: Resolved (was: Patch Available) > Refactor Mirror Maker > -

[jira] [Commented] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361207#comment-14361207 ] Guozhang Wang commented on KAFKA-2015: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2015: - Status: Patch Available (was: Open) > Enable ConsoleConsumer to use new consumer > --

Review Request 32061: WIP for KAFKA-2015 plus some minor fixes in new consumer

2015-03-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32061/ --- Review request for kafka. Bugs: KAFKA-2015 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2015: - Attachment: KAFKA-2015.patch > Enable ConsoleConsumer to use new consumer > --

[jira] [Updated] (KAFKA-1863) Exception categories / hierarchy in clients

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1863: - Resolution: Fixed Status: Resolved (was: Patch Available) > Exception categories / hierar

[jira] [Comment Edited] (KAFKA-1863) Exception categories / hierarchy in clients

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361191#comment-14361191 ] Guozhang Wang edited comment on KAFKA-1863 at 3/13/15 10:18 PM:

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-03-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361191#comment-14361191 ] Guozhang Wang commented on KAFKA-1863: -- Added the docs according, closing this ticket

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361185#comment-14361185 ] Jiangjie Qin commented on KAFKA-1305: - It is not clear to me how adding timeout when p

Re: Review Request 31735: Fix KAFKA-1863

2015-03-13 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31735/#review76425 --- Ship it! LGTM, just two minor comments. clients/src/main/java/org

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361156#comment-14361156 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1997) Refactor Mirror Maker

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1997: Attachment: KAFKA-1997_2015-03-13_14:43:34.patch > Refactor Mirror Maker > - > >

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

2015-03-13 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361155#comment-14361155 ] Dmitry Bugaychenko commented on KAFKA-1305: --- Yes, data loss is tolerated to some

Re: Review Request 31706: Patch for KAFKA-1997

2015-03-13 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/ --- (Updated March 13, 2015, 9:43 p.m.) Review request for kafka. Bugs: KAFKA-199

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361021#comment-14361021 ] Jiangjie Qin commented on KAFKA-2019: - Can you use kafka-patch-review.py to submit pat

[jira] [Commented] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

2015-03-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360932#comment-14360932 ] Ewen Cheslack-Postava commented on KAFKA-2020: -- A bit more detail -- ReplicaN

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joseph Holsten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360892#comment-14360892 ] Joseph Holsten commented on KAFKA-2019: --- Exactly! Essentially, if you've got 2 cons

[jira] [Commented] (KAFKA-2011) Rebalance with auto.leader.rebalance.enable=false

2015-03-13 Thread K Zakee (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360863#comment-14360863 ] K Zakee commented on KAFKA-2011: All right. Thanks for your help. > Rebalance with auto.l

[jira] [Resolved] (KAFKA-2006) switch the broker server over to the new java protocol definitions

2015-03-13 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi resolved KAFKA-2006. - Resolution: Duplicate > switch the broker server over to the new java protocol definitions

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-03-13 Thread Jun Rao
Andrii, 101. That's what I was thinking too, but it may not be that simple. In TopicMetadataRequest_V1, we can let it not trigger auto topic creation. Then, in the producer side, if it gets an UnknownTopicException, it can explicitly issue a createTopicRequest for auto topic creation. On the consu

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360659#comment-14360659 ] Jiangjie Qin commented on KAFKA-2019: - In this case is it that each consumer has large

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360637#comment-14360637 ] Jun Rao commented on KAFKA-1927: The following is a rough outline to do this. 1. kafka.ne

KIP hangout next Tuesday?

2015-03-13 Thread Joe Stein
I wanted to propose another KIP hangout next Tuesday @ 2pm ET / 11am PT I want to try to focus some of the conversations if we can for things needing to get discussed so lets try to formulate an agenda so items folks want/need to have discussed can get in and folks have time to review prior. Righ

[VOTE] KIP-16: Replica Lag Tuning

2015-03-13 Thread Aditya Auradkar
Details in the KIP, Jira and RB. https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning https://issues.apache.org/jira/browse/KAFKA-1546 https://reviews.apache.org/r/31967/ Aditya

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360638#comment-14360638 ] Jiangjie Qin commented on KAFKA-1305: - That's a good point. But I kind of think the ri

[jira] [Commented] (KAFKA-2011) Rebalance with auto.leader.rebalance.enable=false

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360629#comment-14360629 ] Jiangjie Qin commented on KAFKA-2011: - I think those logs are actually from two differ

[jira] [Commented] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

2015-03-13 Thread Chris Riccomini (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360624#comment-14360624 ] Chris Riccomini commented on KAFKA-2020: Also related, we're using ErrorMapping.ma

[jira] [Created] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

2015-03-13 Thread Chris Riccomini (JIRA)
Chris Riccomini created KAFKA-2020: -- Summary: I expect ReplicaNotAvailableException to have proper Javadocs Key: KAFKA-2020 URL: https://issues.apache.org/jira/browse/KAFKA-2020 Project: Kafka

[jira] [Updated] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joseph Holsten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Holsten updated KAFKA-2019: -- Status: Patch Available (was: Open) Doesn't have any tests, and this is my first attempt at sca

[jira] [Updated] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joseph Holsten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Holsten updated KAFKA-2019: -- Attachment: 0001-sort-consumer-thread-ids-by-hashcode.patch > RoundRobinAssignor clusters by con

[jira] [Created] (KAFKA-2019) RoundRobinAssignor clusters by consumer

2015-03-13 Thread Joseph Holsten (JIRA)
Joseph Holsten created KAFKA-2019: - Summary: RoundRobinAssignor clusters by consumer Key: KAFKA-2019 URL: https://issues.apache.org/jira/browse/KAFKA-2019 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

2015-03-13 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360253#comment-14360253 ] Dmitry Bugaychenko commented on KAFKA-1305: --- With a large controller queues size

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-03-13 Thread Andrii Biletskyi
Jun, Thanks for you comments. Answers inline: 100. There are a few fields such as ReplicaAssignment, > ReassignPartitionRequest, > and PartitionsSerialized that are represented as a string, but contain > composite structures in json. Could we flatten them out directly in the > protocol definition

[jira] [Commented] (KAFKA-2006) switch the broker server over to the new java protocol definitions

2015-03-13 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360206#comment-14360206 ] Andrii Biletskyi commented on KAFKA-2006: - It appears that FooRequestAndHeader is