----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31735/#review76425 -----------------------------------------------------------
Ship it! LGTM, just two minor comments. clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java <https://reviews.apache.org/r/31735/#comment123970> It seems a little bit misleading to just mention SchemaException here. Can we log the possible exceptions here because there should be only small number of exceptions. clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java <https://reviews.apache.org/r/31735/#comment123971> Constrcut the schema with a given list of its field values. - Jiangjie Qin On March 4, 2015, 6:39 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31735/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 6:39 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1863 > https://issues.apache.org/jira/browse/KAFKA-1863 > > > Repository: kafka > > > Description > ------- > > Add docs for ApiExceptions in callbacks and send / construtors > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/Callback.java > b89aa582f64e8aa38e75cef1d153760400df335e > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > ed9c63a6679e3aaf83d19fde19268553a4c107c2 > clients/src/main/java/org/apache/kafka/common/protocol/types/Field.java > 899195819159a3544e14ebfb09aff1b9152ff5dd > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java > 716470125866641210591df1d5c773183949819a > > clients/src/main/java/org/apache/kafka/common/protocol/types/SchemaException.java > ea4e46f4d768ef90a0d725ad117aab4645f6cb76 > clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java > ff89f0e37d5fa787b0218eff86d169aaeae2107b > clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java > f0d5a8286380d0138b7a815ea7492311603cc72f > > Diff: https://reviews.apache.org/r/31735/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
