----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32063/#review76469 -----------------------------------------------------------
Hey Joseph, Nice fix. Could you add some unit tests to this patch? - Aditya Auradkar On March 14, 2015, 12:13 a.m., Joseph Holsten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32063/ > ----------------------------------------------------------- > > (Updated March 14, 2015, 12:13 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2019 > https://issues.apache.org/jira/browse/KAFKA-2019 > > > Repository: kafka > > > Description > ------- > > sort consumer thread ids by hashcode > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/TopicCount.scala > 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37 > core/src/main/scala/kafka/utils/ZkUtils.scala > 7ae999ec619443d35a9cb8fbcd531fca0c51c8c0 > > Diff: https://reviews.apache.org/r/32063/diff/ > > > Testing > ------- > > > Thanks, > > Joseph Holsten > >
