[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294838#comment-14294838 ] Joe Stein commented on KAFKA-1901: -- Can we collect that info during a meta data fetch for

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294803#comment-14294803 ] Joel Koshy commented on KAFKA-1901: --- Funny I was thinking about this earlier today - I t

Re: [DISCUSSION] generate explicit error/failing metrics

Joel, thanks for the clarifications. maybe I misunderstand the intent of that metric. Yes, we are looking for alerting if some partitions aren't owned by any consumer from the group (just in case this ever happens). yes, MaxLag mbeans only apply for partitions owned by a consumer. looking forwar

[jira] [Commented] (KAFKA-1235) Enable server to indefinitely retry on controlled shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294761#comment-14294761 ] Guozhang Wang commented on KAFKA-1235: -- The patch is actually already committed on Fe

[jira] [Resolved] (KAFKA-1235) Enable server to indefinitely retry on controlled shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1235. -- Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.2 > Enable serve

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294733#comment-14294733 ] Otis Gospodnetic commented on KAFKA-1902: - bq. It's unfortunate it seems graphite

Re: [DISCUSSION] generate explicit error/failing metrics

I'm not sure if I'm misunderstanding the suggestion, but this metric was ever intended for alerts. Some metrics are more for informational purposes than for setting up alerts. In fact it is possible for some consumers to have zero owned partitions if there are fewer partitions than consumers in the

Re: Registry used for yammer metrics in Kafka

I think having dedicated registries would have been a better choice - it sort of just ended up like this. We made note of this in KAFKA-1567 as well if you read through those comments but concluded that it will be a larger refactoring at this point - which may not be worth it since we intend to mov

[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294647#comment-14294647 ] Joel Koshy commented on KAFKA-1729: --- (Uploaded above patch since we will most likely nee

[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294645#comment-14294645 ] Joel Koshy commented on KAFKA-1729: --- Created reviewboard https://reviews.apache.org/r/30

[jira] [Updated] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1729: -- Attachment: KAFKA-1729.patch > add doc for Kafka-based offset management in 0.8.2 >

Review Request 30355: 0.8.2 javaapi offset management API improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30355/ --- Review request for kafka. Bugs: KAFKA-1729 https://issues.apache.org/jira/b

Re: Review Request 30321: Patch for kafka-1902

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69940 --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review69936 --- "patch -p1 < patch-file" does not do the renaming of RequestComplet

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294545#comment-14294545 ] Kyle Banker commented on KAFKA-1902: [~junrao] Agree that the dot may not be common, w

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294499#comment-14294499 ] Joel Koshy commented on KAFKA-1902: --- Jun - to answer your earlier question. I took a loo

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294474#comment-14294474 ] Jun Rao commented on KAFKA-1902: Making the replacing character configurable is actually n

Registry used for yammer metrics in Kafka

IIUC, Kafka uses the default registry in yammer metrics to create all kafka related metrics. We observed a scenario where we found that our default registry was getting populated by the metrics created by kafka which in turn was causing other issues down the line. Just wanted to ask if there was a

[DISCUSSION] generate explicit error/failing metrics

To illustrate my point, I will use "allTopicsOwnedPartitionsCount" guage from ZookeeperConsumerConnector as an example. It captures number of partitions for a topic that has been assigned owner for the consumer group. let's say that I have a topic with 9 partitions. this metrics should normally re

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294332#comment-14294332 ] Jason Rosenberg commented on KAFKA-1902: +1 > fix MetricName so that Yammer repor

[jira] [Comment Edited] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294309#comment-14294309 ] Kyle Banker edited comment on KAFKA-1902 at 1/27/15 10:25 PM: --

[jira] [Comment Edited] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294309#comment-14294309 ] Kyle Banker edited comment on KAFKA-1902 at 1/27/15 10:23 PM: --

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294309#comment-14294309 ] Kyle Banker commented on KAFKA-1902: Couple ideas here: 1. [~junrao] For what its wor

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294299#comment-14294299 ] Jun Rao commented on KAFKA-1902: clientId is useful because one may want to run multiple p

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294289#comment-14294289 ] Jun Rao commented on KAFKA-1902: In Kafka, topic/group/clientId can include only -, _ and

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294287#comment-14294287 ] Jason Rosenberg commented on KAFKA-1902: Actually, a red flag here too, is why are

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294286#comment-14294286 ] Jun Rao commented on KAFKA-1902: Is graphite the only reporter using scope? t seems that t

[jira] [Assigned] (KAFKA-1888) Add a "rolling upgrade" system test

[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam reassigned KAFKA-1888: - Assignee: Abhishek Nigam > Add a "rolling upgrade" system test >

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294261#comment-14294261 ] Jason Rosenberg commented on KAFKA-1902: [~jjkoshy] I did mean to just replace all

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294239#comment-14294239 ] Joel Koshy commented on KAFKA-1902: --- I meant mytopic$with$dot.myclientId$with$dot > fix

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294238#comment-14294238 ] Joel Koshy commented on KAFKA-1902: --- It's unfortunate it seems graphite does not allow o

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294195#comment-14294195 ] Jun Rao commented on KAFKA-1902: Topic and clientId allow underscores too. How about repla

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294053#comment-14294053 ] Jason Rosenberg commented on KAFKA-1902: Since many people use the vanilla Graphit

Re: [VOTE] 0.8.2.0 Candidate 2 (with the correct links)

Hi, Everyone, We identified a blocker issue related to Yammer jmx reporter ( https://issues.apache.org/jira/browse/KAFKA-1902). We are addressing this issue right now. Once it's resolved, we will roll out a new RC for voting. Thanks, Jun On Mon, Jan 26, 2015 at 5:14 PM, Otis Gospodnetic < otis.

[jira] [Comment Edited] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293840#comment-14293840 ] Jason Rosenberg edited comment on KAFKA-1902 at 1/27/15 7:34 PM: ---

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293919#comment-14293919 ] Jun Rao commented on KAFKA-1902: Thanks for the explanation. A couple of things: (1) Since

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293913#comment-14293913 ] Jason Rosenberg commented on KAFKA-1901: At the very least, this could be updated

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293854#comment-14293854 ] Kyle Banker commented on KAFKA-1902: This definitely fixes the issue. I'm now seeing a

[jira] [Comment Edited] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293840#comment-14293840 ] Jason Rosenberg edited comment on KAFKA-1902 at 1/27/15 5:30 PM: ---

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293840#comment-14293840 ] Jason Rosenberg commented on KAFKA-1902: In the yammer metric reporter (which is b

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293825#comment-14293825 ] Dmitry Pekar edited comment on KAFKA-1792 at 1/27/15 5:12 PM: --

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: KAFKA-1792_2015-01-27_19:09:27.patch > change behavior of --generate to produce assignme

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293825#comment-14293825 ] Dmitry Pekar commented on KAFKA-1792: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 28481: Patch for KAFKA-1792

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28481/ --- (Updated Jan. 27, 2015, 5:09 p.m.) Review request for kafka. Bugs: KAFKA-1792

Re: Review Request 30321: Patch for kafka-1902

> On Jan. 27, 2015, 4:44 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 69 > > > > > > Seems when yammer creates the mBeanName, it will use append ",scope=" > > before sc

Re: Review Request 30321: Patch for kafka-1902

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69814 --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293794#comment-14293794 ] Jun Rao commented on KAFKA-1902: The fix is to use tag name as the scope. So, we will have

Re: Review Request 30321: Patch for kafka-1902

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69813 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 27, 2015, 4:16 p.m

[jira] [Updated] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1902: --- Status: Patch Available (was: Open) > fix MetricName so that Yammer reporter can work correctly > ---

[jira] [Updated] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1902: --- Attachment: kafka-1902.patch > fix MetricName so that Yammer reporter can work correctly > ---

[jira] [Commented] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

[ https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293747#comment-14293747 ] Jun Rao commented on KAFKA-1902: Created reviewboard https://reviews.apache.org/r/30321/di

Review Request 30321: Patch for kafka-1902

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/ --- Review request for kafka. Bugs: kafka-1902 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1902) fix MetricName so that Yammer reporter can work correctly

Jun Rao created KAFKA-1902: -- Summary: fix MetricName so that Yammer reporter can work correctly Key: KAFKA-1902 URL: https://issues.apache.org/jira/browse/KAFKA-1902 Project: Kafka Issue Type: Bug

Re: Review Request 28769: Patch for KAFKA-1809

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/#review69804 --- Some of my comments are outside of the scope of this review, so it's

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review69737 --- minor nitpicks clients/src/main/java/org/apache/kafka/clients/cons