[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293854#comment-14293854
]
Kyle Banker commented on KAFKA-1902:
------------------------------------
This definitely fixes the issue. I'm now seeing all of the missing metrics, and
if you go with this approach, we Graphite users should be fine.
There are a couple of aesthetic issues we might consider, though, given that
the Graphite convention is to use dot-separated names to form a hierarchy.
1. Do we want topics under BrokerTopicMetrics to be indicated as "topic=foo" or
would it be better to set the scope as "Topics.foo" to form a more natural
Graphite hierarchy?
2. FetcherLagMetrics now show up as
clientId=ReplicaFetcherThread-0-2,topic=foo,partition=0.
Alternative: ReplicaFetcherThread-0-2.Topics.foo.partition-0
3. Log metrics look like this: topic=foo,partition=1. A Graphite alternative
would be: Topics.foo.partition1, Topics.foo.partition2, etc.
Overall, these metrics naming conventions skew toward the JMX standard. We can
pretty easily work around that in the Graphite world, and keeping the format
the same will probably make it easier to compare metrics across systems.
Either way, it will be a big change for those using Graphite.
> fix MetricName so that Yammer reporter can work correctly
> ---------------------------------------------------------
>
> Key: KAFKA-1902
> URL: https://issues.apache.org/jira/browse/KAFKA-1902
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Jun Rao
> Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: kafka-1902.patch
>
>
> Currently, we create MetricName in the following format.
> group: "kafka.server"
> type: "BrokerTopicMetrics"
> name: "BytesInPerSec"
> scope: null
> mBeanName:
> "kafka.server:type=BrokerTopicMetrics,name=BytesInPerSec,topic=test"
> However, Yammer metric reporter seems to only use the first four fields
> group, type, name and scope during reporting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
