[ 
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294803#comment-14294803
 ] 

Joel Koshy commented on KAFKA-1901:
-----------------------------------

Funny I was thinking about this earlier today - I think we should actually 
extract the git hash as well and generate some code that produces the app-info. 
http://forums.gradle.org/gradle/topics/how_can_i_store_the_git_revision_for_use_in_the_project
So app-info would include git hash, branch, major/minor version, etc. 
Furthermore, we can emit a metric that reports the md5 of this entire app-info 
string modulo some large number (say 100000). That may be convenient to (at a 
glance at graphs) say the brokers are all running the same version. I'm more 
interested in the app-info string though for the git hash. When people report 
issues it is always helpful to get the precise git hash they are at if they are 
(say) on trunk.

> Move Kafka version to be generated in code by build (instead of in manifest)
> ----------------------------------------------------------------------------
>
>                 Key: KAFKA-1901
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1901
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2
>            Reporter: Jason Rosenberg
>
> With 0.8.2 (rc2), I've started seeing this warning in the logs of apps 
> deployed to our staging (both server and client):
> {code}
> 2015-01-23 00:55:25,273  WARN [async-message-sender-0] common.AppInfo$ - 
> Can't read Kafka version from MANIFEST.MF. Possible cause: 
> java.lang.NullPointerException
> {code}
> The issues is that in our deployment, apps are deployed with single 'shaded' 
> jars (e.g. using the maven shade plugin).  This means the MANIFEST.MF file 
> won't have a kafka version.  Instead, suggest the kafka build generate the 
> proper version in code, as part of the build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to