[GitHub] kafka pull request: [Kafka-1828]add judgement for ConsumerPerforma...

Github user maji2014 closed the pull request at: https://github.com/apache/kafka/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] kafka pull request: add judgement for ConsumerPerformance against ...

GitHub user maji2014 opened a pull request: https://github.com/apache/kafka/pull/38 add judgement for ConsumerPerformance against negative number The result is negative number when runnning a short time for consumer performance testing, but user doesn't the reason, so add judgement

[GitHub] kafka pull request: [Kafka-1828]add judgement for ConsumerPerforma...

GitHub user maji2014 opened a pull request: https://github.com/apache/kafka/pull/37 [Kafka-1828]add judgement for ConsumerPerformance against negative number The result is negative number when runnning a short time for consumer performance testing, but user doesn't the reason, so ad

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257901#comment-14257901 ] Parth Brahmbhatt commented on KAFKA-1788: - [~Bmis13] The patch I provided solves t

[jira] [Created] (KAFKA-1828) [ConsumerPerformance] the test result is negative number

maji2014 created KAFKA-1828: --- Summary: [ConsumerPerformance] the test result is negative number Key: KAFKA-1828 URL: https://issues.apache.org/jira/browse/KAFKA-1828 Project: Kafka Issue Type: Bug

Re: Review Request 25944: Patch for KAFKA-1013

> On Dec. 24, 2014, 1:59 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 141 > > > > > > This really should not be part of the offset client's public API. > > fetchTopicMetadata is

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257869#comment-14257869 ] Jeff Holoman commented on KAFKA-1512: - I modified the two tests related to max connect

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512_2014-12-23_21:24:28.patch) > Limit the maximum number of connection

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257864#comment-14257864 ] Jeff Holoman commented on KAFKA-1512: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512_2014-12-23_21:47:23.patch > Limit the maximum number of connections per ip ad

Re: Review Request 29029: Patch for KAFKA-1512

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/ --- (Updated Dec. 24, 2014, 2:47 a.m.) Review request for kafka. Bugs: KAFKA-1512

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512_2014-12-14_21:30:27.patch) > Limit the maximum number of connection

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512.patch) > Limit the maximum number of connections per ip address > -

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: (was: KAFKA-1512_2014-12-14_21:16:55.patch) > Limit the maximum number of connection

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1512: Attachment: KAFKA-1512_2014-12-23_21:24:28.patch > Limit the maximum number of connections per ip ad

[jira] [Commented] (KAFKA-1512) Limit the maximum number of connections per ip address

[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257846#comment-14257846 ] Jeff Holoman commented on KAFKA-1512: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 29029: Patch for KAFKA-1512

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29029/ --- (Updated Dec. 24, 2014, 2:24 a.m.) Review request for kafka. Bugs: KAFKA-1512

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review65997 --- core/src/main/scala/kafka/client/ClientUtils.scala

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257805#comment-14257805 ] Bhavesh Mistry commented on KAFKA-1642: --- [~ewencp], Thanks for patch. You may clos

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257788#comment-14257788 ] Ewen Cheslack-Postava commented on KAFKA-1642: -- 1) Since this method just ret

[jira] [Resolved] (KAFKA-1806) broker fetch request uses old leader offset which is higher than current leader offset causes error

[ https://issues.apache.org/jira/browse/KAFKA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lokesh Birla resolved KAFKA-1806. - Resolution: Fixed Fix Version/s: 0.8.2 > broker fetch request uses old leader offset which

[jira] [Commented] (KAFKA-1806) broker fetch request uses old leader offset which is higher than current leader offset causes error

[ https://issues.apache.org/jira/browse/KAFKA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257757#comment-14257757 ] lokesh Birla commented on KAFKA-1806: - Neha, I used 0.8.2-beta and it works great. I

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review65993 --- Ship it! Ship It! - Joel Koshy On Dec. 24, 2014, 12:44 a.m., Jia

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-23_16:44:06.patch > Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257738#comment-14257738 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 24, 2014, 12:44 a.m.) Review request for kafka. Bugs: KAFKA-165

Re: Review Request 25944: Patch for KAFKA-1013

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 24, 2014, 12:41 a.m.) Review request for kafka and joel koshy.

[jira] [Commented] (KAFKA-1826) add command to delete all consumer group information for a topic in zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257725#comment-14257725 ] Onur Karaman commented on KAFKA-1826: - >From what I understand, TopicCommand is meant

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 23, 2014, 11:53 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 58 > > > > > > I think this might be confusing. i.e., if we have an explicit argument > > for no data loss

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 23, 2014, 11:53 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 58 > > > > > > I think this might be confusing. i.e., if we have an explicit argument > > for no data loss

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 23, 2014, 11:53 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 58 > > > > > > I think this might be confusing. i.e., if we have an explicit argument > > for no data loss

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257686#comment-14257686 ] Bhavesh Mistry edited comment on KAFKA-1642 at 12/24/14 12:02 AM: --

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257686#comment-14257686 ] Bhavesh Mistry edited comment on KAFKA-1642 at 12/24/14 12:01 AM: --

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review65981 --- Ship it! Minor observation below. Also, mirror maker has become a

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257694#comment-14257694 ] Neha Narkhede commented on KAFKA-1792: -- [~Dmitry Pekar] Thanks for sharing these test

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257691#comment-14257691 ] Bhavesh Mistry commented on KAFKA-1788: --- HI All, I did NOT try this patch, but when

[jira] [Comment Edited] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257691#comment-14257691 ] Bhavesh Mistry edited comment on KAFKA-1788 at 12/23/14 11:44 PM: --

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257686#comment-14257686 ] Bhavesh Mistry edited comment on KAFKA-1642 at 12/23/14 11:41 PM: --

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257686#comment-14257686 ] Bhavesh Mistry edited comment on KAFKA-1642 at 12/23/14 11:39 PM: --

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257686#comment-14257686 ] Bhavesh Mistry edited comment on KAFKA-1642 at 12/23/14 11:36 PM: --

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257686#comment-14257686 ] Bhavesh Mistry commented on KAFKA-1642: --- [~ewencp], Patch indeed solve the high CPU

Re: Review Request 29379: Patch for KAFKA-1788

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- (Updated Dec. 23, 2014, 8:44 p.m.) Review request for kafka. Changes ---

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257493#comment-14257493 ] Parth Brahmbhatt commented on KAFKA-1788: - Created reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-1788: Attachment: KAFKA-1788.patch > producer record can stay in RecordAccumulator forever if lead

Review Request 29379: Patch for KAFKA-1788

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379/ --- Review request for kafka. Bugs: KAFKA-1788 https://issues.apache.org/jira/b

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257377#comment-14257377 ] Dmitry Pekar edited comment on KAFKA-1792 at 12/23/14 7:14 PM: -

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257377#comment-14257377 ] Dmitry Pekar edited comment on KAFKA-1792 at 12/23/14 7:13 PM: -

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257377#comment-14257377 ] Dmitry Pekar edited comment on KAFKA-1792 at 12/23/14 7:13 PM: -

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: generate_alg_tests.txt [~nehanarkhede] Please see provided test results, for test cluste

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257377#comment-14257377 ] Dmitry Pekar edited comment on KAFKA-1792 at 12/23/14 7:11 PM: -

[jira] [Resolved] (KAFKA-1822) Add "echo" request

[ https://issues.apache.org/jira/browse/KAFKA-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-1822. - Resolution: Not a Problem > Add "echo" request > -- > > Key: KAFKA

[jira] [Commented] (KAFKA-1822) Add "echo" request

[ https://issues.apache.org/jira/browse/KAFKA-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257309#comment-14257309 ] Gwen Shapira commented on KAFKA-1822: - Thanks! I think ClusterMetadataRequest can wor

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257295#comment-14257295 ] Neha Narkhede commented on KAFKA-1792: -- Pasting my comment from KAFKA-1753 since it i

Re: Review Request 29210: Patch for KAFKA-1819

> On Dec. 19, 2014, 1:23 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 231 > > > > > > Since the bug is about entries related to deleted topics, it will be > > good to

[jira] [Commented] (KAFKA-727) broker can still expose uncommitted data to a consumer

[ https://issues.apache.org/jira/browse/KAFKA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257271#comment-14257271 ] Neha Narkhede commented on KAFKA-727: - [~lokeshbirla] Again, pasting [~junrao]'s commen

[jira] [Commented] (KAFKA-1806) broker fetch request uses old leader offset which is higher than current leader offset causes error

[ https://issues.apache.org/jira/browse/KAFKA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257269#comment-14257269 ] Neha Narkhede commented on KAFKA-1806: -- Pasting my comment above [~lokeshbirla] I w

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257268#comment-14257268 ] Jay Kreps commented on KAFKA-1755: -- Rejecting messages without a key doesn't actually sol

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-23_07:04:28.patch > Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257050#comment-14257050 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 23, 2014, 3:04 p.m.) Review request for kafka. Bugs: KAFKA-1650

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256890#comment-14256890 ] Joel Koshy commented on KAFKA-1755: --- Thanks for the comments. The issue with 3a is that

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 23, 2014, 8:34 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 90 > > > > > > Use valuesIterator instead of values - the reason is that values > > materializes, but the it

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 22, 2014, 1:34 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 85 > > > > > > NumUnackedOffsets is a "weird" metric especially with the presence of > > NumUnackedMessages.

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 23, 2014, 8:34 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 90 > > > > > > Use valuesIterator instead of values - the reason is that values > > materializes, but the it

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 22, 2014, 1:34 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 394 > > > > > > if isAutoCommit is true then we will not retry anyway. I think this

Re: Review Request 25995: Patch for KAFKA-1650

> On Dec. 18, 2014, 10:42 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 614 > > > > > > Should this be fatal? i.e., fatal is normally used before exiting > > (abnormally). WARN w

Re: Review Request 25995: Patch for KAFKA-1650

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review65874 --- Looks great. Just a few more minor comments + a question that you ma