> On Dec. 23, 2014, 8:34 a.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 90
> > <https://reviews.apache.org/r/25995/diff/19/?file=799170#file799170line90>
> >
> > Use valuesIterator instead of values - the reason is that values
> > materializes, but the iterator will not; map over the iterator will give
> > another iterator. So I'm pretty sure with that sum is computed without
> > materializing an entire collection of sizes.
>
> Jiangjie Qin wrote:
> There seems no valueIterator for Pool... Maybe
> def value = unackedOffsetsMap.iterator.map(unackedOffsets =>
> unackedOffsets._2.size).sum ?
Ah yes - forgot that this is a pool. Your edit should work, although can you
use case inside the map? i.e., `...iterator.map { case(topicPartition,
unackedOffsets) => ...`
> On Dec. 23, 2014, 8:34 a.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/utils/DoublyLinkedList.scala, line 25
> > <https://reviews.apache.org/r/25995/diff/19/?file=799171#file799171line25>
> >
> > This should ideally be nested static class of DoublyLinkedList and
> > named Node
>
> Jiangjie Qin wrote:
> But I needs to instantiate the node outside of the list. I seems not able
> to access the Node class if the class is nested.
Yes you are right - I was in Java world for a minute. You can accomplish
something similar by defining an object DoublyLinkedList and defining a Node
class inside that, but that is almost equivalent to what you have so ignore my
comment here.
- Joel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25995/#review65874
-----------------------------------------------------------
On Dec. 23, 2014, 3:07 a.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25995/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 3:07 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1650 and KAKFA-1650
> https://issues.apache.org/jira/browse/KAFKA-1650
> https://issues.apache.org/jira/browse/KAKFA-1650
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Guozhang's comments.
>
>
> Addressed Guozhang's comments
>
>
> commit before switch to trunk
>
>
> commit before rebase
>
>
> Rebased on trunk, Addressed Guozhang's comments.
>
>
> Addressed Guozhang's comments on MaxInFlightRequests
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
> mirrormaker-redesign
>
>
> Incorporated Guozhang's comments
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
> mirrormaker-redesign
>
>
> Merged KAFKA-345 into this patch. Incorporated Joel and Jun's comments.
>
>
> Added consumer rebalance listener to mirror maker, will test it later.
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
> mirrormaker-redesign
>
> Conflicts:
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
>
> core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
>
> added custom config for consumer rebalance listener
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
> mirrormaker-redesign
>
>
> Add configurable consumer rebalance listener
>
>
> Incorporated Guozhang's comments
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
> mirrormaker-redesign
>
>
> Incorporated Guozhang's comments.
>
>
> Addressed Guozhang's comment.
>
>
> numMessageUnacked should be decremented no matter the send was successful or
> not.
>
>
> Addressed Jun's comments.
>
>
> Incorporated Jun's comments
>
>
> Incorporated Jun's comments and rebased on trunk
>
>
> Rebased on current trunk
>
>
> Addressed Joel's comments.
>
>
> Addressed Joel's comments.
>
>
> Incorporated Joel's comments
>
>
> Incorporated Joel's comments
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
> mirrormaker-redesign
>
>
> Incorporated Joel's comments
>
>
> Fix a bug in metric.
>
>
> Missed some change in the prvevious patch submission, submit patch again.
>
>
> change offset commit thread to use scheduler.
>
>
> Addressed Joel's comments.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ConsumerConnector.scala
> 62c0686e816d2888772d5a911becf625eedee397
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
> e991d2187d03241f639eeaf6769fb59c8c99664c
> core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala
> 9baad34a9793e5067d11289ece2154ba87b388af
> core/src/main/scala/kafka/tools/MirrorMaker.scala
> 53cb16c2949e0ac36a0e943564fc9fc9b4c84caa
> core/src/main/scala/kafka/utils/DoublyLinkedList.scala PRE-CREATION
> core/src/test/scala/unit/kafka/utils/DoublyLinkedListTest.scala
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25995/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
