Re: Review Request 26663: Patch for KAFKA-979

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26663/#review56494 --- core/src/main/scala/kafka/log/Log.scala

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1634: - Assignee: Guozhang Wang (was: Joel Koshy) > Improve semantics of timestamp in OffsetCommitRequest

Re: Review Request 26663: Patch for KAFKA-979

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26663/#review56490 --- Looks good. Just one minor comment. Could you get rid of this build

[jira] [Updated] (KAFKA-1703) The bat script failed to start on windows

[ https://issues.apache.org/jira/browse/KAFKA-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1703: - Labels: newbie (was: ) > The bat script failed to start on windows >

Re: [DISCUSSION] Message Metadata

Hi Jay, Thanks for the comments. Replied inline. Guozhang On Mon, Oct 13, 2014 at 11:11 AM, Jay Kreps wrote: > I need to take more time to think about this. Here are a few off-the-cuff > remarks: > > - To date we have tried really, really hard to keep the data model for > message simple since

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1583: - Attachment: KAFKA-1583_2014-10-13_19:41:58.patch > Kafka API Refactoring > - >

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170405#comment-14170405 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 24676: Rebase KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 14, 2014, 2:42 a.m.) Review request for kafka. Summary (updated

Re: [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

Hi Kafka Dev Team, Let me know if new Producer is supporting sending data to single partition (without blocking). We have use-case for Aggregating Events. Thanks, Bhavesh On Mon, Oct 13, 2014 at 10:54 AM, Bhavesh Mistry wrote: > Hi Kafka Dev Team, > > When I run the test to send message to

[jira] [Commented] (KAFKA-1698) Validator.ensureValid() only validates default config value

[ https://issues.apache.org/jira/browse/KAFKA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170280#comment-14170280 ] Ewen Cheslack-Postava commented on KAFKA-1698: -- Created reviewboard https://r

[jira] [Updated] (KAFKA-1698) Validator.ensureValid() only validates default config value

[ https://issues.apache.org/jira/browse/KAFKA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1698: - Assignee: Ewen Cheslack-Postava Status: Patch Available (was: Open) > Valid

[jira] [Updated] (KAFKA-1698) Validator.ensureValid() only validates default config value

[ https://issues.apache.org/jira/browse/KAFKA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1698: - Attachment: KAFKA-1698.patch > Validator.ensureValid() only validates default conf

Review Request 26667: Patch for KAFKA-1698

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26667/ --- Review request for kafka. Bugs: KAFKA-1698 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170275#comment-14170275 ] Jun Rao commented on KAFKA-1481: Vladimir, Thanks for the patch. My suggestion is actuall

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170272#comment-14170272 ] Guozhang Wang commented on KAFKA-1555: -- Created KAFKA-1704 for partition configs. >

[jira] [Updated] (KAFKA-1697) remove code related to ack>1 on the broker

[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1697: - Description: We removed the ack>1 support from the producer client in kafka-1555. We can complete

[jira] [Created] (KAFKA-1704) Add PartitionConfig besides LogConfig

Guozhang Wang created KAFKA-1704: Summary: Add PartitionConfig besides LogConfig Key: KAFKA-1704 URL: https://issues.apache.org/jira/browse/KAFKA-1704 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170265#comment-14170265 ] Guozhang Wang commented on KAFKA-1634: -- I will work on this after KAFKA-1583. > Impr

[jira] [Updated] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1653: - Attachment: KAFKA-1653.patch > Duplicate broker ids allowed in replica assignment

[jira] [Updated] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1653: - Assignee: Ewen Cheslack-Postava Status: Patch Available (was: Open) > Dupli

[jira] [Commented] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170264#comment-14170264 ] Ewen Cheslack-Postava commented on KAFKA-1653: -- Created reviewboard https://r

Review Request 26666: Patch for KAFKA-1653

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/ --- Review request for kafka. Bugs: KAFKA-1653 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170256#comment-14170256 ] Jun Rao commented on KAFKA-1555: Committed to 0.8.2 too. > provide strong consistency wit

Re: including KAFKA-1555 in 0.8.2?

Great. Pushed to 0.8.2 too. Jun On Fri, Oct 10, 2014 at 2:52 PM, Joel Koshy wrote: > +1 > > On Fri, Oct 10, 2014 at 04:53:45PM +, Sriram Subramanian wrote: > > +1 > > > > On 10/10/14 9:39 AM, "Gwen Shapira" wrote: > > > > >+1 :) > > > > > >On Fri, Oct 10, 2014 at 9:34 AM, Joe Stein > wrot

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170242#comment-14170242 ] Jiangjie Qin commented on KAFKA-1647: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1647: Attachment: KAFKA-1647_2014-10-13_16:38:39.patch > Replication offset checkpoints (high water marks)

Re: Review Request 26373: Patch for KAFKA-1647

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/ --- (Updated Oct. 13, 2014, 11:38 p.m.) Review request for kafka. Bugs: KAFKA-164

[jira] [Commented] (KAFKA-979) Add jitter for time based rolling

[ https://issues.apache.org/jira/browse/KAFKA-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170196#comment-14170196 ] Ewen Cheslack-Postava commented on KAFKA-979: - Created reviewboard https://revi

[jira] [Updated] (KAFKA-1702) Messages silently Lost by producer

[ https://issues.apache.org/jira/browse/KAFKA-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1702: --- Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Alexis Midon (was: Jun Rao) Status

Review Request 26663: Patch for KAFKA-979

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26663/ --- Review request for kafka. Bugs: KAFKA-979 https://issues.apache.org/jira/br

[jira] [Updated] (KAFKA-979) Add jitter for time based rolling

[ https://issues.apache.org/jira/browse/KAFKA-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-979: Attachment: KAFKA-979.patch > Add jitter for time based rolling > ---

[jira] [Updated] (KAFKA-979) Add jitter for time based rolling

[ https://issues.apache.org/jira/browse/KAFKA-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-979: Assignee: Ewen Cheslack-Postava (was: Sriram Subramanian) Status: Patch Availab

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170095#comment-14170095 ] Jun Rao commented on KAFKA-1555: When a client receives a NotEnoughReplicasAfterAppendExce

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170071#comment-14170071 ] Jun Rao commented on KAFKA-1493: James, Thanks for the patch. A couple of more questions.

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170002#comment-14170002 ] Guozhang Wang commented on KAFKA-1555: -- Another thought about the min.isr config: we

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169987#comment-14169987 ] Guozhang Wang commented on KAFKA-1555: -- One question I have while trying to rebase KA

Re: Review Request 26373: Patch for KAFKA-1647

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/#review56434 --- core/src/main/scala/kafka/server/ReplicaManager.scala

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169842#comment-14169842 ] James Oliver commented on KAFKA-1493: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Oliver updated KAFKA-1493: Attachment: KAFKA-1493.patch > Use a well-documented LZ4 compression format and remove redundant LZ4

Review Request 26658: Patch for KAFKA-1493

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26658/ --- Review request for kafka. Bugs: KAFKA-1493 https://issues.apache.org/jira/b

[jira] [Comment Edited] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169616#comment-14169616 ] James Oliver edited comment on KAFKA-1493 at 10/13/14 7:41 PM: -

[jira] [Updated] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1305: - Resolution: Fixed Status: Resolved (was: Patch Available) > Controller can hang on contro

Jenkins build is back to normal : Kafka-trunk #300

See

[jira] [Updated] (KAFKA-1701) Improve controller and broker message handling.

[ https://issues.apache.org/jira/browse/KAFKA-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1701: Description: This ticket is a memo for future controller refactoring. It is related to KAFKA-1647. I

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169717#comment-14169717 ] Jay Kreps commented on KAFKA-1646: -- Hey [~xueqiang] what is the latency impact for that p

[jira] [Updated] (KAFKA-1196) java.lang.IllegalArgumentException Buffer.limit on FetchResponse.scala + 33

[ https://issues.apache.org/jira/browse/KAFKA-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1196: - Assignee: (was: Neha Narkhede) > java.lang.IllegalArgumentException Buffer.limit on FetchRespo

[jira] [Updated] (KAFKA-1631) ReplicationFactor and under-replicated partitions incorrect during reassignment

[ https://issues.apache.org/jira/browse/KAFKA-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1631: - Assignee: Ewen Cheslack-Postava > ReplicationFactor and under-replicated partitions incorrect duri

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169697#comment-14169697 ] Neha Narkhede commented on KAFKA-1305: -- [~sriharsha] Latest patch looks good. Pushing

Re: Review Request 26633: Patch for KAFKA-1305

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26633/#review56427 --- Ship it! core/src/main/scala/kafka/server/KafkaConfig.scala

Re: [DISCUSSION] Message Metadata

I need to take more time to think about this. Here are a few off-the-cuff remarks: - To date we have tried really, really hard to keep the data model for message simple since after all you can always add whatever you like inside the message body. - For system tags, why not just make these fields

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169648#comment-14169648 ] Joel Koshy commented on KAFKA-1634: --- [~junrao] yes you are right. The OffsetFetchRespons

[New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

Hi Kafka Dev Team, When I run the test to send message to single partition for 3 minutes or so on, I have encounter deadlock (please see the screen attached) and thread contention from YourKit profiling. Use Case: 1) Aggregating messages into same partition for metric counting. 2) Replicate Ol

[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169616#comment-14169616 ] James Oliver commented on KAFKA-1493: - Sure, I'll take a look at it now. > Use a well

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169415#comment-14169415 ] Bhavesh Mistry edited comment on KAFKA-1642 at 10/13/14 5:05 PM: ---

[jira] [Commented] (KAFKA-1670) Corrupt log files for segment.bytes values close to Int.MaxInt

[ https://issues.apache.org/jira/browse/KAFKA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169493#comment-14169493 ] Guozhang Wang commented on KAFKA-1670: -- Verified that system test has recovered, than

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169453#comment-14169453 ] Bhavesh Mistry commented on KAFKA-1642: --- [~jkreps] Let me know if you need any oth

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169415#comment-14169415 ] Bhavesh Mistry edited comment on KAFKA-1642 at 10/13/14 4:11 PM: ---

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169415#comment-14169415 ] Bhavesh Mistry edited comment on KAFKA-1642 at 10/13/14 4:10 PM: ---

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169415#comment-14169415 ] Bhavesh Mistry edited comment on KAFKA-1642 at 10/13/14 4:09 PM: ---

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169415#comment-14169415 ] Bhavesh Mistry edited comment on KAFKA-1642 at 10/13/14 4:09 PM: ---

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169415#comment-14169415 ] Bhavesh Mistry edited comment on KAFKA-1642 at 10/13/14 4:08 PM: ---

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169415#comment-14169415 ] Bhavesh Mistry commented on KAFKA-1642: --- {code} import java.io.IOException; import

[jira] [Updated] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Tretyakov updated KAFKA-1481: -- Attachment: KAFKA-1481_2014-10-13_18-23-35.patch > Stop using dashes AND underscores as

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169396#comment-14169396 ] Vladimir Tretyakov commented on KAFKA-1481: --- Added another patch which introduce

[jira] [Updated] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1305: -- Attachment: KAFKA-1305_2014-10-13_07:30:45.patch > Controller can hang on contro

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169343#comment-14169343 ] Sriharsha Chintalapani commented on KAFKA-1305: --- Updated reviewboard https:/

Re: Review Request 26633: Patch for KAFKA-1305

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26633/ --- (Updated Oct. 13, 2014, 2:30 p.m.) Review request for kafka. Bugs: KAFKA-1305