----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26633/#review56427 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/26633/#comment96710> this looks good now. - Neha Narkhede On Oct. 13, 2014, 2:30 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26633/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 2:30 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1305 > https://issues.apache.org/jira/browse/KAFKA-1305 > > > Repository: kafka > > > Description > ------- > > KAFKA-1305. Controller can hang on controlled shutdown with auto leader > balance enabled. > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaConfig.scala > 90af698b01ec82b6168e02b6af41887ef164ad51 > > Diff: https://reviews.apache.org/r/26633/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
