----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/#review56434 -----------------------------------------------------------
core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment96736> if (!partition.makeFollower(...)) However, see the comment further down on this. core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment96747> Also, if the above change is to be made maybe we should remove this info message. However, as mentioned further below we should probably skip this partition altogether. core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment96742> Can tweak this a bit? How about: Broker %d received LeaderAndIsrRequest with correlation id %d from controller %d epoch %d for partition [%s,%d] but cannot become follower since the new leader %d is unavailable. core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/26373/#comment96745> If a replica is already following a leader, it is unnecessary to stop the fetcher, truncate to HW and restart the fetcher. So I think we should still skip such partitions. (The associated replica will already be in the checkpoint array so its checkpoint won't get lost) - Joel Koshy On Oct. 6, 2014, 5:06 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26373/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 5:06 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1647 > https://issues.apache.org/jira/browse/KAFKA-1647 > > > Repository: kafka > > > Description > ------- > > Fix for Kafka-1647. > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 78b7514cc109547c562e635824684fad581af653 > > Diff: https://reviews.apache.org/r/26373/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
