[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148802#comment-14148802 ] Joel Koshy commented on KAFKA-1647: --- Yes that is one possibility but not the only one. F

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148795#comment-14148795 ] Joel Koshy commented on KAFKA-1555: --- This is an implementation detail but wrt the duplic

Build failed in Jenkins: Kafka-trunk #278

2014-09-25 Thread Apache Jenkins Server
See Changes: [neha.narkhede] KAFKA-589 Clean shutdown after startup connection failure; reviewed by Neha Narkhede -- Started by an SCM change Building remotely on ubuntu-1 (Ubuntu ubuntu) in workspac

[jira] [Commented] (KAFKA-1586) support sticky partitioning in the new producer

2014-09-25 Thread Jim Hoagland (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148771#comment-14148771 ] Jim Hoagland commented on KAFKA-1586: - +1 agreeing with Jay and Neha. I found the sti

[jira] [Updated] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-25 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1618: -- Status: Patch Available (was: In Progress) > Exception thrown when running console producer wit

[jira] [Commented] (KAFKA-1652) NoSuchElementException on server shutdown

2014-09-25 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148770#comment-14148770 ] Sriharsha Chintalapani commented on KAFKA-1652: --- [~jjkoshy] [~nehanarkhede]

[jira] [Updated] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-25 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1618: -- Status: In Progress (was: Patch Available) > Exception thrown when running console producer wit

[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-25 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148755#comment-14148755 ] BalajiSeshadri commented on KAFKA-1618: --- Ok,this one applies cleanly without issues.

[jira] [Updated] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-25 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1618: -- Attachment: KAFKA-1618-CLEAN.patch > Exception thrown when running console producer with no port

Re: Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

2014-09-25 Thread Jun Rao
> On Sept. 26, 2014, 12:17 a.m., Jun Rao wrote: > > Thanks for the patch. Looks good overall. A couple of comments. > > > > 1. Let's add a check of min.isr in Partition.appendMessagesToLeader() so > > that the message is not added to the leader's log if isr is less than > > min.isr. > > 2. We

[jira] [Updated] (KAFKA-1591) Clean-up Unnecessary stack trace in error/warn logs

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1591: - Reviewer: Jun Rao [~junrao], please feel free to reassign :) Going through JIRAs that have patche

[jira] [Commented] (KAFKA-1586) support sticky partitioning in the new producer

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148735#comment-14148735 ] Neha Narkhede commented on KAFKA-1586: -- +1 on not supporting sticky partitioning stra

[jira] [Updated] (KAFKA-589) Clean shutdown after startup connection failure

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-589: Assignee: Ewen Cheslack-Postava (was: Swapnil Ghike) > Clean shutdown after startup connection failu

[jira] [Commented] (KAFKA-589) Clean shutdown after startup connection failure

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148726#comment-14148726 ] Neha Narkhede commented on KAFKA-589: - Thanks for fixing a longstanding bug! +1 on the

[jira] [Updated] (KAFKA-589) Clean shutdown after startup connection failure

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-589: Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to trunk > Clean shutdown

[jira] [Comment Edited] (KAFKA-1499) Broker-side compression configuration

2014-09-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148718#comment-14148718 ] Manikumar Reddy edited comment on KAFKA-1499 at 9/26/14 4:19 AM: ---

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148718#comment-14148718 ] Manikumar Reddy commented on KAFKA-1499: Yes, broker.compression.enable property

Build failed in Jenkins: Kafka-trunk #277

2014-09-25 Thread Apache Jenkins Server
See Changes: [neha.narkhede] KAFKA-404 When using chroot path, create chroot on startup if it doesn't exist; reviewed by Neha Narkhede -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu

Re: Review Request 25944: Patch for KAFKA-1013

2014-09-25 Thread Mayuresh Gharat
> On Sept. 24, 2014, 5:13 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/OffsetClient.scala, line 133 > > > > > > Should we just use ClientUtils.fetchTopicMetadata? Made ClientUtils.fetchTopicMetadata use

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148702#comment-14148702 ] Neha Narkhede commented on KAFKA-1647: -- I see. So for this to lose all the data for t

[jira] [Updated] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1653: - Labels: newbie (was: ) > Duplicate broker ids allowed in replica assignment > ---

[jira] [Commented] (KAFKA-1652) NoSuchElementException on server shutdown

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148698#comment-14148698 ] Neha Narkhede commented on KAFKA-1652: -- [~jjkoshy] I saw this on trunk as of yesterda

[jira] [Resolved] (KAFKA-1652) NoSuchElementException on server shutdown

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1652. -- Resolution: Duplicate > NoSuchElementException on server shutdown >

[jira] [Reopened] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede reopened KAFKA-1577: -- See KAFKA-1652 > Exception in ConnectionQuotas while shutting down > --

[jira] [Commented] (KAFKA-1631) ReplicationFactor and under-replicated partitions incorrect during reassignment

2014-09-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148680#comment-14148680 ] Ewen Cheslack-Postava commented on KAFKA-1631: -- Right. Unfortunately most of

Re: Review Request 25944: Patch for KAFKA-1013

2014-09-25 Thread Mayuresh Gharat
> On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 374 > > > > > > Is there a difference between these two: > > > > Thread.

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148598#comment-14148598 ] Joel Koshy commented on KAFKA-1499: --- Thanks - it works now. Sorry I had forgotten to ru

Re: Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

2014-09-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25886/#review54639 --- I suggest we also make the changes required to reject the write if m

Re: Review Request 25995: Patch for KAFKA-1650

2014-09-25 Thread Jiangjie Qin
> On Sept. 25, 2014, 11:48 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 299 > > > > > > Do we need to do this check every time in the loop? Maybe we can

[jira] [Commented] (KAFKA-1631) ReplicationFactor and under-replicated partitions incorrect during reassignment

2014-09-25 Thread Ryan Berdeen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148559#comment-14148559 ] Ryan Berdeen commented on KAFKA-1631: - The patch does look like an improvement to the

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148557#comment-14148557 ] Neha Narkhede commented on KAFKA-1555: -- Followed the discussion and want to share som

[jira] [Updated] (KAFKA-1631) ReplicationFactor and under-replicated partitions incorrect during reassignment

2014-09-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1631: - Attachment: KAFKA-1631-v1.patch This patch fixes things in a way that I think [~rb

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148542#comment-14148542 ] Jun Rao commented on KAFKA-1555: 4b or 4d has the same issue that the value of min.isr or

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-25 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54636 --- Ship it! Ship It! - Joel Koshy On Sept. 25, 2014, 5:38 a.m., Man

Re: Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

2014-09-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25886/#review54635 --- Thanks for the patch. Looks good overall. A couple of comments. 1.

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148520#comment-14148520 ] Sriram Subramanian commented on KAFKA-1555: --- 2. I agree. I think what min_isr he

[jira] [Updated] (KAFKA-589) Clean shutdown after startup connection failure

2014-09-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-589: Attachment: KAFKA-589-v1.patch > Clean shutdown after startup connection failure > --

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148510#comment-14148510 ] Jun Rao commented on KAFKA-1555: a. I agree that unclean leader election is an orthogonal

[jira] [Updated] (KAFKA-589) Clean shutdown after startup connection failure

2014-09-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-589: Status: Patch Available (was: Open) This patch makes KafkaServer clean up after itse

Re: Review Request 25995: Patch for KAFKA-1650

2014-09-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review54620 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Can Fetch Request cause delay of Produce Request?

2014-09-25 Thread Vadim Chekan
Thank you Neha, Allocating dedicated connection for fetching client worked fine and did not require any changes to kafka client library code. Thinking about it, server perhaps could process Fetch and Produce requests in parallel, while still returning result in order as in the spec. What needs to

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148483#comment-14148483 ] Jay Kreps commented on KAFKA-1555: -- 1. Yeah this may have been a mistake. I think integer

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148450#comment-14148450 ] Gwen Shapira commented on KAFKA-1555: - Call me a control freak, but "don't lose data"

Re: Review Request 25944: Patch for KAFKA-1013

2014-09-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54609 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148407#comment-14148407 ] Sriram Subramanian commented on KAFKA-1555: --- Thank you for summarizing all the t

Re: [jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Robert Withers
Jay, thank you for the excellence. Regarding your point 6, I would just like to mention that with a partial function style interface facet for event listener registrations on top of FarRefs and RemotePromiseRefs, in ERights style distributed promises, it is easy to think about multiple registrat

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148371#comment-14148371 ] Jay Kreps commented on KAFKA-1555: -- This is a good discussion, I am glad we are taking th

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1647: -- Labels: newbie++ (was: ) > Replication offset checkpoints (high water marks) can be lost on hard kills

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148336#comment-14148336 ] Joel Koshy commented on KAFKA-1647: --- If b1 aborts the follower transition the high water

[jira] [Commented] (KAFKA-1631) ReplicationFactor and under-replicated partitions incorrect during reassignment

2014-09-25 Thread Ryan Berdeen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148304#comment-14148304 ] Ryan Berdeen commented on KAFKA-1631: - Not reporting partitions being reassigned seems

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148301#comment-14148301 ] Neha Narkhede commented on KAFKA-1647: -- [~jjkoshy] Sounds like a problem. I have a qu

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1647: - Priority: Critical (was: Major) > Replication offset checkpoints (high water marks) can be lost o

[jira] [Created] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

2014-09-25 Thread Ryan Berdeen (JIRA)
Ryan Berdeen created KAFKA-1653: --- Summary: Duplicate broker ids allowed in replica assignment Key: KAFKA-1653 URL: https://issues.apache.org/jira/browse/KAFKA-1653 Project: Kafka Issue Type: Bu

[jira] [Commented] (KAFKA-1652) NoSuchElementException on server shutdown

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148263#comment-14148263 ] Joel Koshy commented on KAFKA-1652: --- Are you sure you have the fix in KAFKA-1577 ? If so

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-404: Assignee: Jonathan Creasy > When using chroot path, create chroot on startup if it doesn't exist > --

[jira] [Closed] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-404. --- > When using chroot path, create chroot on startup if it doesn't exist > --

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-404: Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patches, pushed to

[jira] [Created] (KAFKA-1652) NoSuchElementException on server shutdown

2014-09-25 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-1652: Summary: NoSuchElementException on server shutdown Key: KAFKA-1652 URL: https://issues.apache.org/jira/browse/KAFKA-1652 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1419) cross build for scala 2.11

2014-09-25 Thread Jonathan Herriott (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148228#comment-14148228 ] Jonathan Herriott commented on KAFKA-1419: -- Hi, I need to integrate the kafka 0.

Re: Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

2014-09-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25886/ --- (Updated Sept. 25, 2014, 7:41 p.m.) Review request for kafka. Changes ---

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1555: Attachment: KAFKA-1555.5.patch Noticed that prev patch accidentally included my slightly modified b

Re: Review Request 26019: Patch for KAFKA-404

2014-09-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26019/#review54581 --- Ship it! Ship It! - Neha Narkhede On Sept. 25, 2014, 6:11 p.m.,

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-25 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148189#comment-14148189 ] Jonathan Creasy commented on KAFKA-404: --- RB Updated, let's merge this! :) (it's only

[jira] [Commented] (KAFKA-1651) Removed some extra whitespace in KafkaServer.scala

2014-09-25 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148185#comment-14148185 ] Jonathan Creasy commented on KAFKA-1651: I noticed them in the RB diff when I was

[jira] [Updated] (KAFKA-1651) Removed some extra whitespace in KafkaServer.scala

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1651: - Reviewer: Neha Narkhede > Removed some extra whitespace in KafkaServer.scala > ---

[jira] [Commented] (KAFKA-1651) Removed some extra whitespace in KafkaServer.scala

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148174#comment-14148174 ] Neha Narkhede commented on KAFKA-1651: -- [~jcreasy] How did you come across these whit

Re: Review Request 26020: Patch for KAFKA-1651

2014-09-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26020/#review54579 --- Ship it! Ship It! - Neha Narkhede On Sept. 25, 2014, 5:50 a.m.,

Re: Can Fetch Request cause delay of Produce Request?

2014-09-25 Thread Neha Narkhede
"The server guarantees that on a single TCP connection, requests will be processed in the order they are sent and responses will return in that order as well" But to achieve proper functioning of the client, I need to allocate another tcp connection for listeners now? Yes. The easiest way to

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148140#comment-14148140 ] Neha Narkhede commented on KAFKA-404: - Your suggestion about consolidation is also fine

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2014-09-25 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148121#comment-14148121 ] Bhavesh Mistry commented on KAFKA-1642: --- HI [~jkreps], I will work on the sample pr

[jira] [Comment Edited] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2014-09-25 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148121#comment-14148121 ] Bhavesh Mistry edited comment on KAFKA-1642 at 9/25/14 6:42 PM:

Can Fetch Request cause delay of Produce Request?

2014-09-25 Thread Vadim Chekan
Hi all, I'm working on my own kafka client implementation and I noticed strange situation. Time(s) | Action 0.0MetadataRequest 0.0MetadataResponse 0.2OffsetRequest 0.2OffsetResponse 0.3FetchRequest(MaxWaitTime=20sec) 6.0ProduceRequest 31.0 FetchResponse notice 25sec

Re: Review Request 26019: Patch for KAFKA-404

2014-09-25 Thread Jonathan Creasy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26019/ --- (Updated Sept. 25, 2014, 6:11 p.m.) Review request for kafka. Bugs: KAFKA-404

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-25 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Creasy updated KAFKA-404: -- Attachment: KAFKA-404_2014-09-25_13:11:02.patch > When using chroot path, create chroot on startu

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2014-09-25 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148057#comment-14148057 ] Jonathan Creasy commented on KAFKA-404: --- Updated reviewboard https://reviews.apache.o

Re: Review Request 26018: Patch for KAFKA-404

2014-09-25 Thread Jonathan Creasy
I went and looked at the ServerShutdownTest to implement your suggestion, and I donĀ¹t think I like this particular consolidation. How about I go and change this test to ServerStartupTest, and future startup checks can go there and we leave the Shutdown checks separate? On 9/25/14, 12:55 PM, "Neha

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2014-09-25 Thread Magnus Edenhill (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148054#comment-14148054 ] Magnus Edenhill commented on KAFKA-1367: [~guozhang] Yes, KAFKA-1555 looks like a

Re: Review Request 26018: Patch for KAFKA-404

2014-09-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26018/#review54559 --- core/src/test/scala/unit/kafka/server/CreateZKChrootTest.scala

[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148024#comment-14148024 ] Neha Narkhede commented on KAFKA-1618: -- [~balaji.sesha...@dish.com] I ran into issues

Re: KAFKA-404 and KAFKA-1651

2014-09-25 Thread Neha Narkhede
We only appreciate new contributions and don't mind going through a contributor on boarding process. In fact, I'd encourage you to give feedback on how we could improve your experience as a contributor :-) We are trying to improve the turnaround time on patch reviews. Hopefully assigning a Reviewe

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147967#comment-14147967 ] Sriram Subramanian commented on KAFKA-1555: --- ack = -1 with clean leader election

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147943#comment-14147943 ] Joel Koshy commented on KAFKA-1555: --- I'm +1 on the concept of min.isr and acks -1, 0, 1.

Re: Read a specific number of messages using kafka

2014-09-25 Thread pankaj ojha
Thank You. I will try this out. On Thu, Sep 25, 2014 at 10:01 PM, Gwen Shapira wrote: > Using high level consumer and assuming you already created an iterator: > > while (msgCount < maxMessages && it.hasNext()) { > bytes = it.next().message(); > eventList.add(bytes); > } > > (See a complete ex

Re: Read a specific number of messages using kafka

2014-09-25 Thread Gwen Shapira
Using high level consumer and assuming you already created an iterator: while (msgCount < maxMessages && it.hasNext()) { bytes = it.next().message(); eventList.add(bytes); } (See a complete example here: https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-kafka-source/src/main/jav

Read a specific number of messages using kafka

2014-09-25 Thread pankaj ojha
Hi, My requirement is to read a specific number of messages from kafka topic which contains data in json format and after reading number of messges, i need to write that in a file and then stop. How can I count number of messages read by my consumer code(either simpleconsumer or high level) ? Ple

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread saurabh agarwal (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147900#comment-14147900 ] saurabh agarwal commented on KAFKA-1555: Along with min.isr setting, the "unclean

[jira] [Comment Edited] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-25 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147871#comment-14147871 ] BalajiSeshadri edited comment on KAFKA-1618 at 9/25/14 3:39 PM:

[jira] [Updated] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-25 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1618: -- Attachment: KAFKA-1618-REBASED.patch REBASED Patch > Exception thrown when running console prod

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-09-25 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147815#comment-14147815 ] BalajiSeshadri commented on KAFKA-328: -- [~nehanarkhede] Can you please send me code st