> On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 374 > > <https://reviews.apache.org/r/25944/diff/3/?file=703083#file703083line374> > > > > Is there a difference between these two: > > > > Thread.sleep() > > > > TimeUnit.MILLISECONDS.sleep() > > > > since we do the former everywhere in the code base.
Its the same thing. Just another way of doing it. Internally it does the same thing. > On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/ExportOffsets.scala, line 33 > > <https://reviews.apache.org/r/25944/diff/3/?file=703085#file703085line33> > > > > Can we actually make the same format for ZK / offsetmanager, making two > > different formats would make it harder to be parsed since the user needs to > > know whether ZK or offsetmanager is used. Yeah, the offset manager format is simpler. So unless we are planning to fetch offsets from ZK and commit to OffsetManager this should work. what do you think? > On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/ExportOffsets.scala, line 199 > > <https://reviews.apache.org/r/25944/diff/3/?file=703085#file703085line199> > > > > You can take a look at KAFKA-686's latest patch which did some cleanup > > on the util functions; these function may probably merged into Utils. Would like to discuss more on this! - Mayuresh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54609 ----------------------------------------------------------- On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25944/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 5:48 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1013 > https://issues.apache.org/jira/browse/KAFKA-1013 > > > Repository: kafka > > > Description > ------- > > OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by > ImportOffsets and ExportOffsets > > > Modified the comments in the headers > > > Corrected a value > > > Diffs > ----- > > config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > fbc680fde21b02f11285a4f4b442987356abd17b > core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION > core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION > core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION > core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/25944/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
