----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26018/#review54559 -----------------------------------------------------------
core/src/test/scala/unit/kafka/server/CreateZKChrootTest.scala <https://reviews.apache.org/r/26018/#comment94745> Thanks for adding this test. It's probably worth consolidating some of our tests on server startup and shutdown. Can we rename ServerShutdownTest to ServerStartupAndShutdownTest and move this test there? - Neha Narkhede On Sept. 25, 2014, 5:31 a.m., Jonathan Creasy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26018/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 5:31 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-404 > https://issues.apache.org/jira/browse/KAFKA-404 > > > Repository: kafka > > > Description > ------- > > KAFKA-404 auto-create Zookeeper CHROOT on Startup > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaServer.scala > 390fef500d7e0027e698c259d777454ba5a0f5e8 > core/src/test/scala/unit/kafka/server/CreateZKChrootTest.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/26018/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Creasy > >
