[GitHub] [jspwiki] dependabot[bot] opened a new pull request, #259: Bump cargo-maven3-plugin from 1.9.13 to 1.10.5

2023-02-08 Thread via GitHub
dependabot[bot] opened a new pull request, #259: URL: https://github.com/apache/jspwiki/pull/259 Bumps cargo-maven3-plugin from 1.9.13 to 1.10.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.carg

[GitHub] [jspwiki] dependabot[bot] closed pull request #252: Bump cargo-maven3-plugin from 1.9.13 to 1.10.4

2023-02-08 Thread via GitHub
dependabot[bot] closed pull request #252: Bump cargo-maven3-plugin from 1.9.13 to 1.10.4 URL: https://github.com/apache/jspwiki/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jspwiki] dependabot[bot] commented on pull request #252: Bump cargo-maven3-plugin from 1.9.13 to 1.10.4

2023-02-08 Thread via GitHub
dependabot[bot] commented on PR #252: URL: https://github.com/apache/jspwiki/pull/252#issuecomment-1423603325 Superseded by #259. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [jspwiki] dependabot[bot] opened a new pull request, #260: Bump commons-fileupload from 1.4 to 1.5

2023-02-22 Thread via GitHub
dependabot[bot] opened a new pull request, #260: URL: https://github.com/apache/jspwiki/pull/260 Bumps commons-fileupload from 1.4 to 1.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-fileupload:commo

[GitHub] [jspwiki] dependabot[bot] opened a new pull request, #261: Bump jetty-all from 9.4.48.v20220622 to 9.4.51.v20230217

2023-02-27 Thread via GitHub
dependabot[bot] opened a new pull request, #261: URL: https://github.com/apache/jspwiki/pull/261 Bumps jetty-all from 9.4.48.v20220622 to 9.4.51.v20230217. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.ecl

[GitHub] [jspwiki] dependabot[bot] commented on pull request #253: Bump jetty-all from 9.4.48.v20220622 to 9.4.50.v20221201

2023-02-27 Thread via GitHub
dependabot[bot] commented on PR #253: URL: https://github.com/apache/jspwiki/pull/253#issuecomment-1447584273 Superseded by #261. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [jspwiki] dependabot[bot] closed pull request #253: Bump jetty-all from 9.4.48.v20220622 to 9.4.50.v20221201

2023-02-27 Thread via GitHub
dependabot[bot] closed pull request #253: Bump jetty-all from 9.4.48.v20220622 to 9.4.50.v20221201 URL: https://github.com/apache/jspwiki/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jspwiki] dependabot[bot] opened a new pull request, #262: Bump minimist and mkdirp in /jspwiki-war

2023-03-03 Thread via GitHub
dependabot[bot] opened a new pull request, #262: URL: https://github.com/apache/jspwiki/pull/262 Bumps [minimist](https://github.com/minimistjs/minimist) and [mkdirp](https://github.com/isaacs/node-mkdirp). These dependencies needed to be updated together. Updates `minimist` from 1.2.0 t

[GitHub] [jspwiki] dependabot[bot] commented on pull request #250: Bump minimist and mkdirp in /jspwiki-war

2023-03-03 Thread via GitHub
dependabot[bot] commented on PR #250: URL: https://github.com/apache/jspwiki/pull/250#issuecomment-1454147572 Superseded by #262. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [jspwiki] dependabot[bot] closed pull request #250: Bump minimist and mkdirp in /jspwiki-war

2023-03-03 Thread via GitHub
dependabot[bot] closed pull request #250: Bump minimist and mkdirp in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [jspwiki] dependabot[bot] opened a new pull request, #263: Bump cargo-maven3-plugin from 1.9.13 to 1.10.6

2023-03-12 Thread via GitHub
dependabot[bot] opened a new pull request, #263: URL: https://github.com/apache/jspwiki/pull/263 Bumps cargo-maven3-plugin from 1.9.13 to 1.10.6. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.carg

[GitHub] [jspwiki] dependabot[bot] closed pull request #259: Bump cargo-maven3-plugin from 1.9.13 to 1.10.5

2023-03-12 Thread via GitHub
dependabot[bot] closed pull request #259: Bump cargo-maven3-plugin from 1.9.13 to 1.10.5 URL: https://github.com/apache/jspwiki/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jspwiki] dependabot[bot] commented on pull request #259: Bump cargo-maven3-plugin from 1.9.13 to 1.10.5

2023-03-12 Thread via GitHub
dependabot[bot] commented on PR #259: URL: https://github.com/apache/jspwiki/pull/259#issuecomment-1465520515 Superseded by #263. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Use isEmpty(). Expresses the intent more clearly (jspwiki)

2023-03-24 Thread via GitHub
juanpablo-santos merged PR #231: URL: https://github.com/apache/jspwiki/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Avoid use File Stream. The FileInputStream and FileOutputStream class… (jspwiki)

2023-03-24 Thread via GitHub
juanpablo-santos merged PR #235: URL: https://github.com/apache/jspwiki/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Avoid use File Stream. The FileInputStream and FileOutputStream class… (jspwiki)

2023-03-24 Thread via GitHub
juanpablo-santos commented on PR #235: URL: https://github.com/apache/jspwiki/pull/235#issuecomment-1483315973 merged in 2.12.0-git-04, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Use isEmpty(). Expresses the intent more clearly (jspwiki)

2023-03-24 Thread via GitHub
juanpablo-santos commented on PR #231: URL: https://github.com/apache/jspwiki/pull/231#issuecomment-1483316139 merged in 2.12.0-git-04, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Replace Vector usages with the java.util.ArrayList. (jspwiki)

2023-03-24 Thread via GitHub
juanpablo-santos commented on code in PR #234: URL: https://github.com/apache/jspwiki/pull/234#discussion_r1148016035 ## jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java: ## @@ -135,8 +135,8 @@ public final class WikiEventManager { /* The Map of clien

Re: [PR] Avoid throwing NullPointerExceptions manually. (jspwiki)

2023-03-24 Thread via GitHub
juanpablo-santos commented on code in PR #236: URL: https://github.com/apache/jspwiki/pull/236#discussion_r1148017261 ## jspwiki-main/src/main/java/org/apache/wiki/providers/VersioningFileProvider.java: ## @@ -685,11 +685,11 @@ private static class CachedProperties { *

Re: [PR] Avoid method that assume default platform encoding is suitable. (jspwiki)

2023-03-24 Thread via GitHub
juanpablo-santos commented on code in PR #232: URL: https://github.com/apache/jspwiki/pull/232#discussion_r1148020915 ## jspwiki-util/src/main/java/org/apache/wiki/util/FileUtil.java: ## @@ -108,8 +108,8 @@ public static String runSimpleCommand( final String command, final Stri

Re: [PR] Bump cargo-maven3-plugin from 1.9.13 to 1.10.6 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos commented on PR #263: URL: https://github.com/apache/jspwiki/pull/263#issuecomment-1491016790 done in 2.12.0-git-04 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump cargo-maven3-plugin from 1.9.13 to 1.10.6 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #263: Bump cargo-maven3-plugin from 1.9.13 to 1.10.6 URL: https://github.com/apache/jspwiki/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump minimist and mkdirp in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #262: Bump minimist and mkdirp in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Bump jetty-all from 9.4.48.v20220622 to 9.4.51.v20230217 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos commented on PR #261: URL: https://github.com/apache/jspwiki/pull/261#issuecomment-1491017908 done in 2.12.0-git-04 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump jetty-all from 9.4.48.v20220622 to 9.4.51.v20230217 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #261: Bump jetty-all from 9.4.48.v20220622 to 9.4.51.v20230217 URL: https://github.com/apache/jspwiki/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Bump commons-fileupload from 1.4 to 1.5 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos commented on PR #260: URL: https://github.com/apache/jspwiki/pull/260#issuecomment-1491018122 done in 2.12.0-git-04 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump commons-fileupload from 1.4 to 1.5 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #260: Bump commons-fileupload from 1.4 to 1.5 URL: https://github.com/apache/jspwiki/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Bump jspc-maven-plugin from 3.2.0 to 3.2.2 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos commented on PR #257: URL: https://github.com/apache/jspwiki/pull/257#issuecomment-1491018398 done in 2.12.0-git-04 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump jspc-maven-plugin from 3.2.0 to 3.2.2 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #257: Bump jspc-maven-plugin from 3.2.0 to 3.2.2 URL: https://github.com/apache/jspwiki/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Bump xstream from 1.4.19 to 1.4.20 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos commented on PR #256: URL: https://github.com/apache/jspwiki/pull/256#issuecomment-1491018523 done in 2.12.0-git-04 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump xstream from 1.4.19 to 1.4.20 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #256: Bump xstream from 1.4.19 to 1.4.20 URL: https://github.com/apache/jspwiki/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump qs from 6.5.2 to 6.5.3 in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #255: Bump qs from 6.5.2 to 6.5.3 in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump path-parse from 1.0.6 to 1.0.7 in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #249: Bump path-parse from 1.0.6 to 1.0.7 in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump hsqldb.version from 2.7.0 to 2.7.1 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #244: Bump hsqldb.version from 2.7.0 to 2.7.1 URL: https://github.com/apache/jspwiki/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Bump hsqldb.version from 2.7.0 to 2.7.1 (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos commented on PR #244: URL: https://github.com/apache/jspwiki/pull/244#issuecomment-1491019266 done in 2.12.0-git-04 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Bump json-schema and jsprim in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #251: Bump json-schema and jsprim in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump decode-uri-component from 0.2.0 to 0.2.2 in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #254: Bump decode-uri-component from 0.2.0 to 0.2.2 in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump lodash from 4.17.15 to 4.17.21 in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #248: Bump lodash from 4.17.15 to 4.17.21 in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump tar from 4.4.13 to 4.4.19 in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #247: Bump tar from 4.4.13 to 4.4.19 in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump minimatch from 3.0.4 to 3.1.2 in /jspwiki-war (jspwiki)

2023-03-30 Thread via GitHub
juanpablo-santos closed pull request #246: Bump minimatch from 3.0.4 to 3.1.2 in /jspwiki-war URL: https://github.com/apache/jspwiki/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Add default maven goal. (jspwiki)

2023-04-10 Thread via GitHub
juanpablo-santos commented on code in PR #241: URL: https://github.com/apache/jspwiki/pull/241#discussion_r1162000556 ## pom.xml: ## @@ -462,6 +462,7 @@ +clean verify apache-rat:check javadoc:javadoc Review Comment: Hi, I'd rather not generate the javado

Re: [PR] Implement PMD maven plugin (jspwiki)

2023-04-10 Thread via GitHub
juanpablo-santos commented on code in PR #242: URL: https://github.com/apache/jspwiki/pull/242#discussion_r1162005963 ## pom.xml: ## @@ -472,6 +474,21 @@ + + Review Comment: I'd rather not include it, mainly because of two reasons * You

Re: [PR] Use apache string constant instead. (jspwiki)

2023-04-10 Thread via GitHub
juanpablo-santos commented on PR #212: URL: https://github.com/apache/jspwiki/pull/212#issuecomment-1502205883 closing this, as I understand that it follows up on #213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Use apache string constant instead. (jspwiki)

2023-04-10 Thread via GitHub
juanpablo-santos closed pull request #212: Use apache string constant instead. URL: https://github.com/apache/jspwiki/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Use own string constant instead. (jspwiki)

2023-04-10 Thread via GitHub
juanpablo-santos commented on code in PR #213: URL: https://github.com/apache/jspwiki/pull/213#discussion_r1162012699 ## jspwiki-event/pom.xml: ## @@ -45,6 +45,12 @@ commons-lang3 + Review Comment: I'd rather not use a constant for blank spaces, slashes or

Re: [PR] Remove unnecessary variables. There re not used in the scope. (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos merged PR #258: URL: https://github.com/apache/jspwiki/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Use java Stream instead. (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos merged PR #240: URL: https://github.com/apache/jspwiki/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] implements Serializable tp Non-Serializable classes that define a ser… (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos merged PR #211: URL: https://github.com/apache/jspwiki/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Bump jaxen from 1.2.0 to 2.0.0 (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos closed pull request #264: Bump jaxen from 1.2.0 to 2.0.0 URL: https://github.com/apache/jspwiki/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Bump gson from 2.9.1 to 2.10.1 (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos closed pull request #265: Bump gson from 2.9.1 to 2.10.1 URL: https://github.com/apache/jspwiki/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Bump maven-enforcer-plugin from 3.2.1 to 3.3.0 (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos closed pull request #266: Bump maven-enforcer-plugin from 3.2.1 to 3.3.0 URL: https://github.com/apache/jspwiki/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] implements Serializable tp Non-Serializable classes that define a ser… (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos commented on PR #211: URL: https://github.com/apache/jspwiki/pull/211#issuecomment-1528081313 merged in 2.12.0-git-05, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Remove unnecessary variables. There re not used in the scope. (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos commented on PR #258: URL: https://github.com/apache/jspwiki/pull/258#issuecomment-1528081381 merged in 2.12.0-git-05, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Use java Stream instead. (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos commented on PR #240: URL: https://github.com/apache/jspwiki/pull/240#issuecomment-1528081426 merged in 2.12.0-git-05, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump selenide from 6.12.4 to 6.13.1 (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos commented on PR #268: URL: https://github.com/apache/jspwiki/pull/268#issuecomment-1528081909 done in 2.12.0-git-05, not needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Bump selenide from 6.12.4 to 6.13.1 (jspwiki)

2023-04-28 Thread via GitHub
juanpablo-santos closed pull request #268: Bump selenide from 6.12.4 to 6.13.1 URL: https://github.com/apache/jspwiki/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Add default maven goal. (jspwiki)

2023-04-29 Thread via GitHub
arturobernalg commented on code in PR #241: URL: https://github.com/apache/jspwiki/pull/241#discussion_r1181089328 ## pom.xml: ## @@ -462,6 +462,7 @@ +clean verify apache-rat:check javadoc:javadoc Review Comment: changed. -- This is an automated message fro

Re: [PR] Avoid throwing NullPointerExceptions manually. (jspwiki)

2023-04-29 Thread via GitHub
arturobernalg closed pull request #236: Avoid throwing NullPointerExceptions manually. URL: https://github.com/apache/jspwiki/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Avoid throwing NullPointerExceptions manually. (jspwiki)

2023-04-29 Thread via GitHub
arturobernalg commented on PR #236: URL: https://github.com/apache/jspwiki/pull/236#issuecomment-1528807471 @juanpablo-santos I agree with your comment. In fact, Joshua Bloch states: --> Item 72 : Favor the use of standard exceptions:NullPointerException be thrown rather than IllegalAr

Re: [PR] Add default maven goal. (jspwiki)

2023-05-05 Thread via GitHub
juanpablo-santos merged PR #241: URL: https://github.com/apache/jspwiki/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Bump mockito.version from 5.2.0 to 5.3.1 (jspwiki)

2023-05-05 Thread via GitHub
juanpablo-santos closed pull request #269: Bump mockito.version from 5.2.0 to 5.3.1 URL: https://github.com/apache/jspwiki/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add default maven goal. (jspwiki)

2023-05-05 Thread via GitHub
juanpablo-santos commented on PR #241: URL: https://github.com/apache/jspwiki/pull/241#issuecomment-1536756100 merged in 2.12.0-git-06, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump flexmark.version from 0.64.0 to 0.64.4 (jspwiki)

2023-05-05 Thread via GitHub
juanpablo-santos closed pull request #271: Bump flexmark.version from 0.64.0 to 0.64.4 URL: https://github.com/apache/jspwiki/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Implement PMD maven plugin (jspwiki)

2023-05-06 Thread via GitHub
arturobernalg commented on PR #242: URL: https://github.com/apache/jspwiki/pull/242#issuecomment-1537219141 OK. I close the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Implement PMD maven plugin (jspwiki)

2023-05-06 Thread via GitHub
arturobernalg closed pull request #242: Implement PMD maven plugin URL: https://github.com/apache/jspwiki/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Use own string constant instead. (jspwiki)

2023-05-06 Thread via GitHub
arturobernalg closed pull request #213: Use own string constant instead. URL: https://github.com/apache/jspwiki/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Avoid method that assume default platform encoding is suitable. (jspwiki)

2023-05-06 Thread via GitHub
arturobernalg commented on code in PR #232: URL: https://github.com/apache/jspwiki/pull/232#discussion_r1186746895 ## jspwiki-util/src/main/java/org/apache/wiki/util/Serializer.java: ## @@ -89,7 +89,7 @@ public static String serializeToBase64(final Map< String, Serializable > m

Re: [PR] Replace Vector usages with the java.util.ArrayList. (jspwiki)

2023-05-06 Thread via GitHub
arturobernalg commented on code in PR #234: URL: https://github.com/apache/jspwiki/pull/234#discussion_r1186747581 ## jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java: ## @@ -135,8 +135,8 @@ public final class WikiEventManager { /* The Map of client o

Re: [PR] Replace Vector usages with the java.util.ArrayList. (jspwiki)

2023-05-06 Thread via GitHub
arturobernalg commented on code in PR #234: URL: https://github.com/apache/jspwiki/pull/234#discussion_r1186747581 ## jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java: ## @@ -135,8 +135,8 @@ public final class WikiEventManager { /* The Map of client o

[PR] java 11 improvements. (jspwiki)

2023-05-06 Thread via GitHub
arturobernalg opened a new pull request, #272: URL: https://github.com/apache/jspwiki/pull/272 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Bump plugin.surefire.version from 3.0.0 to 3.1.0 (jspwiki)

2023-05-13 Thread via GitHub
juanpablo-santos closed pull request #273: Bump plugin.surefire.version from 3.0.0 to 3.1.0 URL: https://github.com/apache/jspwiki/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bump selenide from 6.13.1 to 6.14.0 (jspwiki)

2023-05-13 Thread via GitHub
juanpablo-santos closed pull request #274: Bump selenide from 6.13.1 to 6.14.0 URL: https://github.com/apache/jspwiki/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Bump lucene.version from 9.5.0 to 9.6.0 (jspwiki)

2023-05-13 Thread via GitHub
juanpablo-santos closed pull request #276: Bump lucene.version from 9.5.0 to 9.6.0 URL: https://github.com/apache/jspwiki/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Bump tomcat.version from 9.0.74 to 9.0.75 (jspwiki)

2023-05-13 Thread via GitHub
juanpablo-santos closed pull request #275: Bump tomcat.version from 9.0.74 to 9.0.75 URL: https://github.com/apache/jspwiki/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

2023-06-03 Thread via GitHub
arturobernalg opened a new pull request, #282: URL: https://github.com/apache/jspwiki/pull/282 Description: This pull request addresses the issue JSPWIKI- by changing the default value of jspwiki.workDir from java.io.tmpdir to the servlet container's context-specific temp directo

[PR] Remove unnecessary import (jspwiki)

2023-06-09 Thread via GitHub
arturobernalg opened a new pull request, #283: URL: https://github.com/apache/jspwiki/pull/283 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Simplify conditions. (jspwiki)

2023-06-09 Thread via GitHub
arturobernalg opened a new pull request, #284: URL: https://github.com/apache/jspwiki/pull/284 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Resolve minimatch version conflict in wro4j-maven-plugin dependencies. (jspwiki)

2023-06-10 Thread via GitHub
arturobernalg opened a new pull request, #285: URL: https://github.com/apache/jspwiki/pull/285 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Bump flexmark.version from 0.64.4 to 0.64.6 (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos closed pull request #279: Bump flexmark.version from 0.64.4 to 0.64.6 URL: https://github.com/apache/jspwiki/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump selenide from 6.14.0 to 6.15.0 (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos closed pull request #281: Bump selenide from 6.14.0 to 6.15.0 URL: https://github.com/apache/jspwiki/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Bump maven-surefire-junit5-tree-reporter from 1.1.0 to 1.2.1 (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos closed pull request #277: Bump maven-surefire-junit5-tree-reporter from 1.1.0 to 1.2.1 URL: https://github.com/apache/jspwiki/pull/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Remove unnecessary import (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos merged PR #283: URL: https://github.com/apache/jspwiki/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki

Re: [PR] Remove unnecessary import (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos commented on PR #283: URL: https://github.com/apache/jspwiki/pull/283#issuecomment-1593815998 Merged on 2.12.1-git-01, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump cargo-maven3-plugin from 1.10.6 to 1.10.7 (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos commented on PR #280: URL: https://github.com/apache/jspwiki/pull/280#issuecomment-1593817139 already merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump cargo-maven3-plugin from 1.10.6 to 1.10.7 (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos closed pull request #280: Bump cargo-maven3-plugin from 1.10.6 to 1.10.7 URL: https://github.com/apache/jspwiki/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Resolve minimatch version conflict in wro4j-maven-plugin dependencies. (jspwiki)

2023-06-15 Thread via GitHub
juanpablo-santos commented on code in PR #285: URL: https://github.com/apache/jspwiki/pull/285#discussion_r1231608214 ## pom.xml: ## @@ -722,6 +722,12 @@ org.mockito mockito-core ${mockito.version} + Review Comment:

Re: [PR] Resolve minimatch version conflict in wro4j-maven-plugin dependencies. (jspwiki)

2023-06-16 Thread via GitHub
arturobernalg commented on code in PR #285: URL: https://github.com/apache/jspwiki/pull/285#discussion_r1232686468 ## pom.xml: ## @@ -722,6 +722,12 @@ org.mockito mockito-core ${mockito.version} + Review Comment: mmm

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

2023-06-16 Thread via GitHub
juanpablo-santos commented on code in PR #282: URL: https://github.com/apache/jspwiki/pull/282#discussion_r1232736946 ## jspwiki-main/src/main/java/org/apache/wiki/servlets/WikiServletContextListener.java: ## @@ -0,0 +1,87 @@ +/* +Licensed to the Apache Software Foundation (

Re: [PR] Resolve minimatch version conflict in wro4j-maven-plugin dependencies. (jspwiki)

2023-06-16 Thread via GitHub
arturobernalg commented on code in PR #285: URL: https://github.com/apache/jspwiki/pull/285#discussion_r1232686468 ## pom.xml: ## @@ -722,6 +722,12 @@ org.mockito mockito-core ${mockito.version} + Review Comment: mmm

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

2023-06-17 Thread via GitHub
arturobernalg commented on code in PR #282: URL: https://github.com/apache/jspwiki/pull/282#discussion_r1233121593 ## jspwiki-main/src/main/java/org/apache/wiki/servlets/WikiServletContextListener.java: ## @@ -0,0 +1,87 @@ +/* +Licensed to the Apache Software Foundation (ASF

Re: [PR] Use try-with-resources. (jspwiki)

2023-06-17 Thread via GitHub
arturobernalg commented on code in PR #207: URL: https://github.com/apache/jspwiki/pull/207#discussion_r1233123166 ## jspwiki-main/src/main/java/org/apache/wiki/tags/AttachmentsIteratorTag.java: ## @@ -108,8 +108,9 @@ public final int doStartTag() { public final int doAfte

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

2023-06-21 Thread via GitHub
juanpablo-santos commented on code in PR #282: URL: https://github.com/apache/jspwiki/pull/282#discussion_r1237476176 ## jspwiki-bootstrap/src/main/java/org/apache/wiki/bootstrap/WikiBootstrapServletContextListener.java: ## @@ -98,4 +101,33 @@ ConfigurationSource createConfigura

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

2023-06-21 Thread via GitHub
arturobernalg commented on code in PR #282: URL: https://github.com/apache/jspwiki/pull/282#discussion_r1237687781 ## jspwiki-bootstrap/src/main/java/org/apache/wiki/bootstrap/WikiBootstrapServletContextListener.java: ## @@ -98,4 +101,33 @@ ConfigurationSource createConfiguratio

[GitHub] [jspwiki-site] arturobernalg opened a new pull request, #1: Add myself to committer and PMC list

2023-06-22 Thread via GitHub
arturobernalg opened a new pull request, #1: URL: https://github.com/apache/jspwiki-site/pull/1 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] JSPWIKI-388 - ParamTag loops forever when parent tag is not ParamHandler (jspwiki)

2023-06-23 Thread via GitHub
arturobernalg opened a new pull request, #289: URL: https://github.com/apache/jspwiki/pull/289 This commit addresses an issue in the ParamTag class where, if the parent tag was not an instance of ParamHandler, an infinite loop would occur. This was due to the 'getParent()' method always ret

[PR] Use placeholders in the logger message. (jspwiki)

2023-06-23 Thread via GitHub
arturobernalg opened a new pull request, #291: URL: https://github.com/apache/jspwiki/pull/291 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Serializable class without serialVersionUID (jspwiki)

2023-06-23 Thread via GitHub
arturobernalg opened a new pull request, #292: URL: https://github.com/apache/jspwiki/pull/292 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [jspwiki-site] arturobernalg closed pull request #1: Add myself to committer and PMC list

2023-06-30 Thread via GitHub
arturobernalg closed pull request #1: Add myself to committer and PMC list URL: https://github.com/apache/jspwiki-site/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump hsqldb.version from 2.7.1 to 2.7.2 (jspwiki)

2023-07-29 Thread via GitHub
juanpablo-santos closed pull request #287: Bump hsqldb.version from 2.7.1 to 2.7.2 URL: https://github.com/apache/jspwiki/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Bump mockito.version from 5.3.1 to 5.4.0 (jspwiki)

2023-07-29 Thread via GitHub
juanpablo-santos closed pull request #288: Bump mockito.version from 5.3.1 to 5.4.0 URL: https://github.com/apache/jspwiki/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

  1   2   3   >