juanpablo-santos commented on code in PR #236:
URL: https://github.com/apache/jspwiki/pull/236#discussion_r1148017261
##########
jspwiki-main/src/main/java/org/apache/wiki/providers/VersioningFileProvider.java:
##########
@@ -685,11 +685,11 @@ private static class CachedProperties {
*/
public CachedProperties( final String pageName, final Properties
props, final long lastModified ) {
if ( pageName == null ) {
- throw new NullPointerException ( "pageName must not be null!"
);
+ throw new IllegalArgumentException ( "pageName must not be
null!" );
Review Comment:
I think this is one of those cases where `NullPointerException` really
expresses the intent - the field must not be null
##########
jspwiki-util/src/main/java/org/apache/wiki/util/TextUtil.java:
##########
@@ -232,8 +232,11 @@ public static String replaceString( final String orig,
final String src, final S
if ( orig == null ) {
return null;
}
- if ( src == null || dest == null ) {
- throw new NullPointerException();
+ if ( src == null ) {
+ throw new IllegalArgumentException ( "src must not be null!" );
Review Comment:
similar to above comment, perhaps is better to throw a
`NullPointerException` informing which field should not be `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
