juanpablo-santos commented on code in PR #234:
URL: https://github.com/apache/jspwiki/pull/234#discussion_r1148016035
##########
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java:
##########
@@ -135,8 +135,8 @@ public final class WikiEventManager {
/* The Map of client object to WikiEventDelegate. */
private final Map< Object, WikiEventDelegate > m_delegates = new
HashMap<>();
- /* The Vector containing any preloaded WikiEventDelegates. */
- private final Vector< WikiEventDelegate > m_preloadCache = new Vector<>();
+ /* The List containing any preloaded WikiEventDelegates. */
+ private final List< WikiEventDelegate > m_preloadCache =
Collections.synchronizedList( new ArrayList<>() );
Review Comment:
pr-wide comment:
please note that, per `Collections.synchronizedList` javadoc,
> It is imperative that the user manually synchronize on the returned list
when traversing it via Iterator, Spliterator or Stream: [...]
enhanced fors use internally an Iterator, so they also must be synchronized.
Would you mind rechecking the access to the new Lists in order to ensure they
remain synchronized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
