Re: IEP-70: Async Continuation Executor

Hi Pavel, I'd prefer public pool. Thanks, Stan > On 12 Apr 2021, at 20:17, Pavel Tupitsyn wrote: > > Stan, > > Sorry for the late reply (had a vacation). > >> In my ideal world, the users don't configure thread pools, they just have > safe default behavior (async execution) >> and a way to m

[DISCUSSION] MaxLineLength checkstyle rule

Hello, Igniters. Right now, we have a code style rule [1] - the line should fit in 120 characters. But, this rule violated in many and many places through code. I have a plan to add a check style rule to force maximum line length. For me, personally, 120 characters a bit old-fashioned restrictio

Re: [DISCUSSION] MaxLineLength checkstyle rule

Hello! Please find attached the distribution of line lengths in the project, in the form of (count, line length). I think that we can enforce a hard limit of 140 chars per line. I think that having longer lines is excessive and does not benefit readability. Having a limit of 150 or 180 does not

Re: [DISCUSSION] MaxLineLength checkstyle rule

Hello, Ilya. Thanks for the feedback. 140 characters is fine for me. > 15 апр. 2021 г., в 12:25, Ilya Kasnacheev > написал(а): > > Hello! > > Please find attached the distribution of line lengths in the project, in the > form of (count, line length). > > I think that we can enforce a hard

Re: [DISCUSSION] MaxLineLength checkstyle rule

Hi! Personally, I suppose that 120 chars per line is OK. Moreover, many codestyles suggests less chars per line. For example PEP8 recommends 80 (but we use 120 in pyignite and flake8 codestyle checks it). Google java codestyle insists on 100. More than 120 chars is too long as for me and is not co

Re: [DISCUSSION] Error handling in Ignite 3

Hi Alexei, > Each public method *must *have a section in the javadoc with a list of all possible error codes for this method. I consider it is redundant, because any public exception can be thrown from public API. If it not happens today, it may change tomorrow: one will be removed, another one w

[jira] [Created] (IGNITE-14548) BinaryThreadLocalContext must be cleaned when client is closed

Taras Ledkov created IGNITE-14548: - Summary: BinaryThreadLocalContext must be cleaned when client is closed Key: IGNITE-14548 URL: https://issues.apache.org/jira/browse/IGNITE-14548 Project: Ignite

Re: Stop sending IGNITE Created e-mails to dev@

Hi, Personally I do not like an idea of excluding notifications for created JIRA tickets from dev-list. I used such notifications in following cases: * React to tickets created by Ignite users in my area of responsibility. * Redirect questions created as JIRA tickets to user-list. * Trash spam tic

Re: IEP-70: Async Continuation Executor

Giving this another thought - I'm kinda torn on this myself now, as I like you argument that a chain of multiple (GG and not GG) continuations should execute in the same pool. This would probably be easier to understand for a beginning or intermediate Ignite user, which is the majority. Anyway,

Re: [DISCUSSION] MaxLineLength checkstyle rule

Hello! Let me clarify: I think that we should keep the "soft" 120 chars limit in CC, but introduce a hard limit of 140 in checkstyle, since it should not be too much work or annoy too much. In the future we may wish to harmonize the two. Regards, -- Ilya Kasnacheev чт, 15 апр. 2021 г. в 12:37

Re: [DISCUSSION] Error handling in Ignite 3

Hello! > All public methods throw only unchecked org.apache.ignite.lang.IgniteException containing aforementioned fields. > Each public method must have a section in the javadoc with a list of all possible error codes for this method. I don't think this is feasible at all. Imagine javadoc for cac

Re: [DISCUSSION] MaxLineLength checkstyle rule

> I think that we should keep the "soft" 120 chars limit in CC, but introduce a > hard limit of 140 in checkstyle Works for me. > 15 апр. 2021 г., в 14:21, Ilya Kasnacheev > написал(а): > > Hello! > > Let me clarify: I think that we should keep the "soft" 120 chars limit in > CC, but introdu

[jira] [Created] (IGNITE-14549) Calcite. ORDER BY column not from SELECT LIST

Konstantin Orlov created IGNITE-14549: - Summary: Calcite. ORDER BY column not from SELECT LIST Key: IGNITE-14549 URL: https://issues.apache.org/jira/browse/IGNITE-14549 Project: Ignite Is

Re[2]: [DISCUSSION] MaxLineLength checkstyle rule

Python is not so verbose as java ) +1 for 140   >Hi! >Personally, I suppose that 120 chars per line is OK. Moreover, many >codestyles suggests less chars per line. >For example PEP8 recommends 80 (but we use 120 in pyignite and flake8 >codestyle checks it). Google java codestyle insists on 100. >

Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule

But super long lines are a real problem while merging. It is super inconvenient. 120 chars is a good compromise. чт, 15 апр. 2021 г. в 14:39, Zhenya Stanilovsky : > > Python is not so verbose as java ) > +1 for 140 > > >Hi! > >Personally, I suppose that 120 chars per line is OK. Moreover, many >

Welcome letter

Hello Ignite Community! My name is Eduard. I want to contribute to Apache Ignite, my JIRA username *erixon*. Thanks! -- Best regards, Eduard.

[jira] [Created] (IGNITE-14550) NodeJS Thin Client: Invalid response id: in ClientSocket.js

Dheeraj Saini created IGNITE-14550: -- Summary: NodeJS Thin Client: Invalid response id: in ClientSocket.js Key: IGNITE-14550 URL: https://issues.apache.org/jira/browse/IGNITE-14550 Project: Ignite

[jira] [Created] (IGNITE-14551) NodeJS Thin Client - Error: Invalid response id: in ClientSocket.js

Dheeraj Saini created IGNITE-14551: -- Summary: NodeJS Thin Client - Error: Invalid response id: in ClientSocket.js Key: IGNITE-14551 URL: https://issues.apache.org/jira/browse/IGNITE-14551 Project: Ig

[jira] [Created] (IGNITE-14552) Calcite engine. Alias for function CHARACTER_LENGTH

Konstantin Orlov created IGNITE-14552: - Summary: Calcite engine. Alias for function CHARACTER_LENGTH Key: IGNITE-14552 URL: https://issues.apache.org/jira/browse/IGNITE-14552 Project: Ignite

[jira] [Created] (IGNITE-14553) Calcite engine. Duplicated result on insert

Konstantin Orlov created IGNITE-14553: - Summary: Calcite engine. Duplicated result on insert Key: IGNITE-14553 URL: https://issues.apache.org/jira/browse/IGNITE-14553 Project: Ignite Issu

[jira] [Created] (IGNITE-14554) Calcite engine. Provide ability to parse huge numeric literals

Konstantin Orlov created IGNITE-14554: - Summary: Calcite engine. Provide ability to parse huge numeric literals Key: IGNITE-14554 URL: https://issues.apache.org/jira/browse/IGNITE-14554 Project: I

Re: [DISCUSSION] Error handling in Ignite 3

чт, 15 апр. 2021 г. в 14:26, Ilya Kasnacheev : > Hello! > > > All public methods throw only unchecked > org.apache.ignite.lang.IgniteException containing aforementioned fields. > > Each public method must have a section in the javadoc with a list of all > possible error codes for this method. > >

[jira] [Created] (IGNITE-14555) Calcite engine. Create table from query result

Konstantin Orlov created IGNITE-14555: - Summary: Calcite engine. Create table from query result Key: IGNITE-14555 URL: https://issues.apache.org/jira/browse/IGNITE-14555 Project: Ignite I

[jira] [Created] (IGNITE-14556) Add Tuple validation.

Andrey Mashenkov created IGNITE-14556: - Summary: Add Tuple validation. Key: IGNITE-14556 URL: https://issues.apache.org/jira/browse/IGNITE-14556 Project: Ignite Issue Type: Improvement

[jira] [Created] (IGNITE-14557) Imrove row layout.

Andrey Mashenkov created IGNITE-14557: - Summary: Imrove row layout. Key: IGNITE-14557 URL: https://issues.apache.org/jira/browse/IGNITE-14557 Project: Ignite Issue Type: Improvement

Re: [DISCUSSION] Error handling in Ignite 3

Hi Alexey, I like the idea. 1. > TBL-0001 is a *string representation* of the error. It is built from 2 > byte scope id (mapped to name TBL) and 2 byte number (0001). Both > internally packed in int. No any kind of parsing will be necessary to read > scope/category. I think Alexey mean if it w

welcome message

Hello Ignite Community! My name is Eduard. I want to contribute to Apache Ignite, my JIRA username *erixon*. Thanks! -- Best regards, Eduard.

Re: [ANNOUNCE] Welcome Ivan Daschinsky as a new committer

Congrats, Ivan! вт, 13 апр. 2021 г. в 20:02, Ivan Daschinsky : > Guys, many thanks to all of you! > > вт, 13 апр. 2021 г. в 13:19, Alex Plehanov : > > > Ivan, congratulations! > > > > > > вт, 13 апр. 2021 г. в 13:02, Andrey Mashenkov < > andrey.mashen...@gmail.com > > >: > > > > > Ivan, congrats!

[VOTE][EXTENSION] Release Apache Ignite performance-statistics-ext, spring-data-all-ext and spring-tx-ext extensions 1.0.0 RC1

Dear Ignite Community, I have uploaded a release candidate of the following extension modules: performance-statistics-ext spring-data-ext spring-data-2.0-ext spring-data-2.2-ext spring-data-commons spring-tx-ext The release candidate of the performance-statistics-ext extension: https://dist.apac

[IGNITE-7641] Add CacheEntry#ttl method

Hi all, I created a pull request that creates new method on IgniteCache that returns the current TTL of a record. I’m not entirely clear who I should tag for a review, so I’m posting here. > https://issues.apache.org/jira/browse/IGNITE-7641 >

Re: welcome message

Hello! I have added you to the contributor role, now you can assign issues to yourself. Please familiarize with https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute Regards, -- Ilya Kasnacheev чт, 15 апр. 2021 г. в 18:30, Eduard Rakhmankulov : > Hello Ignite Community! > > My

[jira] [Created] (IGNITE-14558) Add information about javadoc validation and generation commands to DEVNOTES.md

Andrey N. Gura created IGNITE-14558: --- Summary: Add information about javadoc validation and generation commands to DEVNOTES.md Key: IGNITE-14558 URL: https://issues.apache.org/jira/browse/IGNITE-14558

[VOTE][EXTENSION] Release pyignite 0.4.0-rc0

Dear Igniters! Release candidate binaries are at least uploaded and ready for vote You can find them here: https://dist.apache.org/repos/dist/dev/ignite/pyignite/0.4.0-rc0 If you follow the link above, you will find source package (*.tar.gz and *.zip) and binary packages (wheels) for windows (x86

Re: IEP-70: Async Continuation Executor

I'll keep the common pool then, thank you. Public pool is the "work-horse of the Compute Grid" [1], so it does not seem to fit here at all. [1] https://ignite.apache.org/docs/latest/perf-and-troubleshooting/thread-pools-tuning#public-pool On Thu, Apr 15, 2021 at 2:18 PM Stanislav Lukyanov wrote:

Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule

Folks, I've briefly checked the total amount of the max length violations: 120 line length - 5540 violations 130 line length - 1891 violations 140 line length - 895 violations 150 line length - 478 violations I think the 140 max line length might be the best option for us. On Thu, 15 Apr 2021

Re: [VOTE][EXTENSION] Release Apache Ignite performance-statistics-ext, spring-data-all-ext and spring-tx-ext extensions 1.0.0 RC1

I'm sorry, but is it OK, that artifacts are signed with signature of non-PMC? чт, 15 апр. 2021 г. в 19:26, Nikita Amelchev : > Dear Ignite Community, > > I have uploaded a release candidate of the following extension modules: > > performance-statistics-ext > spring-data-ext > spring-data-2.0-ext

[jira] [Created] (IGNITE-14559) Fix javadoc in schema and table modules

Andrey Mashenkov created IGNITE-14559: - Summary: Fix javadoc in schema and table modules Key: IGNITE-14559 URL: https://issues.apache.org/jira/browse/IGNITE-14559 Project: Ignite Issue Ty

Re: [VOTE][EXTENSION] Release Apache Ignite performance-statistics-ext, spring-data-all-ext and spring-tx-ext extensions 1.0.0 RC1

My best guess that since PMCs have a binding vote in voting in release, a PMC member should sign binaries as well. And I suppose that in the past only PMC members were signing the release. Meanwhile, https://infra.apache.org/release-signing.html does not contain any mention of PMC role and only co

Re: [VOTE][EXTENSION] Release Apache Ignite performance-statistics-ext, spring-data-all-ext and spring-tx-ext extensions 1.0.0 RC1

According to ASF release policy [1] non-PMC committers can sign artifacts: > all artifacts placed in their directory must be signed by a committer, > preferably by a PMC member. [1] https://www.apache.org/legal/release-policy.html чт, 15 апр. 2021 г. в 23:05, Dmitriy Pavlov : > > My best guess

[jira] [Created] (IGNITE-14560) Fix javadoc in CLI module.

Andrey Mashenkov created IGNITE-14560: - Summary: Fix javadoc in CLI module. Key: IGNITE-14560 URL: https://issues.apache.org/jira/browse/IGNITE-14560 Project: Ignite Issue Type: Bug

[jira] [Created] (IGNITE-14561) Fix javadoc in Configuration module.

Andrey Mashenkov created IGNITE-14561: - Summary: Fix javadoc in Configuration module. Key: IGNITE-14561 URL: https://issues.apache.org/jira/browse/IGNITE-14561 Project: Ignite Issue Type:

[jira] [Created] (IGNITE-14562) Fix javadoc in Network module.

Andrey Mashenkov created IGNITE-14562: - Summary: Fix javadoc in Network module. Key: IGNITE-14562 URL: https://issues.apache.org/jira/browse/IGNITE-14562 Project: Ignite Issue Type: Bug

[jira] [Created] (IGNITE-14563) Fix javadoc in Runner module.

Andrey Mashenkov created IGNITE-14563: - Summary: Fix javadoc in Runner module. Key: IGNITE-14563 URL: https://issues.apache.org/jira/browse/IGNITE-14563 Project: Ignite Issue Type: Bug

[MTCGA]: new failures in builds [5967461] needs to be handled

Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. *New Critical Failure in master Control Utility https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ControlUtility?branch=%3Cdefault%3E No changes in the build

[jira] [Created] (IGNITE-14564) Add LICENSE and NOTICE file to all packages

Ivan Daschinsky created IGNITE-14564: Summary: Add LICENSE and NOTICE file to all packages Key: IGNITE-14564 URL: https://issues.apache.org/jira/browse/IGNITE-14564 Project: Ignite Issue

[CANCEL] [VOTE] Release pyignite 0.4.0-rc0

Dear Igniters Unfortunately, vote should be cancelled, because there is an absence of LICENSE and NOTICE in source package and NOTICE in binary packages. Issue created https://issues.apache.org/jira/browse/IGNITE-14564 New vote will appear soon. -- Sincerely yours, Ivan Daschinskiy

Re: [VOTE][EXTENSION] Release Apache Ignite performance-statistics-ext, spring-data-all-ext and spring-tx-ext extensions 1.0.0 RC1

-1 From me. There is an absence of NOTICE and LICENSE files in binary package. Also, there is no source package. These is a violation of apache release policy [1] [1] https://www.apache.org/legal/release-policy.html чт, 15 апр. 2021 г. в 23:23, Nikita Amelchev : > According to ASF release policy

[jira] [Created] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM

Maria Makedonskaya created IGNITE-14565: --- Summary: Add additional update counter logging for detect causes of AssertionError: LWM after HWM Key: IGNITE-14565 URL: https://issues.apache.org/jira/browse/IGNITE