> I think that we should keep the "soft" 120 chars limit in CC, but introduce a > hard limit of 140 in checkstyle
Works for me. > 15 апр. 2021 г., в 14:21, Ilya Kasnacheev <ilya.kasnach...@gmail.com> > написал(а): > > Hello! > > Let me clarify: I think that we should keep the "soft" 120 chars limit in > CC, but introduce a hard limit of 140 in checkstyle, since it should not be > too much work or annoy too much. > > In the future we may wish to harmonize the two. > > Regards, > -- > Ilya Kasnacheev > > > чт, 15 апр. 2021 г. в 12:37, Ivan Daschinsky <ivanda...@gmail.com>: > >> Hi! >> Personally, I suppose that 120 chars per line is OK. Moreover, many >> codestyles suggests less chars per line. >> For example PEP8 recommends 80 (but we use 120 in pyignite and flake8 >> codestyle checks it). Google java codestyle insists on 100. >> >> More than 120 chars is too long as for me and is not convenient for 3-way >> merges. >> >> чт, 15 апр. 2021 г. в 12:28, Nikolay Izhikov <nizhi...@apache.org>: >> >>> Hello, Ilya. >>> >>> Thanks for the feedback. >>> >>> 140 characters is fine for me. >>> >>>> 15 апр. 2021 г., в 12:25, Ilya Kasnacheev <ilya.kasnach...@gmail.com> >>> написал(а): >>>> >>>> Hello! >>>> >>>> Please find attached the distribution of line lengths in the project, >> in >>> the form of (count, line length). >>>> >>>> I think that we can enforce a hard limit of 140 chars per line. I think >>> that having longer lines is excessive and does not benefit readability. >>>> >>>> Having a limit of 150 or 180 does not give us much since there's still >>> a long tail which has to be fixed. >>>> >>>> Regards, >>>> -- >>>> Ilya Kasnacheev >>>> >>>> >>>> чт, 15 апр. 2021 г. в 11:30, Nikolay Izhikov <nizhi...@apache.org>: >>>> Hello, Igniters. >>>> >>>> Right now, we have a code style rule [1] - the line should fit in 120 >>> characters. >>>> But, this rule violated in many and many places through code. >>>> I have a plan to add a check style rule to force maximum line length. >>>> >>>> For me, personally, 120 characters a bit old-fashioned restriction. >>>> Should we increase the maximum line length to 150 or even 180 >> characters? >>>> >>>> [1] >> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines >>>> <linelengths.txt> >>> >>> >> >> -- >> Sincerely yours, Ivan Daschinskiy >>
