Andrey N. Gura created IGNITE-13140:
---
Summary: Incorrect example in Pull Request checklist: comma after
ticket name in commit message
Key: IGNITE-13140
URL: https://issues.apache.org/jira/browse/IGNITE-13140
+1 to change,
Actually it doesn't matter if we have consistency between PR pattern
and coding guidelines. Sorry, if I've missed something during the PR
pattern preparation.
On Fri, 5 Jun 2020 at 19:37, Andrey Gura wrote:
>
> I just didn't create JIRA issue. But it will be created.
>
> Is there a
I just didn't create JIRA issue. But it will be created.
Is there any other comments about change?
On Fri, Jun 5, 2020 at 7:31 PM Maxim Muzafarov wrote:
>
> Folks,
>
> It seems that the PR title mentioned above [1] does not satisfy both
> of the discussed patterns (with colon and without it).
>
Folks,
It seems that the PR title mentioned above [1] does not satisfy both
of the discussed patterns (with colon and without it).
Is it correct? Am I missing something previously discussed?
[1] https://github.com/apache/ignite/pull/7894
On Fri, 5 Jun 2020 at 16:55, Ilya Kasnacheev wrote:
>
>
Hello!
I think we have consensus here.
Can you merge it?
Thanks,
--
Ilya Kasnacheev
ср, 3 июн. 2020 г. в 16:38, Andrey Gura :
> I've prepared PR [1]
>
> I already tried to discuss commit message format [2] but stumbled upon
> some criticism. I still believe that we have to follow only one
>
So favorite topic =)
> In fact, it's even OK-ish to use it after the ticket name, since we see such
> tickets in our code base. It's just not the default and should not be
> recommended to new users.
Agree here. I would be even more liberal: at least there should be a
consistency among our guid
Pavel,
Form my point of view, your example doesn't break the format rule.
Moreover, the historical aspect also encourages us to follow this
format in the future (again because it makes easier parsing of
commits' messages).
On Wed, Jun 3, 2020 at 4:44 PM Pavel Tupitsyn wrote:
>
> Andrey, Ilya,
>
Hello!
I think that it's OK to use colon anywhere in a commit message, other than
directly after the ticket name.
In fact, it's even OK-ish to use it after the ticket name, since we see
such tickets in our code base. It's just not the default and should not be
recommended to new users.
Regards,
-
Andrey, Ilya,
I agree that we should follow a standard.
What would you say about .NET tickets/PRs?
Since the very beginning all those tickets are called ".NET: Foo Bar",
and commit messages are "IGNITE- .NET: Add Foo Bar".
Is it ok to continue like this, or do you think we should remove ":"
I've prepared PR [1]
I already tried to discuss commit message format [2] but stumbled upon
some criticism. I still believe that we have to follow only one
standard. It is unrelated with any annoying. It is just normal
practice which also allows avoid of precedents with references to any
concessio
Hello!
I have just noticed the following:
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-12407: Add Cluster API support
to Java thin client
However, this format conflicts with our "how to contribute" guide:
- Rename review to include JIR
11 matches
Mail list logo
