Pavel, Form my point of view, your example doesn't break the format rule. Moreover, the historical aspect also encourages us to follow this format in the future (again because it makes easier parsing of commits' messages).
On Wed, Jun 3, 2020 at 4:44 PM Pavel Tupitsyn <ptupit...@apache.org> wrote: > > Andrey, Ilya, > > I agree that we should follow a standard. > What would you say about .NET tickets/PRs? > > Since the very beginning all those tickets are called ".NET: Foo Bar", > and commit messages are "IGNITE-XXXX .NET: Add Foo Bar". > > Is it ok to continue like this, or do you think we should remove ":" here > as well? > > On Wed, Jun 3, 2020 at 4:38 PM Andrey Gura <ag...@apache.org> wrote: > > > I've prepared PR [1] > > > > I already tried to discuss commit message format [2] but stumbled upon > > some criticism. I still believe that we have to follow only one > > standard. It is unrelated with any annoying. It is just normal > > practice which also allows avoid of precedents with references to any > > concessions (e.g. on code review). > > > > Simple and sole format also makes easier commits log analysis (of > > course we already must remember that we have many commits with > > different message formats). > > > > [1] https://github.com/apache/ignite/pull/7894 > > [2] > > http://apache-ignite-developers.2346864.n4.nabble.com/Commit-message-format-td46573.html > > > > > > On Wed, Jun 3, 2020 at 4:24 PM Ilya Kasnacheev > > <ilya.kasnach...@gmail.com> wrote: > > > > > > Hello! > > > > > > I have just noticed the following: > > > > > > The pull request title is treated as the final commit message. > > > The following pattern must be used: IGNITE-12407: Add Cluster API support > > > to Java thin client > > > > > > However, this format conflicts with our "how to contribute" guide: > > > - Rename review to include JIRA key and description (example: "IGNITE-42 > > > Support CacheLoader and CacheWriter") > > > - There should be no colon after ticket name. Moreover, this is > > reinforced > > > by our commit messages: there 2x as much entries without colon after > > ticket > > > name than ones with colon. > > > > > > So I propose to change this checklist: > > > "The following pattern must be used: IGNITE-12407 Add Cluster API support > > > to Java thin client" > > > > > > WDYT? > > > > > > Regards, > > > -- > > > Ilya Kasnacheev > >
