+1 to change, Actually it doesn't matter if we have consistency between PR pattern and coding guidelines. Sorry, if I've missed something during the PR pattern preparation.
On Fri, 5 Jun 2020 at 19:37, Andrey Gura <ag...@apache.org> wrote: > > I just didn't create JIRA issue. But it will be created. > > Is there any other comments about change? > > On Fri, Jun 5, 2020 at 7:31 PM Maxim Muzafarov <mmu...@apache.org> wrote: > > > > Folks, > > > > It seems that the PR title mentioned above [1] does not satisfy both > > of the discussed patterns (with colon and without it). > > Is it correct? Am I missing something previously discussed? > > > > > > [1] https://github.com/apache/ignite/pull/7894 > > > > On Fri, 5 Jun 2020 at 16:55, Ilya Kasnacheev <ilya.kasnach...@gmail.com> > > wrote: > > > > > > Hello! > > > > > > I think we have consensus here. > > > > > > Can you merge it? > > > > > > Thanks, > > > -- > > > Ilya Kasnacheev > > > > > > > > > ср, 3 июн. 2020 г. в 16:38, Andrey Gura <ag...@apache.org>: > > > > > > > I've prepared PR [1] > > > > > > > > I already tried to discuss commit message format [2] but stumbled upon > > > > some criticism. I still believe that we have to follow only one > > > > standard. It is unrelated with any annoying. It is just normal > > > > practice which also allows avoid of precedents with references to any > > > > concessions (e.g. on code review). > > > > > > > > Simple and sole format also makes easier commits log analysis (of > > > > course we already must remember that we have many commits with > > > > different message formats). > > > > > > > > [1] https://github.com/apache/ignite/pull/7894 > > > > [2] > > > > http://apache-ignite-developers.2346864.n4.nabble.com/Commit-message-format-td46573.html > > > > > > > > > > > > On Wed, Jun 3, 2020 at 4:24 PM Ilya Kasnacheev > > > > <ilya.kasnach...@gmail.com> wrote: > > > > > > > > > > Hello! > > > > > > > > > > I have just noticed the following: > > > > > > > > > > The pull request title is treated as the final commit message. > > > > > The following pattern must be used: IGNITE-12407: Add Cluster API > > > > > support > > > > > to Java thin client > > > > > > > > > > However, this format conflicts with our "how to contribute" guide: > > > > > - Rename review to include JIRA key and description (example: > > > > > "IGNITE-42 > > > > > Support CacheLoader and CacheWriter") > > > > > - There should be no colon after ticket name. Moreover, this is > > > > reinforced > > > > > by our commit messages: there 2x as much entries without colon after > > > > ticket > > > > > name than ones with colon. > > > > > > > > > > So I propose to change this checklist: > > > > > "The following pattern must be used: IGNITE-12407 Add Cluster API > > > > > support > > > > > to Java thin client" > > > > > > > > > > WDYT? > > > > > > > > > > Regards, > > > > > -- > > > > > Ilya Kasnacheev > > > >
