Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Xuanwo
> You can see it’s what I mentioned in my vote email. However, as it’s like > this for a while, I voted +1 and I have PRs ready to be submitted (including > rat execution). > > So do you think it’s blocking ? Thanks for the clarification. I'm voting -1 due to the reasons mentioned, but it doe

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Jean-Baptiste Onofré
By the way, at Apache, it's not really possible to veto or block a release: you need three binding votes, even if we have a fourth binding vote with -1, the release can pass. That said, from a community standpoint, it's good to take any -1 (binding or non binding) into account. In your case, I wou

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Xuanwo
> That said, from a community standpoint, it's good to take any -1 (binding or > non binding) into account. > > In your case, I would have voted -0 (to avoid confusion). Lesson learned. Next time, if the same situation occurs, I'll vote -0 to make my statement more clear. On Thu, Oct 19, 2023,

Re: Kafka Connect sink

2023-10-19 Thread Bryan Keller
Hi JB, The plan is to move forward, unless there are concerns from anyone. I got a little bit sidetracked but will be working on addressing comments in the first PR then following up with more PRs after that one is merged, so stay tuned for those. Thanks, Bryan > On Oct 18, 2023, at 7:13 AM

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

2023-10-19 Thread Fokko Driesprong
+1 (binding) from me as well. I ran the example notebooks against the REST catalog . Cheers, Fokko Op do 19 okt 2023 om 02:37 schreef Rushan Jiang : > +1 (non-binding) > > - Verified signatures and checksums > - Verified license > - R

Re: Kafka Connect sink

2023-10-19 Thread Jean-Baptiste Onofré
Awesome ! Thanks for the update Bryan. I'm looking forward to the PR ! Regards JB On Thu, Oct 19, 2023 at 11:13 AM Bryan Keller wrote: > > Hi JB, > > The plan is to move forward, unless there are concerns from anyone. I got a > little bit sidetracked but will be working on addressing comments

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Fokko Driesprong
Thanks Eduard for running this release! +1 (binding): - Checked the sha/signature - Ran our example notebooks against 1.4.1 and it looks well Xuanwo, if you want to learn more about voting, there is also an Apache page on

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Xuanwo
> Xuanwo, if you want to learn more about voting, there is also an Apache page > on it > > (that includes some suggestions :). But also feel welcome to ask on the > devlist here. Thanks for pointing out the do

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Ajantha Bhat
+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests with JDK11 Thanks, Ajantha On Thu, Oct 19, 2023 at 3:12 PM Xuanwo wrote: > > Xuanwo, if you want to learn more about voting, there is also an Apache > page on it >

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

2023-10-19 Thread Amogh Jahagirdar
+1 non-binding Verified signature and checksum, RAT checks, and ran all unit/integration tests. Thanks, Amogh On Thu, Oct 19, 2023 at 2:23 AM Fokko Driesprong wrote: > +1 (binding) from me as well. > > I ran the example notebooks against the REST catalog >

Re: Kafka Connect sink

2023-10-19 Thread Renjie Liu
Great to hear that. I can help to review. On Thu, Oct 19, 2023 at 17:26 Jean-Baptiste Onofré wrote: > Awesome ! Thanks for the update Bryan. > > I'm looking forward to the PR ! > > Regards > JB > > On Thu, Oct 19, 2023 at 11:13 AM Bryan Keller wrote: > > > > Hi JB, > > > > The plan is to move f

Request access to iceberg slack channel

2023-10-19 Thread Alessio Izzo
Hello, I'd like to request access to the slack channel because I'm working with apache iceberg and I also did a small contribution on the python api ( https://github.com/apache/iceberg/pull/8286). I tried to follow the slack link in the website but I got the error that I do not have the apache.org

Re: Request access to iceberg slack channel

2023-10-19 Thread Fokko Driesprong
Hey Alessio, Everyone is welcome on the Iceberg slack. What kind of error are you seeing? Can you try this link: https://join.slack.com/t/apache-iceberg/shared_invite/zt-2561tq9qr-UtISlHgsdY3Virs3Z2_btQ Kind regards, Fokko Op do 19 okt 2023 om 19:11 schreef Alessio Izzo : > Hello, > I'd like to

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Steve Zhang
+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests using JDK17 (problem with TestS3RestSigner and ADLSFileIOTest related but I think it’s setup related) Thanks, Steve Zhang > On Oct 19, 2023, at 4:23 AM, Ajantha Bhat wrote: > >

JDBC namespace existence check #8340

2023-10-19 Thread Steve Zhang
Hey Iceberg Community: I want to ask for some help review on this PR https://github.com/apache/iceberg/pull/8340. It tried to solve the current issue where underscore cannot be used correctly in resolving nested namespace in JDBC catalog. Corresponding reproduce of the problem can be found i