+1 (binding)
Sorry might be a bit late, verified signature, checksum, tests
Tested functionalities related to Glue catalog with CLI and library
invocations.
Best,
Jack Ye
On Tue, Dec 6, 2022 at 5:05 PM Ryan Blue wrote:
> +1 (binding)
>
> Checked signature and checksum, ran tests with make tes
+1 (binding)
Checked signature and checksum, ran tests with make test, ran RAT.
Also tested the CLI to inspect a table's files and look through a REST
catalog and queried using duckdb with filter pushdown.
Looks great! Thanks, for all the hard work this release, everyone!
Ryan
On Tue, Dec 6, 2
If that's the current expectation then I am +1 on the release. I'll write
up issues for the pypi instructions and one for having s3 mock work locally.
On Tue, Dec 6, 2022 at 5:36 PM Ryan Blue wrote:
> Russell, we normally test with `make test`, which runs everything but the
> S3 mock stuff since
+1 (non-binding)
Passing:
Verified LICENSE in the tarball
Checked sha512 sums and signatures
Ran all non-s3 related tests using poetry and they are all passing (`poetry run
pytest tests/ -m "not s3”`)
---
However I am running some issue to use it as CLI ( I think it’s related to my
own runtime
Russell, we normally test with `make test`, which runs everything but the
S3 mock stuff since that runs in CI. That said, it would be great if we
could get `poetry run pytest` to work out of the box!
On Tue, Dec 6, 2022 at 2:58 PM Russell Spitzer
wrote:
> I tried one last time via Intellij, Inte
I tried one last time via Intellij, Intellij also required that I mark all
the dependencies as required to run the tests and also failed the same
localhost:9000 mock s3 tests.
On Tue, Dec 6, 2022 at 4:41 PM Russell Spitzer
wrote:
>
> Checked sigs, checksums and licenses which all worked but I wa
Checked sigs, checksums and licenses which all worked but I was unable to
run the tests following the instructions here
https://pypi.org/project/pyiceberg/
Except using the downloaded source directory
This gave me an exception
ImportError while loading conftest
'/Users/russellspitzer/Temp/py2/py
+1 (non-binding)
Checked the signatures, checksums, and licenses. Ran a couple of scans
which worked fine.
The test_missing_uri test failing is likely as Ryan mentioned, it picks up
your local config file. I run the tests using a fresh docker container, but
would be nice to isolate this in the fu
Dan, the test_missing_uri failure is because you have a default catalog in
your .pyiceberg.yaml file. I hit that all the time, too.
On Mon, Dec 5, 2022 at 10:16 AM Daniel Weeks
wrote:
> +1 (binding)
>
> I verified:
> - sigs, sums, licenses, tests
>
> I tested:
> - REST Catalog implementation
+1 (binding)
I verified:
- sigs, sums, licenses, tests
I tested:
- REST Catalog implementation
- creating/loading/renaming/dropping tables
- creating/removing namespace properties
- loading table to arrow dataframe via scan (and pandas via arrow)
- loading table to duckdb
I had one t
Hey Jun, Ryan,
Thanks Jun for sending out the first RC, and thanks Ryan for giving it
a try right away.
* RAT checks were difficult to read and included the downloaded RAT Jar
> file (we should use the Iceberg script)
Created a PR: https://github.com/apache/iceberg/pull/6348
* pip install faile
+0
Checksum, signature, tests, and RAT passed, but there were a couple of
issues:
* RAT checks were difficult to read and included the downloaded RAT Jar
file (we should use the Iceberg script)
* pip install failed at first, but succeeded later. The installed version
complained that pydantic was m
12 matches
Mail list logo
