+1 (non-binding) Checked the signatures, checksums, and licenses. Ran a couple of scans which worked fine.
The test_missing_uri test failing is likely as Ryan mentioned, it picks up your local config file. I run the tests using a fresh docker container, but would be nice to isolate this in the future <https://github.com/apache/iceberg/issues/6361>. Dan is right on the hard dependency. I've created a fix here <https://github.com/apache/iceberg/pull/6362>. Since PyArrow is required for the current read path, this went unnoticed Op ma 5 dec. 2022 om 19:44 schreef Ryan Blue <b...@tabular.io>: > Dan, the test_missing_uri failure is because you have a default catalog in > your .pyiceberg.yaml file. I hit that all the time, too. > > On Mon, Dec 5, 2022 at 10:16 AM Daniel Weeks <daniel.c.we...@gmail.com> > wrote: > >> +1 (binding) >> >> I verified: >> - sigs, sums, licenses, tests >> >> I tested: >> - REST Catalog implementation >> - creating/loading/renaming/dropping tables >> - creating/removing namespace properties >> - loading table to arrow dataframe via scan (and pandas via arrow) >> - loading table to duckdb >> >> I had one test failure locally (though it appears to pass in CI, so I >> consider this a non-blocker unless it is affecting everyone) >> test_missing_uri >> def test_missing_uri(): >> runner = CliRunner() >> result = runner.invoke(run, ["list"]) >> > assert result.exit_code == 1 >> E assert 0 == 1 >> E + where 0 = <Result okay>.exit_code >> >> tests/cli/test_console.py:140: AssertionError >> FAILED tests/cli/test_console.py::test_missing_uri - assert 0 == 1 >> >> A few things I noted: >> - I cannot import 'load_catalog' without the pyarrow dependency. So >> that seems like a hard dependency at this point and we should workaround it >> in the future. >> >> On Mon, Dec 5, 2022 at 9:05 AM Jun H. <junhe...@gmail.com> wrote: >> >>> Hi Everyone, >>> >>> I propose that we release the following RC as the official PyIceberg >>> 0.2.0 release. >>> >>> The commit ID is 577867e88da86ab70f4efcb12ab993d01062712a >>> * This corresponds to the tag: pyiceberg-0.2.0rc1 >>> (509a38cc1f08f399712c1e0a65e53f1ad7749153) >>> * https://github.com/apache/iceberg/releases/tag/pyiceberg-0.2.0rc1 >>> * >>> https://github.com/apache/iceberg/tree/577867e88da86ab70f4efcb12ab993d01062712a >>> >>> The release tarball, signature, and checksums are here: >>> * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.2.0rc1/ >>> >>> You can find the KEYS file here: >>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>> >>> Convenience binary artifacts are staged on pypi: >>> https://pypi.org/project/pyiceberg/0.2.0rc1/ >>> >>> And can be installed using: pip3 install pyiceberg==0.2.0rc1 >>> >>> Please download, verify, and test. >>> >>> Please vote in the next 72 hours. >>> >>> [ ] +1 Release this as PyIceberg 0.2.0 >>> [ ] +0 >>> [ ] -1 Do not release this because... >>> >>> > > -- > Ryan Blue > Tabular >
