Hey Jun, Ryan, Thanks Jun for sending out the first RC, and thanks Ryan for giving it a try right away.
* RAT checks were difficult to read and included the downloaded RAT Jar > file (we should use the Iceberg script) Created a PR: https://github.com/apache/iceberg/pull/6348 * pip install failed at first, but succeeded later. The installed version > complained that pydantic was missing even though pip claims it is installed > (maybe just me?) Would you happen to have any more information? I've tried in a new docker container against different Python versions but wasn't able to reproduce this. * make lint fails because there is no .git directory This one is more complicated than it seems at first glance. Pre-commit relies on git to list the files to check. This way you can also lint the files you have changed. However, just initializing an empty repository doesn't work, since we need to have the `python/` subdirectory similar to the iceberg repository. The easiest way to fix this would be to split out PyIceberg into its own repository. ArrowNotImplementedError: Function 'greater_equal' has no kernel matching > input types (timestamp[us, tz=+00:00], int64) > Great catch! I was able to reproduce this and created a fix: https://github.com/apache/iceberg/pull/6346 Kind regards, Fokko Driesprong Op vr 2 dec. 2022 om 02:38 schreef Ryan Blue <b...@tabular.io>: > +0 > > Checksum, signature, tests, and RAT passed, but there were a couple of > issues: > * RAT checks were difficult to read and included the downloaded RAT Jar > file (we should use the Iceberg script) > * pip install failed at first, but succeeded later. The installed version > complained that pydantic was missing even though pip claims it is installed > (maybe just me?) > * make lint fails because there is no .git directory > > I also converted a scan to Arrow, but got an error when trying to filter > by a timestamp: > ArrowNotImplementedError: Function 'greater_equal' has no kernel matching > input types (timestamp[us, tz=+00:00], int64) > > > On Thu, Dec 1, 2022 at 4:15 PM Jun H. <junhe...@gmail.com> wrote: > >> Hi Everyone, >> >> I propose that we release the following RC as the official PyIceberg >> 0.2.0 release. >> >> The commit ID is af0f35258b9caadb0bfc5311c224c2facc0f18aa >> * This corresponds to the tag: pyiceberg-0.2.0rc0 >> (c5928c46a12be07b99a1f115373bc65e6a2d2afe) >> * https://github.com/apache/iceberg/releases/tag/pyiceberg-0.2.0rc0 >> * >> https://github.com/apache/iceberg/tree/af0f35258b9caadb0bfc5311c224c2facc0f18aa >> >> The release tarball, signature, and checksums are here: >> * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.2.0rc0/ >> >> You can find the KEYS file here: >> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >> >> Convenience binary artifacts are staged on pypi: >> https://pypi.org/project/pyiceberg/0.2.0rc0/ >> >> And can be installed using: pip3 install pyiceberg==0.2.0rc0 >> >> Please download, verify, and test. >> >> Please vote in the next 72 hours. >> >> [ ] +1 Release this as PyIceberg 0.2.0 >> [ ] +0 >> [ ] -1 Do not release this because... >> >> >> > > -- > Ryan Blue > Tabular >
