Thank you Fokko, also forgot to update my vote to +1 given package version is
clarified.
Thank you for the great work!
Steve Zhang
> On Sep 30, 2022, at 8:02 AM, Driesprong, Fokko wrote:
>
> Hey Everyone,
>
> Thanks all for checking the release, and we can conclude the vote:
>
> Binding +
Hey Everyone,
Thanks all for checking the release, and we can conclude the vote:
Binding +1:
Ryan Blue
Daniel Weeks
Jack Ye
Anton Okolnychyi
Non-Binding +1:
Fokko Driesprong
Leilei Hu
Non-Binding +0:
Steve Zhang
I'll publish the artifacts right away. I also would like to thank everyone
for the
+1
- Anton
> On Sep 29, 2022, at 9:42 AM, Ye, Jack wrote:
>
> +1
>
> Ran checksum, checked license and signature, ran unit tests.
> Ran against Hive catalog and S3 with CLI, tested create/load/drop/rename
> table and create/drop/load database.
>
> Best,
> Jack Ye
>
> From: Daniel Weeks
+1
Ran checksum, checked license and signature, ran unit tests.
Ran against Hive catalog and S3 with CLI, tested create/load/drop/rename table
and create/drop/load database.
Best,
Jack Ye
From: Daniel Weeks
Reply-To: "dev@iceberg.apache.org"
Date: Wednesday, September 28, 2022 at 9:37 PM
To:
+1
I checked sigs/sums/license/tests.
I ran through the CLI commands with REST Catalog and a few with Hive
Metastore.
Minor issues (non-blockers):
- Miss configuration with uri / credentials often resulted in confusing
errors (asking to set the fields which were already supplied).
- I wasn't
Thanks for the clarification, Fokko!
I think it makes sense that I'd get an RC version from what was published
as an RC on PyPI! Since we will publish a final artifact with the right
version and none of the files in the release candidate are affected (it's
correct in the tarball and whl files) the
Thanks everyone for giving it a try.
I should have explained the version on PyPI. We need to add the RC postfix
to the version when we upload it to PyPI for testing. PyPI will extract the
version from the setup.py, and omitting the RC would mean an actual
release. The tarball will just contain the
+0 (non-binding and it’s just version needs to be fixed )
Passing:
Verified LICENSE in the tarball
Checked sha512 sums and signatures
Installed the CLI and ran basic commands with a hive metastore and AWS S3
Ran tests (on Docker python 3.9 image some pyarrow tests failed w/ permission
issue but
+0
Looks great, except that the version isn’t correct: pyiceberg.__version__
returns 0.1.0rc2
Passing:
- Verified LICENSE and NOTICE content in the tarball and whl (nit:
NOTICE and LICENSE are in different directories)
- Checked sha512 sums and signatures
- Ran RAT checks (nit: the p
