Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-23 Thread Eduard Tudenhoefner
Thanks everyone who participated in the vote for the Release Iceberg 1.4.1 RC0. The vote result is: +1: 3 (binding), 5 (non-binding) +0: 0 (binding), 0 (binding) -1: 0 (binding), 1 (non-binding) Therefore, the release candidate is passed. On Mon, Oct 23, 2023 at 12:54 AM Ryan Blue wrote: > +1

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-22 Thread Ryan Blue
+1 (binding) Ran RAT checks, validated signature & checksum, built. I went over the commits and they look reasonable for a patch release. One nit is that the python CI checks are failing. That shouldn't block a Java release, but it would be nice to remove Python if we end up doing another 1.4.x r

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-22 Thread Hussein Awala
+1 (non-binding) I tested the RC with spark 3.3 and hive catalog, and all looks good. On Thu, Oct 19, 2023 at 10:32 PM Steve Zhang wrote: > +1 (non-binding) > > - validated checksum and signature > - checked license docs & ran RAT checks > - ran build and tests using JDK17 (problem with TestS3Re

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Steve Zhang
+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests using JDK17 (problem with TestS3RestSigner and ADLSFileIOTest related but I think it’s setup related) Thanks, Steve Zhang > On Oct 19, 2023, at 4:23 AM, Ajantha Bhat wrote: > >

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Ajantha Bhat
+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests with JDK11 Thanks, Ajantha On Thu, Oct 19, 2023 at 3:12 PM Xuanwo wrote: > > Xuanwo, if you want to learn more about voting, there is also an Apache > page on it >

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Xuanwo
> Xuanwo, if you want to learn more about voting, there is also an Apache page > on it > > (that includes some suggestions :). But also feel welcome to ask on the > devlist here. Thanks for pointing out the do

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Fokko Driesprong
Thanks Eduard for running this release! +1 (binding): - Checked the sha/signature - Ran our example notebooks against 1.4.1 and it looks well Xuanwo, if you want to learn more about voting, there is also an Apache page on

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Xuanwo
> That said, from a community standpoint, it's good to take any -1 (binding or > non binding) into account. > > In your case, I would have voted -0 (to avoid confusion). Lesson learned. Next time, if the same situation occurs, I'll vote -0 to make my statement more clear. On Thu, Oct 19, 2023,

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Jean-Baptiste Onofré
By the way, at Apache, it's not really possible to veto or block a release: you need three binding votes, even if we have a fourth binding vote with -1, the release can pass. That said, from a community standpoint, it's good to take any -1 (binding or non binding) into account. In your case, I wou

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-19 Thread Xuanwo
> You can see it’s what I mentioned in my vote email. However, as it’s like > this for a while, I voted +1 and I have PRs ready to be submitted (including > rat execution). > > So do you think it’s blocking ? Thanks for the clarification. I'm voting -1 due to the reasons mentioned, but it doe

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-18 Thread Jean-Baptiste Onofré
Hi You can see it’s what I mentioned in my vote email. However, as it’s like this for a while, I voted +1 and I have PRs ready to be submitted (including rat execution). So do you think it’s blocking ? Regards JB Le mer. 18 oct. 2023 à 16:27, Xuanwo a écrit : > -1 (non-binding) > > - checksum

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-18 Thread Daniel Weeks
+1 (binding) Verified sigs/sums/license/build/test (Java 11) -Dan On Wed, Oct 18, 2023 at 7:30 AM Xuanwo wrote: > -1 (non-binding) > > - checksum and signature is good > > - the following files not have license > - .baseline/idea/intellij-java-palantir-style.xml > - .baseline/checkstyle/ch

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-18 Thread Xuanwo
-1 (non-binding) - checksum and signature is good - the following files not have license - .baseline/idea/intellij-java-palantir-style.xml - .baseline/checkstyle/checkstyle.xml - gradle/libs.versions.toml - .baseline/checkstyle/checkstyle-suppressions.xml - .baseline/checkstyle/checksty

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-18 Thread Eduard Tudenhoefner
+1 (non-binding) * validated checksum and signature * checked license docs & ran RAT checks * ran build and tests with JDK8 * ran into one test failure, which is reported in https://github.com/apache/iceberg/issues/8824, but this shouldn't block the release * tested with Trino in https://github.co

Re: [VOTE] Release Apache Iceberg 1.4.1 RC0

2023-10-18 Thread Jean-Baptiste Onofré
+1 (non binding) I checked: * hashes and signatures are OK * I did quick tests using spark 3.5 I found the following issues that we should fix: * the source distribution contains two binary files (used for tests, empty-puffin-uncompressed.bin and sample-metric-data-uncompressed.bin). Binary files