+1 (non-binding) * validated checksum and signature * checked license docs & ran RAT checks * ran build and tests with JDK8 * ran into one test failure, which is reported in https://github.com/apache/iceberg/issues/8824, but this shouldn't block the release * tested with Trino in https://github.com/trinodb/trino/pull/19434
On Wed, Oct 18, 2023 at 3:15 PM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > +1 (non binding) > > I checked: > * hashes and signatures are OK > * I did quick tests using spark 3.5 > > I found the following issues that we should fix: > * the source distribution contains two binary files (used for > tests, empty-puffin-uncompressed.bin > and sample-metric-data-uncompressed.bin). Binary files should not be > included in the source distribution. > * some files don't contain ASF header > > I will work to fix these issues, and also, I will propose to include rat > to test our distribution. > > Regards > JB > > > On Wed, Oct 18, 2023 at 11:15 AM Eduard Tudenhoefner <edu...@tabular.io> > wrote: > >> Hi Everyone, >> >> I propose that we release the following RC as the official Apache Iceberg >> 1.4.1 release. >> >> The commit ID is 445664fb8d82950215872cbfec91e37c5fa0920f >> * This corresponds to the tag: apache-iceberg-1.4.1-rc0 >> * https://github.com/apache/iceberg/commits/apache-iceberg-1.4.1-rc0 >> * >> https://github.com/apache/iceberg/tree/445664fb8d82950215872cbfec91e37c5fa0920f >> >> The release tarball, signature, and checksums are here: >> * https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.4.1-rc0 >> >> You can find the KEYS file here: >> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >> >> Convenience binary artifacts are staged on Nexus. The Maven repository >> URL is: >> * >> https://repository.apache.org/content/repositories/orgapacheiceberg-1147/ >> >> Please download, verify, and test. >> >> Please vote in the next 72 hours. >> >> [ ] +1 Release this as Apache Iceberg 1.4.1 >> [ ] +0 >> [ ] -1 Do not release this because... >> >> Only PMC members have binding votes, but other community members are >> encouraged to cast >> non-binding votes. This vote will pass if there are 3 binding +1 votes >> and more binding >> +1 votes than -1 votes. >> >>
