The updates and fixes have been merged, with help from @Fokko a new RC has
been put up. I'll send out the new vote email shortly!
Thanks all!
On Tue, Nov 12, 2024 at 1:38 PM Eduard Tudenhöfner
wrote:
> @Matt yes the licensing is a blocker unfortunately, so we should cancel
> the RC and start an
@Matt yes the licensing is a blocker unfortunately, so we should cancel the
RC and start an RC1 vote once this is fixed.
I should have properly voted in the earlier email, but will do it now.
-1 (binding) due to the licensing
On Tue, Nov 12, 2024 at 5:47 PM Jean-Baptiste Onofré
wrote:
> -1 (non
-1 (non binding)
I'm sorry Matt, but the LICENSE is not correct in the source
distribution: it contains reference to gradle, parquet, etc.
So, the LICENSE is probably a copy from iceberg java. I suggest to
start from "regular" LICENSE and add the go section.
The rest looks good:
- NOTICE is OK
-
@Eduard, would you see the LICENSE file updates as blocking and requiring a
new RC?
I was figuring that the verification script updates can be pushed to the
next release since it can still be manually verified.
On Tue, Nov 12, 2024 at 10:44 AM Eduard Tudenhöfner <
etudenhoef...@apache.org> wrote:
I also ran into the same issues that Kevin pointed out earlier while
verifying the release, but apart from that all tests passed.
I think the LICENSE file needs to be updated as it contains Java-specific
things, which can be seen in
https://github.com/apache/iceberg-go/blob/main/LICENSE#L216-L315.
BTW for folks verifying this RC, these are the changes I made locally for
the `dev/release/verify_rc.sh` script to work.
https://github.com/apache/iceberg-go/pull/199/files
Best,
Kevin Liu
On Mon, Nov 11, 2024 at 3:03 PM Kevin Liu wrote:
> Hi Matt,
>
> Thanks for the release candidate! +1 (non-
Hi Matt,
Thanks for the release candidate! +1 (non-binding). I was able to download,
verify checksums and signatures, and run the unit tests successfully after
making a few changes locally.
I tried to follow the verification steps outlined in
https://github.com/apache/iceberg-go/blob/main/dev/re
