@Eduard, would you see the LICENSE file updates as blocking and requiring a new RC?
I was figuring that the verification script updates can be pushed to the next release since it can still be manually verified. On Tue, Nov 12, 2024 at 10:44 AM Eduard Tudenhöfner < etudenhoef...@apache.org> wrote: > I also ran into the same issues that Kevin pointed out earlier while > verifying the release, but apart from that all tests passed. > I think the LICENSE file needs to be updated as it contains Java-specific > things, which can be seen in > https://github.com/apache/iceberg-go/blob/main/LICENSE#L216-L315. > > On Tue, Nov 12, 2024 at 2:06 AM Kevin Liu <kevin.jq....@gmail.com> wrote: > >> BTW for folks verifying this RC, these are the changes I made locally for >> the `dev/release/verify_rc.sh` script to work. >> https://github.com/apache/iceberg-go/pull/199/files >> >> Best, >> Kevin Liu >> >> On Mon, Nov 11, 2024 at 3:03 PM Kevin Liu <kevin.jq....@gmail.com> wrote: >> >>> Hi Matt, >>> >>> Thanks for the release candidate! +1 (non-binding). I was able to download, >>> verify checksums and signatures, and run the unit tests successfully after >>> making a few changes locally. >>> >>> >>> I tried to follow the verification steps outlined in >>> https://github.com/apache/iceberg-go/blob/main/dev/release/README.md#verify >>> and ran into a couple of issues. >>> >>> On the `main` branch, I ran `dev/release/verify_rc.sh 0.1.0 0`. The >>> script failed with >>> ``` >>> + fetch_archive >>> + download_rc_file apache-iceberg-go-0.1.0.tar.gz >>> + '[' 1 -gt 0 ']' >>> + download >>> https://github.com/apache/iceberg-go/releases/download/v0.1.0-rc0/apache-iceberg-go-0.1.0.tar.gz >>> + curl --fail --location --remote-name --show-error --silent >>> https://github.com/apache/iceberg-go/releases/download/v0.1.0-rc0/apache-iceberg-go-0.1.0.tar.gz >>> curl: (22) The requested URL returned error: 404 >>> ``` >>> I think the issue is with this line. >>> https://github.com/apache/iceberg-go/blob/adc8193de3299b04c9763c2fba529a7b94d080ce/dev/release/verify_rc.sh#L102 >>> which expects the file name to be in the form of >>> `apache-iceberg-go-${VERSION}` (` >>> https://github.com/apache/iceberg-go/releases/download/v0.1.0-rc0/apache-iceberg-go-0.1.0.tar.gz` >>> <https://github.com/apache/iceberg-go/releases/download/v0.1.0-rc0/apache-iceberg-go-0.1.0.tar.gz> >>> ) >>> However, the actual file produced on Github is in the form of >>> `apache-iceberg-go-0.1.0-rc0.tar.gz`, notice the extra `rc0`. See the >>> assets at https://github.com/apache/iceberg-go/releases/v0.1.0-rc0 >>> >>> After making a change locally, >>> ``` >>> ARCHIVE_BASE_NAME="apache-iceberg-go-${VERSION}-rc${RC}" >>> ``` >>> I was able to download the artifacts. Running `dev/release/verify_rc.sh >>> 0.1.0 0` again, I got this error >>> ``` >>> gpg: Signature made Mon Nov 11 07:58:21 2024 PST >>> gpg: using RSA key >>> 74EE211E32BF1DF9D984FA394B86A1E5E59C8B81 >>> gpg: Can't check signature: No public key >>> ``` >>> It looks like that KEY is only in >>> https://dist.apache.org/repos/dist/release/iceberg/KEYS but not in >>> https://dist.apache.org/repos/dist/dev/iceberg/KEYS which the script >>> uses. >>> >>> After making the change locally, >>> ``` >>> ICEBERG_DIST_BASE_URL=" >>> https://dist.apache.org/repos/dist/release/iceberg"; >>> ``` >>> I was able to run `dev/release/verify_rc.sh 0.1.0 0` successfully. >>> >>> ``` >>> + VERIFY_SUCCESS=yes >>> + echo 'RC looks good!' >>> RC looks good! >>> ``` >>> >>> Should we make the necessary changes in `verify_rc.sh` and also upload >>> the KEYS to https://dist.apache.org/repos/dist/dev/iceberg/KEYS? >>> >>> Best, >>> Kevin Liu >>> >>> >>> On Mon, Nov 11, 2024 at 2:12 PM Matt Topol <zotthewiz...@gmail.com> >>> wrote: >>> >>>> Hi, >>>> >>>> I would like to propose the following release candidate (RC0) of Apache >>>> Iceberg Go version v0.1.0. >>>> >>>> This release candidate is based on >>>> commit: adc8193de3299b04c9763c2fba529a7b94d080ce [1] >>>> >>>> The source release rc0 is hosted at [2]. >>>> >>>> Please download, verify checksums and signatures, run the unit tests, >>>> and vote on the release. See [3] for how to validate a release candidate. >>>> >>>> The vote will be open for at least 72 hours. >>>> >>>> [ ] +1 Release this as Apache Iceberg Go v0.1.0 >>>> [ ] +0 >>>> [ ] -1 Do not release this as Apache Iceberg Go v0.1.0 because... >>>> >>>> Thanks! >>>> --Matt >>>> >>>> [1]: >>>> https://github.com/apache/iceberg-go/tree/adc8193de3299b04c9763c2fba529a7b94d080ce >>>> [2]: https://github.com/apache/iceberg-go/releases/v0.1.0-rc0 >>>> [3]: >>>> https://github.com/apache/iceberg-go/blob/main/dev/release/README.md#verify >>>> >>>
