That makes sense. I've updated the PR:
https://github.com/apache/iceberg-python/pull/410/ PTAL.
Kind regards,
Fokko
Op zo 11 feb 2024 om 03:58 schreef Justin Mclean :
> HI,
>
> For the Thrift and Hive ones, we have an optional dependency that ships
> the content under the vendor/ directory:
> ht
HI,
> For the Thrift and Hive ones, we have an optional dependency that ships the
> content under the vendor/ directory:
> https://github.com/apache/iceberg-python/tree/main/vendor These are the
> Python Thrift code for talking Thrift to the Hive metastore. Both the Hive
> and Thrift NOTICES a
Hi,
> However, I don't think the notice for thrift or hive needs to be included.
> The license file states that the project uses the thrift definitions, but it
> does not include them in the project or dependencies. There are no direct
> artifacts from those projects. Since nothing is bundle
Hi Justin, Dan,
Thanks for checking this.
For the Avro one, we copied parts of the decompression and binary decoder
for the internal PyIceberg implementation (that reads from an Iceberg
schema, rather than from an Avro schema). I checked the Avro NOTICE, and
there isn't anything relevant. I notic
I think Fokko will need to weigh in on the avro usage.
However, I don't think the notice for thrift or hive needs to be included.
The license file states that the project uses the thrift definitions, but
it does not include them in the project or dependencies. There are no
direct artifacts from t
Hi,
Sure, the LICENSE file says it includes code from other ASF projects i.e. Avro,
Thrift and Hive. All of these have NOTICE files [1][2][3]. The content from
those files (or rather a subset) needs to be included in this releases NOTICE
fle.
Kind Regards,
Justin
1. https://github.com/apache
Justin,
Can you please clarify your comment about the NOTICE file? You said
content is missing from the notice file, but this project does not bundle
anything external that would qualify to my knowledge.
The project dependencies are not included in the distribution. They are
installed by the use
Hi,
I checked the release and found:
- signatures and hashes are fine
- LICENSE is fine
- NOTICE is missing content from NOTICE of bundled code NOTICE files
- All files have ASF headers
- No unexpected binary files
With a NOTICE file, you need to include the relevant parts in your NOTCE file
if
Hi everyone, thank you very much for testing out the RC and submitting your
votes
We would like to unfortunately cancel the current RC and send out a new one
that will include the following two critical fixes:
- Hive locking
- Issue with creating V1 tables with Hive, SQL and Glue catalogs.
Tha
-1
Unfortunately we found that the Hive catalog wasn't properly locking on
table updates. I feel that since a major aspect of this release is write
support, we shouldn't introduce that feature in an unsafe way.
We already have a fix on main, so it shouldn't hold up moving forward with
another re
+1 (binding)
Checked license, signature, checksum
Ran test and test-s3 in python 3.11
Ran manual testing with Glue catalog
Thanks for the work, and happy Chinese New Year!
Best,
Jack Ye
On Fri, Feb 9, 2024 at 4:34 PM Ryan Blue wrote:
> +1 (binding)
>
> - Checked licenses, signature, checksum
+1 (binding)
- Checked licenses, signature, checksum, and tag hash
- Built and tested in Python 3.10
- Ran some REST catalog interactions via the PyIceberg CLI
On Fri, Feb 9, 2024 at 11:38 AM Drew wrote:
> +1 (non-binding)
>
> - verified signature and checksum
> - verified RAT license check
> -
+1 (non-binding)
- verified signature and checksum
- verified RAT license check
- ran install, tests, and integration tests in python 3.11
- ran some manual tests with GlueCatalog
Looks good!
- Drew
On Thu, Feb 8, 2024 at 10:29 PM Honah J. wrote:
> +1 (non-binding)
>
> - Verified signatures an
+1 (non-binding)
- Verified signatures and checksums
- Verified license
- Ran unit tests and integration tests
Thanks to Sung for preparing the release, and a big thank you to everyone
who contributed to pyiceberg 0.6.0
Best regards,
Honah
On Thu, Feb 8, 2024 at 6:28 AM Sung Yun (BLOOMBERG/ 120
Hi Everyone,
Apologies for the many RC's, but as people are actively trying out PyIceberg
and write
support, we continue to find bugs and improvements. This RC includes:
- Support converting Arrow int8, int16 and large-string types.
- Fixed a discrepancy between the Daft docs and code.
- Properl
15 matches
Mail list logo
