Hi Justin, Dan, Thanks for checking this.
For the Avro one, we copied parts of the decompression and binary decoder for the internal PyIceberg implementation (that reads from an Iceberg schema, rather than from an Avro schema). I checked the Avro NOTICE, and there isn't anything relevant. I noticed that it was also a bit outdated <https://github.com/apache/avro/pull/2729>. For the Thrift and Hive ones, we have an optional dependency that ships the content under the vendor/ directory: https://github.com/apache/iceberg-python/tree/main/vendor These are the Python Thrift code for talking Thrift to the Hive metastore. Both the Hive and Thrift NOTICES are empty, we can add the "This product includes software developed at the Apache Software Foundation...", but that seems to be optional <https://infra.apache.org/licensing-howto.html#bundle-asf-product>. I've raised a PR here to add these anyway <https://github.com/apache/iceberg-python/pull/410/files>. Kind regards, Fokko Op zo 11 feb 2024 om 01:24 schreef Daniel Weeks <daniel.c.we...@gmail.com>: > I think Fokko will need to weigh in on the avro usage. > > However, I don't think the notice for thrift or hive needs to be > included. The license file states that the project uses the thrift > definitions, but it does not include them in the project or dependencies. > There are no direct artifacts from those projects. Since nothing is > bundled from those projects, I don't believe this applies. > > -Dan > > On Sat, Feb 10, 2024 at 4:14 PM Justin Mclean <jus...@classsoftware.com> > wrote: > >> Hi, >> >> Sure, the LICENSE file says it includes code from other ASF projects i.e. >> Avro, Thrift and Hive. All of these have NOTICE files [1][2][3]. The >> content from those files (or rather a subset) needs to be included in this >> releases NOTICE fle. >> >> Kind Regards, >> Justin >> >> 1. https://github.com/apache/avro/blob/main/NOTICE.txt >> 2. https://github.com/apache/thrift/blob/master/NOTICE >> 3. https://github.com/apache/hive/blob/master/NOTICE > >
