Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

Hey Dan, Thanks for running these additional checks, and I agree that this should be fixed. Let's cancel RC1 and I'll cherry pick the fixes and come up with RC2. Kind regards, Fokko Op za 21 okt 2023 om 14:59 schreef Daniel Weeks > I created #88

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

I created #88 to address the last statement because the parsing wasn't configured to require a full expression statement match. Looking at the 'like' tests, I think it missed on the syntax, which should require a `%` to be sql compliant (currently

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

Fokko, I think I found a similar filter problems while experimenting: Using a filter like: t.scan().filter("location_id in (1,2,3)").to_arrow() appears to filter correctly. However, a "like" query silently filters everything out: t.scan().filter("location_id in (1,2,3) and zone_name like 'Jam%'")

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

Fokko clarified offline that the commit I was looking for wasn't moved over to the iceberg-python repo because it didn't affect files in the python/ directory. The last commit that did was https://github.com/apache/iceberg/commit/187c9441a1830d323c862136e74f83876ab400c8, which is in the 0.5.x branc

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

The release build looks fine: - Ran RAT checks - Validated signature and checksum - Ran tests in Python 3.10.5 Unfortunately, I haven't been able to verify the set of changes. I was looking at the 0.5.0-rc3 tag in the main repo: https://github.com/apache/iceberg/commit/f798b06246e67131d413dfceece5

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

+1 non-binding Verified signature and checksum, RAT checks, and ran all unit/integration tests. Thanks, Amogh On Thu, Oct 19, 2023 at 2:23 AM Fokko Driesprong wrote: > +1 (binding) from me as well. > > I ran the example notebooks against the REST catalog >

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

+1 (binding) from me as well. I ran the example notebooks against the REST catalog . Cheers, Fokko Op do 19 okt 2023 om 02:37 schreef Rushan Jiang : > +1 (non-binding) > > - Verified signatures and checksums > - Verified license > - R

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

+1 (non-binding) - Verified signatures and checksums - Verified license - Ran unit tests and integration tests via make test-coverage Thanks, Jonas > On Oct 16, 2023, at 23:14, Jean-Baptiste Onofré wrote: > > +1 (non binding) > > I checked: > - hash and signature are good > - source distribu

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

+1 (non binding) I checked: - hash and signature are good - source distribution is good - run a quick test locally Thanks, Regards JB On Mon, Oct 16, 2023 at 11:28 PM Fokko Driesprong wrote: > > Hi Everyone, > > > I propose that we release the following RC as the official PyIceberg 0.5.1 > rel

[VOTE] Release Apache PyIceberg 0.5.1 (RC1)

Hi Everyone, I propose that we release the following RC as the official PyIceberg 0.5.1 release. This is a patch release due to a bug that has been found . Smaller bugs also have been backported