I created #88 <https://github.com/apache/iceberg-python/pull/88> to address
the last statement because the parsing wasn't configured to require a full
expression statement match.
Looking at the 'like' tests, I think it missed on the syntax, which should
require a `%` to be sql compliant (currently appears to just be evaluating
to "starts with").
-Dan
On Fri, Oct 20, 2023 at 6:15 PM Daniel Weeks <dwe...@apache.org> wrote:
> Fokko, I think I found a similar filter problems while experimenting:
>
> Using a filter like: t.scan().filter("location_id in (1,2,3)").to_arrow()
> appears to filter correctly.
>
> However, a "like" query silently filters everything out:
> t.scan().filter("location_id
> in (1,2,3) and zone_name like 'Jam%'").to_arrow()
>
> A query like: t.scan().filter("location_id in (1,2,3) and
> lower(zone_name) = 'Jamaica Bay'").to_arrow() only applies the first
> predicate and silently ignores the second.
>
> Overall, I'm -1 as I think we have larger issues than just the one case.
>
> -Dan
>
>
> On Fri, Oct 20, 2023 at 12:51 PM Ryan Blue <b...@tabular.io> wrote:
>
>> Fokko clarified offline that the commit I was looking for wasn't moved
>> over to the iceberg-python repo because it didn't affect files in the
>> python/ directory. The last commit that did was
>> https://github.com/apache/iceberg/commit/187c9441a1830d323c862136e74f83876ab400c8,
>> which is in the 0.5.x branch's history.
>>
>> Looks good to me, so I'll vote +1 (binding)
>>
>> On Fri, Oct 20, 2023 at 12:39 PM Ryan Blue <b...@tabular.io> wrote:
>>
>>> The release build looks fine:
>>> - Ran RAT checks
>>> - Validated signature and checksum
>>> - Ran tests in Python 3.10.5
>>>
>>> Unfortunately, I haven't been able to verify the set of changes. I was
>>> looking at the 0.5.0-rc3 tag in the main repo:
>>> https://github.com/apache/iceberg/commit/f798b06246e67131d413dfceece5ccaf269e01fe
>>>
>>> I don't see that commit in the 0.5.x branch. Where did 0.5.x branch from?
>>>
>>> Ryan
>>>
>>> On Thu, Oct 19, 2023 at 5:12 AM Amogh Jahagirdar <am...@tabular.io>
>>> wrote:
>>>
>>>> +1 non-binding
>>>>
>>>> Verified signature and checksum, RAT checks, and ran all
>>>> unit/integration tests.
>>>>
>>>> Thanks,
>>>>
>>>> Amogh
>>>>
>>>> On Thu, Oct 19, 2023 at 2:23 AM Fokko Driesprong <fo...@apache.org>
>>>> wrote:
>>>>
>>>>> +1 (binding) from me as well.
>>>>>
>>>>> I ran the example notebooks against the REST catalog
>>>>> <https://github.com/tabular-io/docker-spark-iceberg/pull/108>.
>>>>>
>>>>> Cheers, Fokko
>>>>>
>>>>> Op do 19 okt 2023 om 02:37 schreef Rushan Jiang <
>>>>> jonasjiang....@gmail.com>:
>>>>>
>>>>>> +1 (non-binding)
>>>>>>
>>>>>> - Verified signatures and checksums
>>>>>> - Verified license
>>>>>> - Ran unit tests and integration tests via make test-coverage
>>>>>>
>>>>>> Thanks,
>>>>>> Jonas
>>>>>>
>>>>>>
>>>>>> > On Oct 16, 2023, at 23:14, Jean-Baptiste Onofré <j...@nanthrax.net>
>>>>>> wrote:
>>>>>> >
>>>>>> > +1 (non binding)
>>>>>> >
>>>>>> > I checked:
>>>>>> > - hash and signature are good
>>>>>> > - source distribution is good
>>>>>> > - run a quick test locally
>>>>>> >
>>>>>> > Thanks,
>>>>>> > Regards
>>>>>> > JB
>>>>>> >
>>>>>> > On Mon, Oct 16, 2023 at 11:28 PM Fokko Driesprong <fo...@apache.org>
>>>>>> wrote:
>>>>>> >>
>>>>>> >> Hi Everyone,
>>>>>> >>
>>>>>> >>
>>>>>> >> I propose that we release the following RC as the official
>>>>>> PyIceberg 0.5.1 release.
>>>>>> >>
>>>>>> >>
>>>>>> >> This is a patch release due to a bug that has been found. Smaller
>>>>>> bugs also have been backported.
>>>>>> >>
>>>>>> >>
>>>>>> >> The commit ID is ea9da8856a686eaeda0d5c2be78d5e3102b67c44
>>>>>> >>
>>>>>> >>
>>>>>> >> * This corresponds to the tag: pyiceberg-0.5.1rc1
>>>>>> (320b0f499d14178210c3b9cb7d94dab1e1b149e6)
>>>>>> >>
>>>>>> >> *
>>>>>> https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.5.1rc1
>>>>>> >>
>>>>>> >> *
>>>>>> https://github.com/apache/iceberg-python/tree/ea9da8856a686eaeda0d5c2be78d5e3102b67c44
>>>>>> >>
>>>>>> >>
>>>>>> >> The release tarball, signature, and checksums are here:
>>>>>> >>
>>>>>> >>
>>>>>> >> *
>>>>>> https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.5.1rc1/
>>>>>> >>
>>>>>> >>
>>>>>> >> You can find the KEYS file here:
>>>>>> >>
>>>>>> >>
>>>>>> >> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS
>>>>>> >>
>>>>>> >>
>>>>>> >> Convenience binary artifacts are staged on pypi:
>>>>>> >>
>>>>>> >>
>>>>>> >> https://pypi.org/project/pyiceberg/0.5.1rc1/
>>>>>> >>
>>>>>> >>
>>>>>> >> And can be installed using: pip3 install pyiceberg==0.5.1rc1
>>>>>> >>
>>>>>> >>
>>>>>> >> Please download, verify, and test.
>>>>>> >>
>>>>>> >>
>>>>>> >> Please vote in the next 72 hours.
>>>>>> >>
>>>>>> >> [ ] +1 Release this as PyIceberg 0.5.1
>>>>>> >>
>>>>>> >> [ ] +0
>>>>>> >>
>>>>>> >> [ ] -1 Do not release this because...
>>>>>> >>
>>>>>> >>
>>>>>> >> Kind regards,
>>>>>> >>
>>>>>> >> Fokko
>>>>>>
>>>>>>
>>>
>>> --
>>> Ryan Blue
>>> Tabular
>>>
>>
>>
>> --
>> Ryan Blue
>> Tabular
>>
>
