Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-30 Thread Steve Zhang
gt;> table and create/drop/load database. >>> >>> Best, >>> Jack Ye >>> >>> From: Daniel Weeks mailto:dwe...@apache.org>> >>> Reply-To: "dev@iceberg.apache.org <mailto:dev@iceberg.apache.org>" >>> mailto:dev@ic

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-30 Thread Driesprong, Fokko
> > *From: *Daniel Weeks > *Reply-To: *"dev@iceberg.apache.org" > *Date: *Wednesday, September 28, 2022 at 9:37 PM > *To: *"dev@iceberg.apache.org" > *Subject: *RE: [EXTERNAL][VOTE] Release Apache PyIceberg 0.1.0 RC2 > > +1 > > I checked sigs/sums/license/tests.

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-29 Thread Anton Okolnychyi
ck Ye > > From: Daniel Weeks > Reply-To: "dev@iceberg.apache.org" > Date: Wednesday, September 28, 2022 at 9:37 PM > To: "dev@iceberg.apache.org" > Subject: RE: [EXTERNAL][VOTE] Release Apache PyIceberg 0.1.0 RC2 > > +1 > > I checked sigs/

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-29 Thread Ye, Jack
9:37 PM To: "dev@iceberg.apache.org" Subject: RE: [EXTERNAL][VOTE] Release Apache PyIceberg 0.1.0 RC2 +1 I checked sigs/sums/license/tests. I ran through the CLI commands with REST Catalog and a few with Hive Metastore. Minor issues (non-blockers): - Miss configuration with uri

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-28 Thread Daniel Weeks
+1 I checked sigs/sums/license/tests. I ran through the CLI commands with REST Catalog and a few with Hive Metastore. Minor issues (non-blockers): - Miss configuration with uri / credentials often resulted in confusing errors (asking to set the fields which were already supplied). - I wasn't

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-26 Thread Ryan Blue
Thanks for the clarification, Fokko! I think it makes sense that I'd get an RC version from what was published as an RC on PyPI! Since we will publish a final artifact with the right version and none of the files in the release candidate are affected (it's correct in the tarball and whl files) the

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-26 Thread Driesprong, Fokko
Thanks everyone for giving it a try. I should have explained the version on PyPI. We need to add the RC postfix to the version when we upload it to PyPI for testing. PyPI will extract the version from the setup.py, and omitting the RC would mean an actual release. The tarball will just contain the

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-25 Thread Steve Zhang
+0 (non-binding and it’s just version needs to be fixed ) Passing: Verified LICENSE in the tarball Checked sha512 sums and signatures Installed the CLI and ran basic commands with a hive metastore and AWS S3 Ran tests (on Docker python 3.9 image some pyarrow tests failed w/ permission issue but

Re: [VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-25 Thread Ryan Blue
+0 Looks great, except that the version isn’t correct: pyiceberg.__version__ returns 0.1.0rc2 Passing: - Verified LICENSE and NOTICE content in the tarball and whl (nit: NOTICE and LICENSE are in different directories) - Checked sha512 sums and signatures - Ran RAT checks (nit: the p

[VOTE] Release Apache PyIceberg 0.1.0 RC2

2022-09-24 Thread Driesprong, Fokko
Hi Everyone, Thanks everyone for giving it a try and for the feedback. Much appreciated! I'm canceling RC1 because the version of the package itself was tagged with RC1. This doesn't allow us to release the code as is since we would have to remove the RC postfix. Other things to make the release