Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

Let me close this vote and start another one for a new RC. Gabor On Thu, Nov 17, 2022 at 9:35 AM Gabor Kaszab wrote: > I'm in favour of creating a new RC. > > Gabor > > On Wed, Nov 16, 2022 at 6:22 PM Ryan Blue wrote: > >> Since there were test failures, what about a new RC? I also merged #618

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

I'm in favour of creating a new RC. Gabor On Wed, Nov 16, 2022 at 6:22 PM Ryan Blue wrote: > Since there were test failures, what about a new RC? I also merged #6187 > that removes a duplicate feature that we would have to support forever > otherwise. > > On Wed, Nov 16, 2022 at 9:09 AM Steven

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

Since there were test failures, what about a new RC? I also merged #6187 that removes a duplicate feature that we would have to support forever otherwise. On Wed, Nov 16, 2022 at 9:09 AM Steven Wu wrote: > Since the unit test failure is just a bug in test code, I will change my > vote to +1. > >

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

Since the unit test failure is just a bug in test code, I will change my vote to +1. +1 (non-binding) 1. Downloaded the source tarball. 1. Verified signature and checksum. 2. Untar the source archive. 3. ./gradlew build. unit test failure due to a bug in test code. non

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests with JDK11 The mentioned test failures around TestExpressionUtil is something we can fix without holding back the release imo as

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

I just merged the fix. Thanks for catching this! On Wed, Nov 16, 2022 at 5:29 AM Gabor Kaszab wrote: > This is going to fix it: https://github.com/apache/iceberg/pull/6200 > The question is do we want to create another release candidate that > contains this fix. I think we should. Adding the abo

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

This is going to fix it: https://github.com/apache/iceberg/pull/6200 The question is do we want to create another release candidate that contains this fix. I think we should. Adding the above patch to the 1.1.0 Milestone . Gabor On Wed, Nov 16, 2022

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

I managed to repro this: Currently I'm in Central Europe and the current date is 16th Nov, but if I set the system timezone to "Pacific/Auckland" then LocalDate.now() gives me 17th Nov. This won't match with the current UTC time created by ExpressionUtil.ExpressionSanitizer.today that is UTC. I ha

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

I believe the issue is that ExpressionUtil takes the current time as UTC while these tests use LocalDate.now()

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

Thanks for the verification Steven! I also ran the iceberg-api tests multiple times but I haven't run into this issue. Is it possible that this is due to some local configs in your environment? It seems suspicious that all these 3 failing tests use LocalDate.now() and these are the only tests that

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

-1 (non-binding) 1. Downloaded the source tarball. 1. Verified signature and checksum. 2. Untar the source archive. 3. ./gradlew build. There are unit test failures (details in the end). 2. Flink SQL testing (both 1.15 and 1.16) 1. Downloaded Iceberg-flink-runtime j

Re: [VOTE] Release Apache Iceberg 1.1.0 RC1

+1 (non binding) Quickly check build and "Apache legal related", not deep dive tests as I'm still learning Iceberg ;) Regards JB On Tue, Nov 15, 2022 at 12:28 PM Gabor Kaszab wrote: > > Hi Everyone, > > I propose that we release the following RC as the official Apache Iceberg > 1.1.0 release.

[VOTE] Release Apache Iceberg 1.1.0 RC1

Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.1.0 release. The commit ID is 1d10c53906847893b45c6acb0137dcb55a15353d * This corresponds to the tag: apache-iceberg-1.1.0-rc1 * https://github.com/apache/iceberg/commits/apache-iceberg-1.1.0-rc1 * https://g