I'm in favour of creating a new RC. Gabor
On Wed, Nov 16, 2022 at 6:22 PM Ryan Blue <b...@tabular.io> wrote: > Since there were test failures, what about a new RC? I also merged #6187 > that removes a duplicate feature that we would have to support forever > otherwise. > > On Wed, Nov 16, 2022 at 9:09 AM Steven Wu <stevenz...@gmail.com> wrote: > >> Since the unit test failure is just a bug in test code, I will change my >> vote to +1. >> >> +1 (non-binding) >> >> >> >> 1. Downloaded the source tarball. >> 1. Verified signature and checksum. >> 2. Untar the source archive. >> 3. ./gradlew build. unit test failure due to a bug in test code. >> non blocker. >> 2. Flink SQL testing (both 1.15 and 1.16) >> 1. Downloaded Iceberg-flink-runtime jars (1.15 and 1.16) from >> Nexus staging repository. >> 2. Batch write worked >> 3. FLIP-27 source batch read worked >> 4. FLIP-27 source streaming read worked >> 5. There is a regression in Flink 1.16.0 (not related to Iceberg >> release). Filed ticket. FLINK-30035. >> >> >> Thanks, >> >> Steven >> >> On Wed, Nov 16, 2022 at 8:30 AM Eduard Tudenhoefner <edu...@tabular.io> >> wrote: >> >>> +1 (non-binding) >>> >>> - validated checksum and signature >>> - checked license docs & ran RAT checks >>> - ran build and tests with JDK11 >>> >>> The mentioned test failures around TestExpressionUtil is something we >>> can fix <https://github.com/apache/iceberg/pull/6200> without holding >>> back the release imo as it's only a test issue around timezones. >>> >>> On Wed, Nov 16, 2022 at 7:33 AM Steven Wu <stevenz...@gmail.com> wrote: >>> >>>> -1 (non-binding) >>>> >>>> >>>> >>>> 1. Downloaded the source tarball. >>>> 1. Verified signature and checksum. >>>> 2. Untar the source archive. >>>> 3. ./gradlew build. There are unit test failures (details in the >>>> end). >>>> 2. Flink SQL testing (both 1.15 and 1.16) >>>> 1. Downloaded Iceberg-flink-runtime jars (1.15 and 1.16) from >>>> Nexus staging repository. >>>> 2. Batch write worked >>>> 3. FLIP-27 source batch read worked >>>> 4. FLIP-27 source streaming read worked >>>> 5. There is a regression in Flink 1.16.0 (not related to Iceberg >>>> release). Filed ticket. FLINK-30035. >>>> >>>> >>>> Thanks, >>>> >>>> Steven >>>> >>>> >>>> > Task :iceberg-api:test >>>> >>>> >>>> org.apache.iceberg.expressions.TestExpressionUtil > >>>> testSanitizeDateNextWeek FAILED >>>> >>>> java.lang.AssertionError: Literals should match >>>> expected:<["(date-7-days-from-now)"]> but was:<["(date-6-days-from-now)"]> >>>> >>>> at org.junit.Assert.fail(Assert.java:89) >>>> >>>> at org.junit.Assert.failNotEquals(Assert.java:835) >>>> >>>> at org.junit.Assert.assertEquals(Assert.java:120) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.assertEquals(TestExpressionUtil.java:825) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.assertEquals(TestExpressionUtil.java:819) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.testSanitizeDateNextWeek(TestExpressionUtil.java:583) >>>> >>>> >>>> org.apache.iceberg.expressions.TestExpressionUtil > >>>> testSanitizeDateLastWeek FAILED >>>> >>>> java.lang.AssertionError: Literals should match >>>> expected:<["(date-7-days-ago)"]> but was:<["(date-8-days-ago)"]> >>>> >>>> at org.junit.Assert.fail(Assert.java:89) >>>> >>>> at org.junit.Assert.failNotEquals(Assert.java:835) >>>> >>>> at org.junit.Assert.assertEquals(Assert.java:120) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.assertEquals(TestExpressionUtil.java:825) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.assertEquals(TestExpressionUtil.java:819) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.testSanitizeDateLastWeek(TestExpressionUtil.java:563) >>>> >>>> >>>> org.apache.iceberg.expressions.TestExpressionUtil > >>>> testSanitizeDateToday FAILED >>>> >>>> java.lang.AssertionError: Literals should match >>>> expected:<["(date-today)"]> but was:<["(date-1-days-ago)"]> >>>> >>>> at org.junit.Assert.fail(Assert.java:89) >>>> >>>> at org.junit.Assert.failNotEquals(Assert.java:835) >>>> >>>> at org.junit.Assert.assertEquals(Assert.java:120) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.assertEquals(TestExpressionUtil.java:825) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.assertEquals(TestExpressionUtil.java:819) >>>> >>>> at >>>> org.apache.iceberg.expressions.TestExpressionUtil.testSanitizeDateToday(TestExpressionUtil.java:543) >>>> >>>> On Tue, Nov 15, 2022 at 8:42 PM Jean-Baptiste Onofré <j...@nanthrax.net> >>>> wrote: >>>> >>>>> +1 (non binding) >>>>> >>>>> Quickly check build and "Apache legal related", not deep dive tests as >>>>> I'm still learning Iceberg ;) >>>>> >>>>> Regards >>>>> JB >>>>> >>>>> On Tue, Nov 15, 2022 at 12:28 PM Gabor Kaszab <gaborkas...@apache.org> >>>>> wrote: >>>>> > >>>>> > Hi Everyone, >>>>> > >>>>> > I propose that we release the following RC as the official Apache >>>>> Iceberg 1.1.0 release. >>>>> > >>>>> > The commit ID is 1d10c53906847893b45c6acb0137dcb55a15353d >>>>> > * This corresponds to the tag: apache-iceberg-1.1.0-rc1 >>>>> > * https://github.com/apache/iceberg/commits/apache-iceberg-1.1.0-rc1 >>>>> > * >>>>> https://github.com/apache/iceberg/tree/1d10c53906847893b45c6acb0137dcb55a15353d >>>>> > >>>>> > The release tarball, signature, and checksums are here: >>>>> > * >>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.1.0-rc1 >>>>> > >>>>> > You can find the KEYS file here: >>>>> > * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>>> > >>>>> > Convenience binary artifacts are staged on Nexus. The Maven >>>>> repository URL is: >>>>> > * >>>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1109/ >>>>> > >>>>> > Please download, verify, and test. >>>>> > >>>>> > Please vote in the next 72 hours. >>>>> > >>>>> > [ ] +1 Release this as Apache Iceberg 1.1.0 >>>>> > [ ] +0 >>>>> > [ ] -1 Do not release this because... >>>>> > >>>>> > PS.: Thanks Fokko for helping me out with the steps requiring >>>>> committer privileges! >>>>> >>>> > > -- > Ryan Blue > Tabular >
