Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 Thanks, Honah! On Thu, Jan 16, 2025 at 3:38 PM Honah J. wrote: > Hi everyone, > > Thank you for your votes and valuable suggestions. I have updated the PR > to remove the statement, "Metrics must be accurate if written," and have > relocated the relevant documentation to Appendix F - Impleme

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

Hi everyone, Thank you for your votes and valuable suggestions. I have updated the PR to remove the statement, "Metrics must be accurate if written," and have relocated the relevant documentation to Appendix F - Implementation Notes. Updated PR: https://github.com/apache/iceberg/pull/11660 Given

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

I don't think can include the statement: "Metrics must be accurate if written" Equality deletes make this requirement very difficult to satisfy for some of the fields. The reason I suggested appendix was that we shouldn't be adding new requirements, just documenting field names for consistency ac

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

@Daniel Weeks what do you think? I know both you and I had the opposite feeling here. On Tue, Jan 14, 2025 at 6:21 PM rdb...@gmail.com wrote: > The content looks correct to me, but because this states a requirement > ("Metrics must be accurate if written") I would rather move this content > int

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 Op wo 15 jan 2025 om 16:21 schreef Eduard Tudenhöfner < etudenhoef...@apache.org>: > +1 > > On Wed, Jan 15, 2025 at 1:20 AM rdb...@gmail.com wrote: > >> The content looks correct to me, but because this states a requirement >> ("Metrics must be accurate if written") I would rather move this c

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 On Wed, Jan 15, 2025 at 1:20 AM rdb...@gmail.com wrote: > The content looks correct to me, but because this states a requirement > ("Metrics must be accurate if written") I would rather move this content > into the section on the snapshot summary instead of an appendix. > > On Tue, Jan 14, 20

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

The content looks correct to me, but because this states a requirement ("Metrics must be accurate if written") I would rather move this content into the section on the snapshot summary instead of an appendix. On Tue, Jan 14, 2025 at 1:30 PM huaxin gao wrote: > +1 non-binding > > On Tue, Jan 14,

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 non-binding On Tue, Jan 14, 2025 at 1:21 PM Steve Zhang wrote: > +1 non-binding > > Thanks, > Steve Zhang > > > > On Jan 14, 2025, at 1:14 PM, Kevin Liu wrote: > > +1 non-binding. > > >

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 non-binding Thanks, Steve Zhang > On Jan 14, 2025, at 1:14 PM, Kevin Liu wrote: > > +1 non-binding.

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 Yufei On Tue, Jan 14, 2025 at 1:16 PM Kevin Liu wrote: > +1 non-binding. > Already +1 and reviewed the PR. Thanks for adding this! It's very useful > as a reference. > > Best, > Kevin Liu > > On Tue, Jan 14, 2025 at 12:05 PM Russell Spitzer < > russell.spit...@gmail.com> wrote: > >> +1 >> >>

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 On Tue, Jan 14, 2025, 21:05 Russell Spitzer wrote: > +1 > > On Tue, Jan 14, 2025 at 2:00 PM Honah J. wrote: > >> Hi everyone, >> >> Based on good feedback on the [DISCUSS] thread >> . and >> the pull request >>

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 non-binding. Already +1 and reviewed the PR. Thanks for adding this! It's very useful as a reference. Best, Kevin Liu On Tue, Jan 14, 2025 at 12:05 PM Russell Spitzer wrote: > +1 > > On Tue, Jan 14, 2025 at 2:00 PM Honah J. wrote: > >> Hi everyone, >> >> Based on good feedback on the [DISCU

Re: [VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

+1 On Tue, Jan 14, 2025 at 2:00 PM Honah J. wrote: > Hi everyone, > > Based on good feedback on the [DISCUSS] thread > . and > the pull request > . I > would lik

[VOTE] Document Snapshot Summary Optional Fields as Appendix in Spec

Hi everyone, Based on good feedback on the [DISCUSS] thread . and the pull request . I would like to raise a vote to add documentation of snapshot summary optional