+1 Thanks, Honah!
On Thu, Jan 16, 2025 at 3:38 PM Honah J. <hon...@apache.org> wrote: > Hi everyone, > > Thank you for your votes and valuable suggestions. I have updated the PR > to remove the statement, "Metrics must be accurate if written," and have > relocated the relevant documentation to Appendix F - Implementation Notes. > > Updated PR: https://github.com/apache/iceberg/pull/11660 > > Given the recent restructuring and additional reviews/modifications in the > PR, I would like to cancel the current vote and initiate a new one later. > This will ensure that all votes are based on the latest version of the spec > change. > > Best regards, > Honah > > On Wed, Jan 15, 2025 at 10:16 AM Daniel Weeks <dwe...@apache.org> wrote: > >> I don't think can include the statement: "Metrics must be accurate if >> written" >> >> Equality deletes make this requirement very difficult to satisfy for some >> of the fields. >> >> The reason I suggested appendix was that we shouldn't be adding new >> requirements, just documenting field names for consistency across >> implementations. >> >> -Dan >> >> On Wed, Jan 15, 2025 at 8:07 AM Russell Spitzer < >> russell.spit...@gmail.com> wrote: >> >>> @Daniel Weeks what do you think? >>> >>> I know both you and I had the opposite feeling here. >>> >>> On Tue, Jan 14, 2025 at 6:21 PM rdb...@gmail.com <rdb...@gmail.com> >>> wrote: >>> >>>> The content looks correct to me, but because this states a requirement >>>> ("Metrics must be accurate if written") I would rather move this content >>>> into the section on the snapshot summary instead of an appendix. >>>> >>>> On Tue, Jan 14, 2025 at 1:30 PM huaxin gao <huaxin.ga...@gmail.com> >>>> wrote: >>>> >>>>> +1 non-binding >>>>> >>>>> On Tue, Jan 14, 2025 at 1:21 PM Steve Zhang >>>>> <hongyue_zh...@apple.com.invalid> wrote: >>>>> >>>>>> +1 non-binding >>>>>> >>>>>> Thanks, >>>>>> Steve Zhang >>>>>> >>>>>> >>>>>> >>>>>> On Jan 14, 2025, at 1:14 PM, Kevin Liu <kevinjq...@apache.org> wrote: >>>>>> >>>>>> +1 non-binding. >>>>>> >>>>>> >>>>>>
