Re: [DISCUSS] Duplicate KEYS files

2024-11-13 Thread Jean-Baptiste Onofré
Hi For context, in multi-subprojects project (like we have in iceberg with Java, Python, rust, go, …) usually we have a single KEYS file gathering the keys from all release managers for the different subprojects. Regards JB Le mar. 12 nov. 2024 à 20:30, Russell Spitzer a écrit : > Yep sorry I

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Kevin Liu
> Kevin, can you flush the caches of your browser? Maybe that's the problem. I'm seeing Matt in there (added him yesterday :). Yep, flushing the cache worked. Thanks! > downloads.a.o is behind a CDN, so it might take a while for changes from SVN to take effect. Its updated now :) ``` ➜ ~ curl -

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Russell Spitzer
Yep sorry I did the merge already of the KEY files On Tue, Nov 12, 2024 at 1:22 PM Fokko Driesprong wrote: > Looks like dev/KEYS ⊂ release/KEYS: https://www.diffchecker.com/4oxGhphl/ > > I've removed the old one. Thanks, everyone, and thanks Kevin for raising > the PRs, let's get those in! > > K

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Fokko Driesprong
There is a consensus on merging them. Let me go ahead and do this. Kevin, can you flush the caches of your browser? Maybe that's the problem. I'm seeing Matt in there (added him yesterday :). Cheers, Fokko Op di 12 nov 2024 om 19:48 schreef Xuanwo : > Hi, > > downloads.a.o is behind a CDN, so

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Fokko Driesprong
Looks like dev/KEYS ⊂ release/KEYS: https://www.diffchecker.com/4oxGhphl/ I've removed the old one. Thanks, everyone, and thanks Kevin for raising the PRs, let's get those in! Kind regards, Fokko Op di 12 nov 2024 om 20:03 schreef Fokko Driesprong : > There is a consensus on merging them. Let

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Xuanwo
Hi, downloads.a.o is behind a CDN, so it might take a while for changes from SVN to take effect. On Wed, Nov 13, 2024, at 01:43, Kevin Liu wrote: > Huh, super weird. I also see it using curl > ``` > curl https://downloads.apache.org/iceberg/KEYS | grep Topol > ``` > but using my web browser dir

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Kevin Liu
> https://downloads.apache.org/iceberg points to https://dist.apache.org/repos/dist/release/iceberg so we don't need to edit it by hand. It looks like the two files are different. For example, search for "Matt Topol", it only appears in the `dist/release` but not in `downloads`. https://downloads.

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Russell Spitzer
I see it in downloads? ➜ icebergsvnrelease git:(master) ✗ curl https://downloads.apache.org/iceberg/KEYS | grep Topol uid [ultimate] Matt Topol sig 34B86A1E5E59C8B81 2024-10-10 Matt Topol uid [ultimate] Matthew Topol sig 34B86A1E5E59C8B81 2023-06-12 Matt T

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Kevin Liu
Huh, super weird. I also see it using curl ``` curl https://downloads.apache.org/iceberg/KEYS | grep Topol ``` but using my web browser directly doesn't show that key for some reason... [image: Screenshot 2024-11-12 at 9.40.06 AM.jpg] The hash is the same for the two files. So I guess they are the

Re: [DISCUSS] Duplicate KEYS files

2024-11-12 Thread Kevin Liu
Hey folks, As mentioned in the previous email. Here are the references to `dist/dev/iceberg/KEYS` https://grep.app/search?q=dist.apache.org/repos/dist/.%2A/iceberg/KEYS®exp=true There are 3 repos mentioned. Here are the corresponding PRs: - iceberg-python https://github.com/apache/iceberg-python/

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Jean-Baptiste Onofré
Hi Fokko As we discussed about that together on Slack, I'm fine merging and removing the dev located KEYS file. Regards JB On Mon, Nov 11, 2024 at 4:13 PM Fokko Driesprong wrote: > > Hi everyone, > > While looking at the release steps for iceberg-go, I noticed that we have two > KEYS files: >

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Kevin Liu
Oh yeah, thank you! On Mon, Nov 11, 2024 at 6:20 PM Xuanwo wrote: > Hi, Kevin > > https://downloads.apache.org/iceberg points to > https://dist.apache.org/repos/dist/release/iceberg > so we don't > need to edit it by hand. > > On Tue, Nov

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Xuanwo
Hi, Kevin https://downloads.apache.org/iceberg points to https://dist.apache.org/repos/dist/release/iceberg so we don't need to edit it by hand. On Tue, Nov 12, 2024, at 10:16, Kevin Liu wrote: > Does anyone know how to edit the KEYS fi

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Kevin Liu
Does anyone know how to edit the KEYS file at https://downloads.apache.org/iceberg/KEYS? The previous instruction [1] uses `svn` which doesn't work with the above URL. ``` svn co https://dist.apache.org/repos/dist/dev/iceberg icebergsvn # works svn co https://downloads.apache.org/iceberg icebergsvn

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Renjie Liu
+1 (binding) for merging. On Tue, Nov 12, 2024 at 1:56 AM Kevin Liu wrote: > +1 (non-binding) > Here are some places in the code base we would need to update. > https://grep.app/search?q=dist.apache.org/repos/dist/.%2A/iceberg/KEYS®exp=true > I also double-checked against the "/KEYS" search, see

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Kevin Liu
+1 (non-binding) Here are some places in the code base we would need to update. https://grep.app/search?q=dist.apache.org/repos/dist/.%2A/iceberg/KEYS®exp=true I also double-checked against the "/KEYS" search, seems like we've captured all the necessary changes above https://grep.app/search?q=/KEYS

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Matt Topol
+1 (non-binding) for merging, I can update the docs on the iceberg Go release README after it's done! On Mon, Nov 11, 2024, 12:20 PM Yufei Gu wrote: > +1 merging sounds good. It should still work for previous releases. > > Yufei > > > On Mon, Nov 11, 2024 at 7:46 AM Xuanwo wrote: > >> Hi >> >>

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Yufei Gu
+1 merging sounds good. It should still work for previous releases. Yufei On Mon, Nov 11, 2024 at 7:46 AM Xuanwo wrote: > Hi > > Thank you, Fokko, for proposing this. Here is my +1, non-binding. > > I'd also like to mention that as part of the ASF release policy, we must > refer to "https://do

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Xuanwo
Hi Thank you, Fokko, for proposing this. Here is my +1, non-binding. I'd also like to mention that as part of the ASF release policy, we must refer to "https://downloads.apache.org/iceberg/KEYS"; for KEYS; other links are not allowed. Ref: https://infra.apache.org/release-download-pages.html#l

Re: [DISCUSS] Duplicate KEYS files

2024-11-11 Thread Russell Spitzer
Sounds good to me, although I guess it's really just up to the Rust and GO maintainers to converge On Mon, Nov 11, 2024 at 9:13 AM Fokko Driesprong wrote: > Hi everyone, > > While looking at the release steps for iceberg-go > , I notice

[DISCUSS] Duplicate KEYS files

2024-11-11 Thread Fokko Driesprong
Hi everyone, While looking at the release steps for iceberg-go , I noticed that we have two KEYS files: - https://dist.apache.org/repos/dist/dev/iceberg/KEYS - https://dist.apache.org/repos/dist/release/iceberg/KEYS (Also availa