Hi For context, in multi-subprojects project (like we have in iceberg with Java, Python, rust, go, …) usually we have a single KEYS file gathering the keys from all release managers for the different subprojects.
Regards JB Le mar. 12 nov. 2024 à 20:30, Russell Spitzer <russell.spit...@gmail.com> a écrit : > Yep sorry I did the merge already of the KEY files > > On Tue, Nov 12, 2024 at 1:22 PM Fokko Driesprong <fo...@apache.org> wrote: > >> Looks like dev/KEYS ⊂ release/KEYS: https://www.diffchecker.com/4oxGhphl/ >> >> I've removed the old one. Thanks, everyone, and thanks Kevin for raising >> the PRs, let's get those in! >> >> Kind regards, >> Fokko >> >> >> Op di 12 nov 2024 om 20:03 schreef Fokko Driesprong <fo...@apache.org>: >> >>> There is a consensus on merging them. Let me go ahead and do this. >>> >>> Kevin, can you flush the caches of your browser? Maybe that's >>> the problem. I'm seeing Matt in there (added him yesterday :). >>> >>> Cheers, Fokko >>> >>> >>> >>> Op di 12 nov 2024 om 19:48 schreef Xuanwo <xua...@apache.org>: >>> >>>> Hi, >>>> >>>> downloads.a.o is behind a CDN, so it might take a while for changes >>>> from SVN to take effect. >>>> >>>> On Wed, Nov 13, 2024, at 01:43, Kevin Liu wrote: >>>> >>>> Huh, super weird. I also see it using curl >>>> ``` >>>> curl https://downloads.apache.org/iceberg/KEYS | grep Topol >>>> ``` >>>> but using my web browser directly doesn't show that key for some >>>> reason... >>>> [image: Screenshot 2024-11-12 at 9.40.06 AM.jpg] >>>> >>>> The hash is the same for the two files. So I guess they are the same. >>>> ``` >>>> ➜ ~ curl -s https://downloads.apache.org/iceberg/KEYS | md5sum >>>> 905987ebcc39a70ebcbce89f1939fe26 - >>>> ➜ ~ curl -s https://dist.apache.org/repos/dist/release/iceberg/KEYS | >>>> md5sum >>>> 905987ebcc39a70ebcbce89f1939fe26 - >>>> ``` >>>> >>>> Best, >>>> Kevin Liu >>>> >>>> >>>> >>>> >>>> On Tue, Nov 12, 2024 at 9:36 AM Russell Spitzer < >>>> russell.spit...@gmail.com> wrote: >>>> >>>> I see it in downloads? >>>> >>>> ➜ icebergsvnrelease git:(master) ✗ curl >>>> https://downloads.apache.org/iceberg/KEYS | grep Topol >>>> uid [ultimate] Matt Topol <zerosh...@apache.org> >>>> sig 3 4B86A1E5E59C8B81 2024-10-10 Matt Topol < >>>> zerosh...@apache.org> >>>> uid [ultimate] Matthew Topol <zotthewiz...@gmail.com> >>>> sig 3 4B86A1E5E59C8B81 2023-06-12 Matt Topol < >>>> zerosh...@apache.org> >>>> sig 4B86A1E5E59C8B81 2023-06-12 Matt Topol < >>>> zerosh...@apache.org> >>>> >>>> >>>> >>>> ➜ icebergsvnrelease git:(master) ✗ grep Topol KEYS >>>> uid [ultimate] Matt Topol <zerosh...@apache.org> >>>> sig 3 4B86A1E5E59C8B81 2024-10-10 Matt Topol < >>>> zerosh...@apache.org> >>>> uid [ultimate] Matthew Topol <zotthewiz...@gmail.com> >>>> sig 3 4B86A1E5E59C8B81 2023-06-12 Matt Topol < >>>> zerosh...@apache.org> >>>> sig 4B86A1E5E59C8B81 2023-06-12 Matt Topol < >>>> zerosh...@apache.org> >>>> >>>> On Tue, Nov 12, 2024 at 11:31 AM Kevin Liu <kevin.jq....@gmail.com> >>>> wrote: >>>> >>>> > https://downloads.apache.org/iceberg points to >>>> https://dist.apache.org/repos/dist/release/iceberg so we don't need to >>>> edit it by hand. >>>> >>>> It looks like the two files are different. For example, search for >>>> "Matt Topol", it only appears in the `dist/release` but not in `downloads`. >>>> https://downloads.apache.org/iceberg/KEYS >>>> https://dist.apache.org/repos/dist/release/iceberg/KEYS >>>> >>>> Best, >>>> Kevin Liu >>>> >>>> >>>> On Tue, Nov 12, 2024 at 9:02 AM Kevin Liu <kevin.jq....@gmail.com> >>>> wrote: >>>> >>>> Hey folks, >>>> >>>> As mentioned in the previous email. Here are the references to >>>> `dist/dev/iceberg/KEYS` >>>> https://grep.app/search?q=dist.apache.org/repos/dist/.%2A/iceberg/KEYS®exp=true >>>> >>>> There are 3 repos mentioned. Here are the corresponding PRs: >>>> - iceberg-python https://github.com/apache/iceberg-python/pull/1315 >>>> - iceberg-go https://github.com/apache/iceberg-go/pull/200 >>>> - iceberg https://github.com/apache/iceberg/pull/11526 >>>> >>>> We will probably want to merge and remove the dev KEYS first. >>>> >>>> Thanks, >>>> Kevin Liu >>>> >>>> On Mon, Nov 11, 2024 at 11:52 PM Jean-Baptiste Onofré <j...@nanthrax.net> >>>> wrote: >>>> >>>> Hi Fokko >>>> >>>> As we discussed about that together on Slack, I'm fine merging and >>>> removing the dev located KEYS file. >>>> >>>> Regards >>>> JB >>>> >>>> On Mon, Nov 11, 2024 at 4:13 PM Fokko Driesprong <fo...@apache.org> >>>> wrote: >>>> > >>>> > Hi everyone, >>>> > >>>> > While looking at the release steps for iceberg-go, I noticed that we >>>> have two KEYS files: >>>> > >>>> > https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>> > https://dist.apache.org/repos/dist/release/iceberg/KEYS (Also >>>> available through https://downloads.apache.org/iceberg/KEYS) >>>> > >>>> > The first one is referenced by Java and Python, and the last one by >>>> Rust. As mentioned earlier, Go references them both. Should we consolidate >>>> these? My suggestion would be to merge the `/dev/` ones into the `release` >>>> ones, and get rid of the one in `dev`. Thoughts? >>>> > >>>> > Kind regards, >>>> > Fokko >>>> >>>> Xuanwo >>>> >>>> https://xuanwo.io/ >>>> >>>>
